Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Ole Streicher
Control: tags -1 patch

Ahh, (partly) my fault: I checked only the result, not the full log.

I've committed a patch to the git repo. Daniel, will you upload or shall I?

Best

Ole



Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Stuart Prescott
> > i was able to reproduce it just now in a clean pbuilder chroot, build
> > log attached
> > 
> > this is still an RC bug affecting stretch

>From what I can see here, these are test failures and not a FTBFS. Is this 
actually an RC bug? 

  https://www.debian.org/Bugs/Developer#severities

  serious:
  is a severe violation of Debian policy (roughly, it violates a "must" or
  "required" directive), or, in the package maintainer's or release manager's
  opinion, makes the package unsuitable for release.

This isn't a violation of policy as the package does not FTBFS. Is the test 
failure an indication to the maintainer that it is unsuitable for release 
because it's generally busted for everyone, or is it still useful for many 
even with a couple of test failures?

(Not debating that this is a bug and fixing it would be better; just checking 
that we're not kidding ourselves with severities)

cheers
Stuart

-- 
Stuart Prescotthttp://www.nanonanonano.net/   stu...@nanonanonano.net
Debian Developer   http://www.debian.org/ stu...@debian.org
GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7



Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Daniel Stender
On 08.02.2017 13:54, Sandro Tosi wrote:
> control: reopen -1
> 
> not so fast..
> 
> On Wed, Feb 8, 2017 at 4:17 AM, Ole Streicher  wrote:
>> Hi Daniel, Sandro,
>>
>> I tried to reproduce the bug and could not get the failure with the
>> latest unstable (Python revision 3.5.3-1). So, I would recommend to
>> either close the bug as unreproducible, or at least to downgrade the
>> severity.
> 
> i was able to reproduce it just now in a clean pbuilder chroot, build
> log attached
> 
> this is still an RC bug affecting stretch

If that remains being a problem: there is somebody interested in taking over the
maintenance for Theano. Maybe she's interested in fixing this bug, too. I'll 
ask.

Let's wait a couple of days longer before removing this package. AUTORM is/was 
on
02-23, not longer than that, though ...

DS

-- 
4096R/DF5182C8
Debian Developer (sten...@debian.org)
http://www.danielstender.com/



Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Sandro Tosi
control: reopen -1

not so fast..

On Wed, Feb 8, 2017 at 4:17 AM, Ole Streicher  wrote:
> Hi Daniel, Sandro,
>
> I tried to reproduce the bug and could not get the failure with the
> latest unstable (Python revision 3.5.3-1). So, I would recommend to
> either close the bug as unreproducible, or at least to downgrade the
> severity.

i was able to reproduce it just now in a clean pbuilder chroot, build
log attached

this is still an RC bug affecting stretch

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi


lasagne_0.1+git20160728.8b66737-1_amd64.build.gz
Description: GNU Zip compressed data


lasagne_0.1+git20160728.8b66737-1_amd64.buildinfo
Description: Binary data


Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Daniel Stender
On 08.02.2017 10:17, Ole Streicher wrote:
> Hi Daniel, Sandro,
> 
> I tried to reproduce the bug and could not get the failure with the
> latest unstable (Python revision 3.5.3-1). So, I would recommend to
> either close the bug as unreproducible, or at least to downgrade the
> severity.
> 
> IMO the package is worth to be kept in Stretch.
> 
> If you don't veto, I would just close the bug in a week.
> 
> Best regards
> 
> Ole

All right with me ...

Best,
Dan

-- 
4096R/DF5182C8
Debian Developer (sten...@debian.org)
http://www.danielstender.com/



Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-08 Thread Ole Streicher
Hi Daniel, Sandro,

I tried to reproduce the bug and could not get the failure with the
latest unstable (Python revision 3.5.3-1). So, I would recommend to
either close the bug as unreproducible, or at least to downgrade the
severity.

IMO the package is worth to be kept in Stretch.

If you don't veto, I would just close the bug in a week.

Best regards

Ole



Bug#834910: lasagne: two tests failing on Python 3.5

2017-02-07 Thread Sandro Tosi
Hey Daniel,

On Sat, 20 Aug 2016 17:16:26 +0200 Daniel Stender  wrote:
> Source: lasagne
> Version: 0.1+git20160728.8b66737-1
> Severity: normal
>
> On Python 3.5, there are two failures in the tests:
...


quite a long time has passed, and likely the git snapshot is outdated
now and it's not even worth reporting this bug upstream (as it may or
may not be fixed but they'd like a check on the new code for sure, and
we cannot upload it to debian during the deep freeze) - should we just
remove lasagne from testing?



Bug#834910: lasagne: two tests failing on Python 3.5

2016-08-20 Thread Daniel Stender
Source: lasagne
Version: 0.1+git20160728.8b66737-1
Severity: normal

On Python 3.5, there are two failures in the tests:


=== FAILURES ===
 TestGetOutput_Layer.test_get_output_with_unused_kwarg _

self = 
layers = (, , )
get_output = 

def test_get_output_with_unused_kwarg(self, layers, get_output):
l1, l2, l3 = layers
unused_kwarg = object()
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
get_output(l3, kwagg=unused_kwarg)
>   assert len(w) == 1
E   assert 3 == 1
E+  where 3 = len([, , 
])

lasagne/tests/layers/test_helper.py:237: AssertionError
___ TestGetOutput_Layer.test_get_output_with_no_unused_kwarg ___

self = 
layers = (, , )
get_output = 

def test_get_output_with_no_unused_kwarg(self, layers, get_output):
l1, l2, l3 = layers
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
get_output(l3)
>   assert len(w) == 0
E   assert 2 == 0
E+  where 2 = len([, ])

lasagne/tests/layers/test_helper.py:246: AssertionError
= 2 failed, 687 passed, 302 skipped in 649.78 seconds ==
E: pybuild pybuild:276: test: plugin custom failed with: exit code=1: python3.5 
-m pytest -v -rs lasagne/


DS

-- 
4096R/DF5182C8
http://www.danielstender.com/blog/



signature.asc
Description: OpenPGP digital signature