Bug#836546: enchant FTCBFS: uses build architecture pkg-config

[Manuel A. Fernandez Montecelo]

Hi,

2017-09-26 0:56 GMT+02:00 Manuel A. Fernandez Montecelo
:
> 2017-09-25 6:57 GMT+02:00 Prach Pongpanich :
>> Hi,
>>
>> On Mon, Sep 25, 2017 at 01:25:17AM +0200, Manuel A. Fernandez Montecelo 
>> wrote:
>>> Hi,
>>>
>>> I'd like to get this issue fixed, I could prepare an NMU in the next few
>>> days.
>>>
>>> This package is under LowNMU clause, but still I though that it would be
>>> nice to ask if it's OK with the maintainer,because the patch is slightly
>>> intrusive with the upstream source.
>>>
>>
>> Please go ahead, the repo is in collab-maint [0].
>>
>> [0] https://anonscm.debian.org/cgit/collab-maint/enchant.git
>
>
> Done and pushed, thanks!
>
> BTW, there's a lintian error about using "activate-noawait ldconfig",
> I think that it's because of the triggers file:
> debian/libenchant1c2a.triggers , it's probably implicit due to being a
> package with libraries or something, thus appearing as duplicate even
> if there's only one line in that file.
>
> My advice is to remove the file and check that nothing breaks in the
> local system.  I didn't fix it because I am not familiar with the
> library and what uses it.

After 2 unsuccessful attempts due to mismatching .orig.tar
(git-buildpackage changed the place where it looks for such files), it
went through and built in almost all arches in the buildds.

I also pushed the fix for the double triggers, but didn't include it
in the upload:

  
https://anonscm.debian.org/cgit/collab-maint/enchant.git/commit/?id=7d688257524064d98e8ee0450996a7dc068487b8


This is the current file in my system, which shows the duplicated
lines  that cause the lintian error, due to dh_makeshlibs adding a
line automatically:

  $ cat '/var/lib/dpkg/info/libenchant1c2a:amd64.triggers'
  activate-noawait ldconfig
  # Triggers added by dh_makeshlibs
  activate-noawait ldconfig


Cheers.
-- 
Manuel A. Fernandez Montecelo 

Bug#836546: enchant FTCBFS: uses build architecture pkg-config

[Manuel A. Fernandez Montecelo]

2017-09-25 6:57 GMT+02:00 Prach Pongpanich :
> Hi,
>
> On Mon, Sep 25, 2017 at 01:25:17AM +0200, Manuel A. Fernandez Montecelo wrote:
>> Hi,
>>
>> I'd like to get this issue fixed, I could prepare an NMU in the next few
>> days.
>>
>> This package is under LowNMU clause, but still I though that it would be
>> nice to ask if it's OK with the maintainer,because the patch is slightly
>> intrusive with the upstream source.
>>
>
> Please go ahead, the repo is in collab-maint [0].
>
> [0] https://anonscm.debian.org/cgit/collab-maint/enchant.git


Done and pushed, thanks!

BTW, there's a lintian error about using "activate-noawait ldconfig",
I think that it's because of the triggers file:
debian/libenchant1c2a.triggers , it's probably implicit due to being a
package with libraries or something, thus appearing as duplicate even
if there's only one line in that file.

My advice is to remove the file and check that nothing breaks in the
local system.  I didn't fix it because I am not familiar with the
library and what uses it.

Cheers and thanks again!


-- 
Manuel A. Fernandez Montecelo 

Bug#836546: enchant FTCBFS: uses build architecture pkg-config

[Prach Pongpanich]

Hi,

On Mon, Sep 25, 2017 at 01:25:17AM +0200, Manuel A. Fernandez Montecelo wrote:
> Hi,
> 
> I'd like to get this issue fixed, I could prepare an NMU in the next few
> days.
> 
> This package is under LowNMU clause, but still I though that it would be
> nice to ask if it's OK with the maintainer,because the patch is slightly
> intrusive with the upstream source.
> 

Please go ahead, the repo is in collab-maint [0].

[0] https://anonscm.debian.org/cgit/collab-maint/enchant.git

Best regards,
Prach


signature.asc
Description: PGP signature

Bug#836546: enchant FTCBFS: uses build architecture pkg-config

[Manuel A. Fernandez Montecelo]

Hi,

2016-09-03 23:02 Helmut Grohne:

Source: enchant
Version: 1.6.0-11
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

enchant fails to cross build from source, because it uses the build
architecture pkg-config. It has two checks for pkg-config (one implicit
and and explicit) where the explicit has a bad default and the implicit
reuses the previous value. The attached patch removes the unneeded,
explicit check and thus makes cross building work.


I'd like to get this issue fixed, I could prepare an NMU in the next few
days.

This package is under LowNMU clause, but still I though that it would be
nice to ask if it's OK with the maintainer,because the patch is slightly
intrusive with the upstream source.


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#836546: enchant FTCBFS: uses build architecture pkg-config

[Helmut Grohne]

Source: enchant
Version: 1.6.0-11
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

enchant fails to cross build from source, because it uses the build
architecture pkg-config. It has two checks for pkg-config (one implicit
and and explicit) where the explicit has a bad default and the implicit
reuses the previous value. The attached patch removes the unneeded,
explicit check and thus makes cross building work.

Helmut
diff --minimal -Nru enchant-1.6.0/debian/changelog 
enchant-1.6.0/debian/changelog
--- enchant-1.6.0/debian/changelog  2016-05-01 18:29:59.0 +0200
+++ enchant-1.6.0/debian/changelog  2016-09-03 22:58:11.0 +0200
@@ -1,3 +1,10 @@
+enchant (1.6.0-11.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: cross_build.diff (Closes: #-1)
+
+ -- Helmut Grohne   Sat, 03 Sep 2016 22:54:54 +0200
+
 enchant (1.6.0-11) unstable; urgency=medium
 
   [ Mattia Rizzolo ]
diff --minimal -Nru enchant-1.6.0/debian/patches/cross_build.diff 
enchant-1.6.0/debian/patches/cross_build.diff
--- enchant-1.6.0/debian/patches/cross_build.diff   1970-01-01 
01:00:00.0 +0100
+++ enchant-1.6.0/debian/patches/cross_build.diff   2016-09-03 
23:00:19.0 +0200
@@ -0,0 +1,23 @@
+From: Helmut Grohne 
+Last-Modified: 2016-09-03
+Subject: do not supply a bad default for the PKG_CONFIG check
+
+PKG_CHECK_MODULES implicitly checks for a suitable cross pkg-config and uses
+$PKG_CONFIG as a default. The preceeding AC_PATH_PROG supplies that variables
+with its default value "pkg-config" instead of the a value that carries the
+host architecture as a prefix. By removing the (otherwise unused AC_PATH_PROG),
+the implicit check can do the right thing.
+
+Index: enchant-1.6.0/configure.in
+===
+--- enchant-1.6.0.orig/configure.in
 enchant-1.6.0/configure.in
+@@ -48,8 +48,6 @@
+ AC_PROG_CXX(,have_cxx=no)
+ AM_CONDITIONAL(WITH_CXX, test "x$have_cxx" = "xyes")
+ 
+-AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
+-
+ PKG_CHECK_MODULES(ENCHANT, [glib-2.0 >= 2.6 gmodule-2.0])
+ 
+ dnl 
===
diff --minimal -Nru enchant-1.6.0/debian/patches/series 
enchant-1.6.0/debian/patches/series
--- enchant-1.6.0/debian/patches/series 2016-05-01 17:20:07.0 +0200
+++ enchant-1.6.0/debian/patches/series 2016-09-03 22:56:35.0 +0200
@@ -4,3 +4,4 @@
 02-new-ispell-format.diff
 02_Requires-Private.diff
 fix_for_hunspell_1.4.diff
+cross_build.diff