Bug#838014: RFS: imagemagick
Le samedi 17 septembre 2016, 17:28:03 CEST Mattia Rizzolo a écrit : > On Sat, Sep 17, 2016 at 06:23:19PM +0200, Bastien ROUCARIÈS wrote: > > > I recall you were saying something about this aiming to experimental, > > > because some SONAME changed (I didn't really checkout), which must also > > > be the reason you're asking for sponsorship (=> the package will go > > > through NEW, so you can't upload yourself). But your upload is > > > targetting unstable. > > > > Corrected > > That means you're going to start a transition. I won't help you with > that unless you get an ACK from the release team, which afaik you > haven't. Yes what why I have set experimental as distrib. I am wiaiting for release team. When ligh will be green I will reupload to unstable (I could do this myself because I am a DM). WIll open a bug for release team > > > > Things I want to see fixed: > > > > > > 1/ you didn't incorporate any NMU > > > > Change included and NMU aknowledge. This version go back before the NMU > > you don't need anymore (since a decade…) to reclose the bugs if you're > including the old changelog entries. Removed > > > > 2/ the Vcs-* field, Vcs-Git is plain broken. > > > > Done > > not in git. Pushed > > > > Other things that you may consider changes in future, not needed now: > Great that you did most of them, but you didn't push (at least not to > debian/6.9.5.9+dfsg-1) > > > Now building will remove package from mentors and uploading a new one > > no need if you push to git. pushed signature.asc Description: This is a digitally signed message part.
Bug#838014: RFS: imagemagick
On Sat, Sep 17, 2016 at 06:23:19PM +0200, Bastien ROUCARIÈS wrote: > > I recall you were saying something about this aiming to experimental, > > because some SONAME changed (I didn't really checkout), which must also > > be the reason you're asking for sponsorship (=> the package will go > > through NEW, so you can't upload yourself). But your upload is > > targetting unstable. > > Corrected That means you're going to start a transition. I won't help you with that unless you get an ACK from the release team, which afaik you haven't. > > Things I want to see fixed: > > > > 1/ you didn't incorporate any NMU > > Change included and NMU aknowledge. This version go back before the NMU you don't need anymore (since a decade…) to reclose the bugs if you're including the old changelog entries. > > 2/ the Vcs-* field, Vcs-Git is plain broken. > > Done not in git. > > Other things that you may consider changes in future, not needed now: Great that you did most of them, but you didn't push (at least not to debian/6.9.5.9+dfsg-1) > Now building will remove package from mentors and uploading a new one no need if you push to git. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#838014: RFS: imagemagick
Le samedi 17 septembre 2016 08:50:56 CEST, vous avez écrit : > control: owner -1 ! > control: tag -1 moreinfo > > On Fri, Sep 16, 2016 at 02:29:45PM +0200, Bastien ROUCARIES wrote: > > I am looking for a sponsor for my package "imagemagick" > > great! > > > dget -x > > https://mentors.debian.net/debian/pool/main/i/imagemagick/imagemagick > > _6.9.5.9+dfsg-1.dsc > I've eventually managed to domate gitpkg, and I succeeded at building a > .dsc out of it. dsc that matches yours in all the things, except for > the timestamps in debian.tar.xz. Am I right that you built your package > in jessie? (Or anyway, with a dpkg << 1.18.10, which is the one that > started to build reproducible source packages). I build in jessie but using pbuilder > > This also means that with me you don't really need (anymore) to provide > me a .dsc to dget, git pushing changes is going to be enough. > > Another question about that git repository: I see there are very few > tags. Shall I suppose tags means nothing in this repository format? > Means nothing. They are only branch > > I recall you were saying something about this aiming to experimental, > because some SONAME changed (I didn't really checkout), which must also > be the reason you're asking for sponsorship (=> the package will go > through NEW, so you can't upload yourself). But your upload is > targetting unstable. Corrected > > Things I want to see fixed: > > 1/ you didn't incorporate any NMU, nor mine (which upsets me as a NMUer > trying to do QA work), nor pochu's (which is fixing a CVE, that I > suppose has been fixed upstream already so that's not so relevant. > Not including my NMU means your package gains another RC bug, and just > because you're lucky (src:kodi has yet to be fixed…) your package would > migrate to testing, but in normal circumstances it wouldn't. > The changelog is also lacking the unstable uploads for -6 and -7. I can > understand -7 where you only backported some patches that are probably > already present, but judging by the changelog I suppose -6 is also some > packaging changes; have them be included? Change included and NMU aknowledge. This version go back before the NMU > 2/ the Vcs-* field, Vcs-Git is plain broken. If I were you I'd set both > Vcs fields to > https://anonscm.debian.org/git/collab-maint/imagemagick.git > That url works both as a cgit frontend. > It's something that I'm pointing out and "forcing" to be fixed due to so > seldom uploads of imagemagick... and it's fairly annoying not being > able to use `debcheckout`. > Done > Other things that you may consider changes in future, not needed now: > I've only peaked randomly at d/rules, nothing more, so this is probably > incomplete. > > 1/ > STATIC_DEB_SOURCE_PACKAGE could be take by > dpkg-parsechangelog -SSource > Also STATIC_DEB_VERSION you could use > dpkg-parsechangelog -SVersion > instead of doing grep/cut. Or you could include > /usr/share/dpkg/pkg-info.mk and use the variables provided by it (not > exported though). Done. Need to be exported so I do not think will use pkg-info > 2/ > Actually I'm really not sure why you export all the variables... I'm > sure you don't need all of them exported. Will review for next version > 3/ > you have a weird if in the % target. The bug cited there is long fixed, > so probably that if is not needed anymore? Bug number was false. Corrected the bug number. This bug is still opened and in automake > 4/ you got a 'fpu_is present' target, totally unused. The most funny > bit is the presence of the space in the target name. I figure you are > better by removing the target. And if you don't want to remove it, then > you might avoid a small DRY violation by making override_dh_autoreconf > depend on that target (after the name is fixed). Removed > 5/ all the patches have 'Forwarded: Yes'. That's cool, but according > to DEP-3, Forwarded should contain the place where they have been > forwarded, not just "Yes". i.e., a patch reviewing place, an upstream > bug, a mailing list post, ... Sending by mail to upstream. Will add indication in next version. Now building will remove package from mentors and uploading a new one Bastien signature.asc Description: This is a digitally signed message part.
Bug#838014: RFS: imagemagick
control: owner -1 ! control: tag -1 moreinfo On Fri, Sep 16, 2016 at 02:29:45PM +0200, Bastien ROUCARIES wrote: > I am looking for a sponsor for my package "imagemagick" great! > dget -x > https://mentors.debian.net/debian/pool/main/i/imagemagick/imagemagick_6.9.5.9+dfsg-1.dsc I've eventually managed to domate gitpkg, and I succeeded at building a .dsc out of it. dsc that matches yours in all the things, except for the timestamps in debian.tar.xz. Am I right that you built your package in jessie? (Or anyway, with a dpkg << 1.18.10, which is the one that started to build reproducible source packages). This also means that with me you don't really need (anymore) to provide me a .dsc to dget, git pushing changes is going to be enough. Another question about that git repository: I see there are very few tags. Shall I suppose tags means nothing in this repository format? I recall you were saying something about this aiming to experimental, because some SONAME changed (I didn't really checkout), which must also be the reason you're asking for sponsorship (=> the package will go through NEW, so you can't upload yourself). But your upload is targetting unstable. Things I want to see fixed: 1/ you didn't incorporate any NMU, nor mine (which upsets me as a NMUer trying to do QA work), nor pochu's (which is fixing a CVE, that I suppose has been fixed upstream already so that's not so relevant. Not including my NMU means your package gains another RC bug, and just because you're lucky (src:kodi has yet to be fixed…) your package would migrate to testing, but in normal circumstances it wouldn't. The changelog is also lacking the unstable uploads for -6 and -7. I can understand -7 where you only backported some patches that are probably already present, but judging by the changelog I suppose -6 is also some packaging changes; have them be included? 2/ the Vcs-* field, Vcs-Git is plain broken. If I were you I'd set both Vcs fields to https://anonscm.debian.org/git/collab-maint/imagemagick.git That url works both as a cgit frontend. It's something that I'm pointing out and "forcing" to be fixed due to so seldom uploads of imagemagick... and it's fairly annoying not being able to use `debcheckout`. Other things that you may consider changes in future, not needed now: I've only peaked randomly at d/rules, nothing more, so this is probably incomplete. 1/ STATIC_DEB_SOURCE_PACKAGE could be take by dpkg-parsechangelog -SSource Also STATIC_DEB_VERSION you could use dpkg-parsechangelog -SVersion instead of doing grep/cut. Or you could include /usr/share/dpkg/pkg-info.mk and use the variables provided by it (not exported though). 2/ Actually I'm really not sure why you export all the variables... I'm sure you don't need all of them exported. 3/ you have a weird if in the % target. The bug cited there is long fixed, so probably that if is not needed anymore? 4/ you got a 'fpu_is present' target, totally unused. The most funny bit is the presence of the space in the target name. I figure you are better by removing the target. And if you don't want to remove it, then you might avoid a small DRY violation by making override_dh_autoreconf depend on that target (after the name is fixed). 5/ all the patches have 'Forwarded: Yes'. That's cool, but according to DEP-3, Forwarded should contain the place where they have been forwarded, not just "Yes". i.e., a patch reviewing place, an upstream bug, a mailing list post, ... -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#838014: RFS: imagemagick
Package: sponsorship-requests Severity: important X-Debbugs-CC: Mattia RizzoloX-Debbugs-CC: Salvatore Bonaccorso Dear mentors, I am looking for a sponsor for my package "imagemagick" * Package name: imagemagick Version : 8:6.9.5.9+dfsg-1 Section : graphics It builds those binary packages: imagemagick - image manipulation programs -- binaries imagemagick-6-common - image manipulation programs -- infrastructure imagemagick-6-doc - document files of ImageMagick imagemagick-6.q16 - image manipulation programs -- quantum depth Q16 imagemagick-common - image manipulation programs -- infrastructure dummy package imagemagick-doc - document files of ImageMagick -- dummy package libimage-magick-perl - Perl interface to the ImageMagick graphics routines libimage-magick-q16-perl - Perl interface to the ImageMagick graphics routines -- Q16 versio libmagick++-6-headers - object-oriented C++ interface to ImageMagick - header files libmagick++-6.q16-6v6 - object-oriented C++ interface to ImageMagick libmagick++-6.q16-dev - object-oriented C++ interface to ImageMagick - development files libmagick++-dev - object-oriented C++ interface to ImageMagick -- dummy package libmagickcore-6-arch-config - low-level image manipulation library - architecture header files libmagickcore-6-headers - low-level image manipulation library - header files libmagickcore-6.q16-2 - low-level image manipulation library -- quantum depth Q16 libmagickcore-6.q16-2-extra - low-level image manipulation library - extra codecs (Q16) libmagickcore-6.q16-dev - low-level image manipulation library - development files (Q16) libmagickcore-dev - low-level image manipulation library -- dummy package libmagickwand-6-headers - image manipulation library - headers files libmagickwand-6.q16-2 - image manipulation library libmagickwand-6.q16-dev - image manipulation library - development files libmagickwand-dev - image manipulation library -- dummy package perlmagick - Perl interface to ImageMagick -- dummy package To access further information about this package, please visit the following URL: https://mentors.debian.net/package/imagemagick Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/i/imagemagick/imagemagick_6.9.5.9+dfsg-1.dsc More information about hello can be obtained from https://www.example.com. Regards, bastien roucaries