Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[gustavo panizzo]

On Wed, Oct 19, 2016 at 08:43:31PM +0200, Tobias Frost wrote:
> Hi Gustavo,
> 
> Am Mittwoch, den 19.10.2016, 14:15 +0800 schrieb gustavo panizzo:
> > On Sun, Oct 16, 2016 at 10:35:42AM +0200, Tobias Frost wrote:
> > > 
> > > Please fix the lintian error, the d/copyright and then I'll upload.
> > > The *.la can be fixed in a subsequent upload, but maybe you can
> > > include
> > > it already in the revised packages.
> > 
> > 
> > I've pushed to alioth, please take a look
> > 
> 
> Please recheck, I can't see the changes here.

sorry about that. Can you try again?

thanks!

-- 
1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333

keybase: https://keybase.io/gfa


signature.asc
Description: PGP signature

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Tobias Frost]

Hi Gustavo,

Am Mittwoch, den 19.10.2016, 14:15 +0800 schrieb gustavo panizzo:
> On Sun, Oct 16, 2016 at 10:35:42AM +0200, Tobias Frost wrote:
> > 
> > Please fix the lintian error, the d/copyright and then I'll upload.
> > The *.la can be fixed in a subsequent upload, but maybe you can
> > include
> > it already in the revised packages.
> 
> 
> I've pushed to alioth, please take a look
> 

Please recheck, I can't see the changes here.

tobi@edoras:~/workspace/deb/nm/gustavo/uptimed/uptimed$ git remote get-
url origin
git.debian.org:/git/collab-maint/uptimed.git
tobi@edoras:~/workspace/deb/nm/gustavo/uptimed/uptimed$ git log | head
-n 10
commit 1490651ea12e9db47e839c947da867971bab9b18
Author: Holger Wansing 
Date:   Tue Oct 18 22:41:44 2016 +0200

German translation: proofreading by Markus Hiereth, thanks!

commit 118d01074feb3dee9079950d6976634e391255b9
Author: Holger Wansing 
Date:   Sat Oct 15 15:36:50 2016 +0200



> (archive-gfa@nm.d.o is bcc'ed)
> 
> 
> 

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[gustavo panizzo]

On Sun, Oct 16, 2016 at 10:35:42AM +0200, Tobias Frost wrote:
> 
> Please fix the lintian error, the d/copyright and then I'll upload.
> The *.la can be fixed in a subsequent upload, but maybe you can include
> it already in the revised packages.

I've pushed to alioth, please take a look


(archive-gfa@nm.d.o is bcc'ed)


-- 
1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333

keybase: https://keybase.io/gfa


signature.asc
Description: PGP signature

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Tobias Frost]

Hallo Gustavo,

 
> * there is an linitian _error_ init.d-script-needs-depends-on-lsb-
>   base, but that should be easy to fix.

Never mind this one, it will be removed from lintian.
(#838997)


--
tobi

signature.asc
Description: This is a digitally signed message part

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Tobias Frost]

Hallo Gustavo,

thanks for adopting the package!

ok, let's start with the review.
(The review is part of the NM process, gustavo's NM archive gets a copy
via BCC) 

Am Dienstag, den 04.10.2016, 18:22 +0800 schrieb gustavo panizzo:
> Package: sponsorship-requests
> Severity: normal
> 
> Hello
> 
> I'm looking for an sponsor of my package uptimed,
> I want to adopt this package after it was orphaned by the previous
> maintainer #830765
> 
> uptimed is an old package (in debian since '99) it has many bugs
> open,
> I fixed some bugs but others I wasn't able to reproduce them,
> so my plan is to upload to experimental
> and contact the reporters to see if they/I can reproduce the bugs
> then fix
> them.
> 
> I want to upload to experimental to check if it builds reproducibly
> in all Debian architectures.
> Be aware that I'll request another upload latter for unstable.
> 
> debian/rules and packaging in general was polished, modernized, and
> uploaded
> to collab-maint
> 
> this is the changelog

let me nitpick on your changelog a bit ;-)

> uptimed (1:0.4.0+git20150923.6b22106-1) experimental; urgency=medium
> 
>   * New maintainer, thanks Thibaut Varene for your previous
> work (Closes: #830765)
>   * Packaging is now maintained in collab-maint using a git repo

>   * Packaging an snapshot from upstream
>   * Packaging using git tags instead of tarballs

Those are acutally one change, not two.

>   * Change dh compat to level 9. No changes were needed
>   * Build depend on debhelper 9 and dh-autoreconf

those two lines are a little contradicting, you need the B-D version
for compat 9; and why not go for compat 10, it makes dh-autoreconf
default, for instance.  

>   * Update Homepage field on debian/control (Closes: #806456)
>   * Handle missing /etc/uptimed.conf (Closes: #680419)
>   * Simplify uptimed init.d script, restart unconditionally on
> uptimed
> postinst
>   * Match the location of the $PIDFILE in the init script and the
> daemon
> configuration (Closes: #336922) (LP: #482629)
>   * Create /run/uptimed via a tmpfile on systemd systems
>   * Change the default interval to save the database from 300 to 3600
> seconds

why? (changelogs should answer those questions...)

>   * Bump Standards-Version to 3.9.8. No changes were needed
>   * Override 2 lintian warnings (unused-debconf-template)

Why is the override neccessary?

>   * Remove perl dependency on libuptimed0 and libuptimed-dev, perl-
> base is
> enough
>   * Change watch file to look at github
>   * Update uptimed's service file, to start after the time is in
> sync,
> it still may fail if systemd-timesyncd.service is not in use
> 

as said, those are nitpicks but a important reason to have changelogs
is to transport the information why something has changed and not only
what. This gives the users the opportunity to assess if a change
affects them. 

Another nitpick is: try to group related changes, it helps
understanding them.

To the package:
 * d/*.dirs shouldn't be neccessary anymore, 
 * *.la files should not be distributed anymore, did you check if it
   can vbe dropped? (https://wiki.debian.org/ReleaseGoals/LAFileRemoval
   )
 * d/control: the "Replaces: libuptimed" could be dropped (it is from a
   release long long ago; nitpick)
 * ist uptime.conf.5 regenerated at build time? its header says it
   should... 
 * there is an linitian _error_ init.d-script-needs-depends-on-lsb-
   base, but that should be easy to fix.
 * the spelling fix patch is not documented in the changelog
  * d/copyright is incomplete, I see at least one file with is not
covered: src/sd-daemon.c by L. Poettering

Please fix the lintian error, the d/copyright and then I'll upload.
The *.la can be fixed in a subsequent upload, but maybe you can include
it already in the revised packages.

-- 
tobi

signature.asc
Description: This is a digitally signed message part

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Dmitry Bogatov]

[2016-10-10 20:44] gustavo panizzo 
>
> part   text/plain 336
> On Mon, Oct 10, 2016 at 07:57:30AM +0300, Dmitry Bogatov wrote:
>
> > Could you please add option to run it in foreground? Runit init
> > system, which I package exect services to be foreground processes.
>
> uptimed -f makes uptimed to run in foreground

That a great news, since actual version in sid/jessie/testing
(1:0.3.17) does not advertise such option.

Thank you for you work.

-- 
X-Web-Site: https://sinsekvu.github.io | Note that I process my email in batch,
Accept-Languages: eo,ru,en | at most once every 24 hours. If matter
Accept: text/plain, text/x-diff| is urgent, you have my phone number.

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[gustavo panizzo]

On Mon, Oct 10, 2016 at 07:57:30AM +0300, Dmitry Bogatov wrote:

> Could you please add option to run it in foreground? Runit init
> system, which I package exect services to be foreground processes.

uptimed -f makes uptimed to run in foreground

--
1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333

keybase: https://keybase.io/gfa

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Dmitry Bogatov]

[2016-10-04 18:22] gustavo panizzo 
>
> I'm looking for an sponsor of my package uptimed,
> I want to adopt this package after it was orphaned by the previous
> maintainer #830765
>
> I want to upload to experimental to check if it builds reproducibly in all 
> Debian architectures.
> Be aware that I'll request another upload latter for unstable.
> [...]
> this is the changelog

Could you please add option to run it in foreground? Runit init
system, which I package exect services to be foreground processes.

-- 
X-Web-Site: https://sinsekvu.github.io | Note that I process my email in batch,
Accept-Languages: eo,ru,en | at most once every 24 hours. If matter
Accept: text/plain, text/x-diff| is urgent, you have my phone number.

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[Tobias Frost]

Control: owner -1 !

I will take a look at part of gustavo's NM process.

--
tobi

Bug#839725: uptimed: 0.4.0+git20150923.6b22106-1 [ITA]

[gustavo panizzo]

Package: sponsorship-requests
Severity: normal

Hello

I'm looking for an sponsor of my package uptimed,
I want to adopt this package after it was orphaned by the previous
maintainer #830765

uptimed is an old package (in debian since '99) it has many bugs open,
I fixed some bugs but others I wasn't able to reproduce them,
so my plan is to upload to experimental
and contact the reporters to see if they/I can reproduce the bugs then fix
them.

I want to upload to experimental to check if it builds reproducibly in all 
Debian architectures.
Be aware that I'll request another upload latter for unstable.

debian/rules and packaging in general was polished, modernized, and uploaded
to collab-maint

this is the changelog

uptimed (1:0.4.0+git20150923.6b22106-1) experimental; urgency=medium

  * New maintainer, thanks Thibaut Varene for your previous
work (Closes: #830765)
  * Packaging is now maintained in collab-maint using a git repo
  * Packaging an snapshot from upstream
  * Packaging using git tags instead of tarballs
  * Change dh compat to level 9. No changes were needed
  * Build depend on debhelper 9 and dh-autoreconf
  * Update Homepage field on debian/control (Closes: #806456)
  * Handle missing /etc/uptimed.conf (Closes: #680419)
  * Simplify uptimed init.d script, restart unconditionally on uptimed
postinst
  * Match the location of the $PIDFILE in the init script and the daemon
configuration (Closes: #336922) (LP: #482629)
  * Create /run/uptimed via a tmpfile on systemd systems
  * Change the default interval to save the database from 300 to 3600 seconds
  * Bump Standards-Version to 3.9.8. No changes were needed
  * Override 2 lintian warnings (unused-debconf-template)
  * Remove perl dependency on libuptimed0 and libuptimed-dev, perl-base is
enough
  * Change watch file to look at github
  * Update uptimed's service file, to start after the time is in sync,
it still may fail if systemd-timesyncd.service is not in use
  * Update uptimed's service to provide uptimed's documentation
  * More modern debian/rules
  * Print a warning on debconf when reducing MAX_RECORDS (Closes: #573232)
  * Add pristine-tar to git repo

 -- gustavo panizzo   Tue, 04 Oct 2016 15:58:19 +0800


git repo can be found here

git.debian.org:/git/collab-maint/uptimed.git

built package can be found on mentors
https://mentors.debian.net/debian/pool/main/u/uptimed/uptimed_0.4.0+git20150923.6b22106-1.dsc


thanks!

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (300, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)