Bug#839894: Last chance for d-i changes in stretch
Cyril Brulebois (2017-06-03): > This looks good to me, I've uploaded it to unstable, and added a note on > my d-i checklist to make sure I don't forget about it before the next > release. Except this doesn't work except for your JBOD use case… Adding [a-z]* at the end of the pattern means we *need* an extra letter (as opposed to regex syntax which means an extra letter would have been optional). I'll switch this to restoring the earlier pattern and adding the same with an extra letter as a second pattern, and double check the results. Sorry for not catching this sooner. KiBi. signature.asc Description: Digital signature
Bug#839894: Last chance for d-i changes in stretch
Hi all, Roger Shimizu (2017-06-03): > On Fri, Jun 2, 2017 at 9:58 PM, Hideki Yamane wrote: > > > > On Tue, 30 May 2017 21:52:06 +0900 > > Roger Shimizu wrote: > > > > -/dev/[hsv]d[a-z0-9]| > > > > +/dev/[hsv]d[a-z0-9][a-z]*| > > > > > > And I pushed the fix commit to branch "fix_839894": > > > > > > https://anonscm.debian.org/cgit/d-i/grub-installer.git/commit/?h=fix_839894&id=9927e8c > > > > I've tested it with VBox and works well, see attached screenshot. > > Thanks for your verification! > > So I pushed the commit to branch master. > > > KiBi, if you're fine with it, please kindly help to release/upload. > Hope it still can catch up with r0. This looks good to me, I've uploaded it to unstable, and added a note on my d-i checklist to make sure I don't forget about it before the next release. Thanks! KiBi. signature.asc Description: Digital signature
Bug#839894: Last chance for d-i changes in stretch
On Fri, Jun 2, 2017 at 9:58 PM, Hideki Yamane wrote: > > On Tue, 30 May 2017 21:52:06 +0900 > Roger Shimizu wrote: > > > -/dev/[hsv]d[a-z0-9]| > > > +/dev/[hsv]d[a-z0-9][a-z]*| > > > > And I pushed the fix commit to branch "fix_839894": > > > > https://anonscm.debian.org/cgit/d-i/grub-installer.git/commit/?h=fix_839894&id=9927e8c > > I've tested it with VBox and works well, see attached screenshot. Thanks for your verification! So I pushed the commit to branch master. > KiBi, if you're fine with it, please kindly help to release/upload. Hope it still can catch up with r0. Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
Bug#839894: Last chance for d-i changes in stretch
Hi, On Tue, 30 May 2017 21:52:06 +0900 Roger Shimizu wrote: > > -/dev/[hsv]d[a-z0-9]| > > +/dev/[hsv]d[a-z0-9][a-z]*| > > And I pushed the fix commit to branch "fix_839894": > > https://anonscm.debian.org/cgit/d-i/grub-installer.git/commit/?h=fix_839894&id=9927e8c I've tested it with VBox and works well, see attached screenshot. -- Regards, Hideki Yamane henrich @ debian.or.jp/org http://wiki.debian.org/HidekiYamane
Bug#839894: Last chance for d-i changes in stretch
On Tue, May 30, 2017 at 9:38 AM, Roger Shimizu wrote: > On Tue, May 30, 2017 at 4:27 AM, Samuel Thibault wrote: > >> That would also match partitions, might that not pose concerns? Now I think the following is better: > -/dev/[hsv]d[a-z0-9]| > +/dev/[hsv]d[a-z0-9][a-z]*| And I pushed the fix commit to branch "fix_839894": https://anonscm.debian.org/cgit/d-i/grub-installer.git/commit/?h=fix_839894&id=9927e8c Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
Bug#839894: Last chance for d-i changes in stretch
On Tue, May 30, 2017 at 4:27 AM, Samuel Thibault wrote: > That would also match partitions, might that not pose concerns? So maybe the following? > -/dev/[hsv]d[a-z0-9]| > +/dev/[hsv]d[a-z0-9]|/dev/[hsv]d[a-z][a-z]*| -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
Bug#839894: Last chance for d-i changes in stretch
Cyril Brulebois, on lun. 29 mai 2017 21:16:54 +0200, wrote: > And thanks for the ping on that topic. > > Roger Shimizu (2017-05-29): > > Maybe it's too late for r0, but I'm still want to ask whether it's feasible > > to include the patch mentioned here: > > https://bugs.debian.org/839894#30 > > > > henrich provided the patch and he verified it worked well in his virtualbox > > environment. > > I think we want to do this instead: > -/dev/[hsv]d[a-z0-9]| > +/dev/[hsv]d[a-z0-9][a-z0-9]*| That would also match partitions, might that not pose concerns? Samuel
Bug#839894: Last chance for d-i changes in stretch
Hi, And thanks for the ping on that topic. Roger Shimizu (2017-05-29): > Maybe it's too late for r0, but I'm still want to ask whether it's feasible > to include the patch mentioned here: > https://bugs.debian.org/839894#30 > > henrich provided the patch and he verified it worked well in his virtualbox > environment. I think we want to do this instead: -/dev/[hsv]d[a-z0-9]| +/dev/[hsv]d[a-z0-9][a-z0-9]*| since the proposed patch would allow hd,sd,vd by making the letter/number entirely optional, instead of mandatory once and optionally present a few other times? EIther way, this looks reasonable for r0, until we scratch this entirely in buster and rely on simpler code for this. KiBi. signature.asc Description: Digital signature
Bug#839894: Last chance for d-i changes in stretch
[ Only keep d-boot@ ML ] On Fri, 26 May 2017 19:04:13 +0200 Cyril Brulebois wrote: > Hi, > > You might have noticed final preparations for d-i Stretch RC 4 are > underways. A new debian-installer upload (or a binNMU) will need to > happen before the first stretch release (aka. r0). If there's anything > you want or would like to include in r0, now is the time to mention it. Thanks for your continous work on d-i! Maybe it's too late for r0, but I'm still want to ask whether it's feasible to include the patch mentioned here: https://bugs.debian.org/839894#30 henrich provided the patch and he verified it worked well in his virtualbox environment. If it's really too late for r0, how about stretch p-u or r1? And how? Thanks for your consideration! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1 pgpm3lOBLHRAc.pgp Description: PGP signature
