Bug#840140: fastx-toolkit: please make the build reproducible

[Sascha Steinbiss]

Hi Chris,

thanks for the report. I just took a look at the patch and now it seems that 
there are no man pages built for fasta_clipping_histogram.pl and 
fastx_barcode_splitter.pl at all any more, is that intentional?

Cheers
Sascha

On Sat, 08 Oct 2016 20:28:18 +0100 Chris Lamb  wrote:
> Source: fastx-toolkit
> Version: 0.0.14-1
> Severity: wishlist
> Tags: patch
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], we noticed
> that fastx-toolkit could not be built reproducibly.
> 
> Patch attached.
> 
> I ended up patching upstream sources instead of fixing/extending the
> regexes in debian/rules; the result is subjectively far cleaner and
> objectively less brittle.
> 
> 
>  [0] https://reproducible-builds.org/
> 
> 
> Regards,
> 
> -- 
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-

Bug#840140: fastx-toolkit: please make the build reproducible

[Chris Lamb]

Source: fastx-toolkit
Version: 0.0.14-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that fastx-toolkit could not be built reproducibly.

Patch attached.

I ended up patching upstream sources instead of fixing/extending the
regexes in debian/rules; the result is subjectively far cleaner and
objectively less brittle.


 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/reproducible_build.patch   1970-01-01 01:00:00.0 
+0100
--- b/debian/patches/reproducible_build.patch   2016-10-08 20:23:06.570045323 
+0100
@@ -0,0 +1,61 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2016-10-08
+
+--- fastx-toolkit-0.0.14.orig/scripts/fasta_clipping_histogram.pl
 fastx-toolkit-0.0.14/scripts/fasta_clipping_histogram.pl
+@@ -21,13 +21,16 @@ use warnings;
+ use GD::Graph::bars;
+ use Data::Dumper;
+ use PerlIO::gzip;
++use File::Basename;
+ 
+ if (scalar @ARGV==0) {
++  my $name = basename($0);
++
+   print< $(mandir)/fastx_uncollapser.1
-
-   # Perl scripts add the full path to usage advise which needs to be 
removed
-   # The script fasta_clipping_histogram.pl does not feature a '-h' option
-   help2man --no-info --no-discard-stderr --version-string='$(ver)' -h '' \
-  --name='Create a Linker Clipping Information Histogram' \
-  $(bindir)/fasta_clipping_histogram.pl | \
-  sed -e 's?^usage: .*\([^/]\+\.pl\)?usage: \1?' \
-  > $(mandir)/fasta_clipping_histogram.pl.1
-   help2man --no-info --no-discard-stderr --version-string='$(ver)' 
--help-option='-h' \
-  --name='FASTX Barcode Splitter' \
-  $(bindir)/fastx_barcode_splitter.pl | \
-  sed -e 's?^usage: .*\([^/]\+\.pl\)?usage: \1?' \
-  > $(mandir)/fastx_barcode_splitter.pl.1
-
help2man --no-info --no-discard-stderr --version-string='$(ver)' 
--help-option='-h' \
   --name='Solexa-Quality BoxPlot plotter' \
   $(bindir)/fastq_quality_boxplot_graph.sh > 
$(mandir)/fastq_quality_boxplot_graph.sh.1