Bug#841532: libgit2: FTBFS under some timezones (eg. GMT-14)

[Chris Lamb]

Hi Russell,

> I think that preventing random failures from Debian build infrastructure
> is the best I can do for the time being

Well, not if the upstream library code itself is broken wrt to the timezones
and its not just some peculiarity of the test. In fact, if the code is broken
then breaking in Debian is actually "correct", from a funny point of view.

Anyway, worth checking with upstream before patching over the issue within
Debian just in case they never respond and this (potentially) falls through
the gaps IMHO. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#841532: libgit2: FTBFS under some timezones (eg. GMT-14)

[Russell Sim]

Yeah, I totally agree it's an upstream bug, the bug exists in not only
this version but also the master branch so I can't backport a fix. 

I did have a quick look at the test code, and it's not obviously due to
that, so it must be related to how they store or retrieve the offset in
this case.

I'll leave this bug open until we have an actual fix. But I think that
preventing random failures from Debian build infrastructure is the best
I can do for the time being.

Thanks for adding the forwarded tag, I'm still learning and I forget
these things sometimes.

Chris Lamb  writes:

> forwarded 841532 https://github.com/libgit2/libgit2/issues/3970
> thanks
>
> Russell Sim wrote:
>
>> I have forwarded this bug report upstream
>> https://github.com/libgit2/libgit2/issues/3970 in the mean time I'll add
>> a fix to the existing package to force tests to run in GMT timezone.
>
> Be careful; it could mean that you are masking underlying bugs by forcing
> the timezone - the code (outside of the tests) itself could be buggy!
>
>
> Regards,

-- 
Cheers,
Russell

Bug#841532: libgit2: FTBFS under some timezones (eg. GMT-14)

[Chris Lamb]

forwarded 841532 https://github.com/libgit2/libgit2/issues/3970
thanks

Russell Sim wrote:

> I have forwarded this bug report upstream
> https://github.com/libgit2/libgit2/issues/3970 in the mean time I'll add
> a fix to the existing package to force tests to run in GMT timezone.

Be careful; it could mean that you are masking underlying bugs by forcing
the timezone - the code (outside of the tests) itself could be buggy!


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#841532: libgit2: FTBFS under some timezones (eg. GMT-14)

[Russell Sim]

Chris Lamb  writes:

Hi Chris,

Thanks for reporting this,

I have forwarded this bug report upstream
https://github.com/libgit2/libgit2/issues/3970 in the mean time I'll add
a fix to the existing package to force tests to run in GMT timezone.

> Source: libgit2
> Version: 0.24.1-2
> Severity: serious
> Justification: fails to build from source
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: ftbfs timezone
> X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
>
> Dear Maintainer,
>
> libgit2 fails to build from source in unstable/amd64 under 
> some timezones (eg. TZ="/usr/share/zoneinfo/Etc/GMT-14"):
>
>   […]
>   
> 1) Failure:
>   refs::reflog::reflog::append_then_read 
> [/home/lamby/temp/cdt.20161021132009.xEm9eCsvCE.ags.libgit2/libgit2-0.24.1/tests/refs/reflog/reflog.c:21]
> Expression is not true: expected->when.offset == actual->when.offset
> 
>   
>   50% tests passed, 1 tests failed out of 2
>   
>   Total Test time (real) =  16.30 sec
>   
>   The following tests FAILED:
> 1 - libgit2_clar (Failed)
>   Errors while running CTest
>
>   […]
>
> The full build log is attached.
>
>
> Regards,

-- 
Cheers,
Russell

Bug#841532: libgit2: FTBFS under some timezones (eg. GMT-14)

[Chris Lamb]

Source: libgit2
Version: 0.24.1-2
Severity: serious
Justification: fails to build from source
User: reproducible-bui...@lists.alioth.debian.org
Usertags: ftbfs timezone
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Dear Maintainer,

libgit2 fails to build from source in unstable/amd64 under 
some timezones (eg. TZ="/usr/share/zoneinfo/Etc/GMT-14"):

  […]
  
1) Failure:
  refs::reflog::reflog::append_then_read 
[/home/lamby/temp/cdt.20161021132009.xEm9eCsvCE.ags.libgit2/libgit2-0.24.1/tests/refs/reflog/reflog.c:21]
Expression is not true: expected->when.offset == actual->when.offset

  
  50% tests passed, 1 tests failed out of 2
  
  Total Test time (real) =  16.30 sec
  
  The following tests FAILED:
  1 - libgit2_clar (Failed)
  Errors while running CTest

  […]

The full build log is attached.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-


libgit2.0.24.1-2.unstable.amd64.log.txt.gz
Description: Binary data