Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jens Sauer]

Am Sonntag, den 20.11.2016, 15:49 + schrieb Jonathan Wiltshire:
> Please go ahead. When the upload reaches proposed-updates, I'd
> appreciate if you can repeat your KVM tests as a double-check.
> 

The upload is now available in proposed-updates and I ran the tests again.
Everything works fine, package seems to work.

Thanks to everyone for their work!

Regards,
-- 
Jens Sauer 

GPG Key: 5C0B0084
Fingerprint: 75F3 6232 1F69 82E8 F5E0 D151 850E 2908 5C0B 0084

signature.asc
Description: This is a digitally signed message part

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Adam D. Barratt]

Control: tags 843775 + pending

On Tue, 2016-11-22 at 12:43 +0100, Cyril Brulebois wrote:
> (dropping debian-boot@, adding 845311@)
> 
> Hi Jens,
> 
> Jens Sauer  (2016-11-22):
> > Thank you for reviewing this package. It was my first time doing this,
> > I hope everything is alright.
> 
> It looks to me everything was right on the first attempt. :)
> 
> > I opened a RFS to find a sponsor for the upload:
> > https://bugs.debian.org/845311
> 
> According to my inbox it's possible to perform source-only uploads for
> jessie-proposed-updates (at least it worked for src:debian-installer),
> so I've just sponsored your package this way. Please close the RFS if it
> gets queued as expected; otherwise I'll re-sponsor the package with a
> binary build included.

Flagged for acceptance into p-u.

Regards,

Adam

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Adam D. Barratt]

On 2016-11-22 16:42, Jens Sauer wrote:

(dropping 845311@)


According to my inbox it's possible to perform source-only uploads for
jessie-proposed-updates (at least it worked for src:debian-installer),
so I've just sponsored your package this way. Please close the RFS if 
it

gets queued as expected; otherwise I'll re-sponsor the package with a
binary build included.


Is it correct, that
https://release.debian.org/proposed-updates/stable.html lists "source"
as the only architecture for mdadm?


While it's still in the "Resolution Pending" section, yes.


Or am I just too impatient?


Yes. :-)

The upload has to be reviewed and flagged for acceptance by a member of 
the Release Team. After that the archive software will move the package 
to proposed-updates and it will start to get built for other 
architectures.


Regards,

Adam

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jens Sauer]

(dropping 845311@)

> According to my inbox it's possible to perform source-only uploads for
> jessie-proposed-updates (at least it worked for src:debian-installer),
> so I've just sponsored your package this way. Please close the RFS if it
> gets queued as expected; otherwise I'll re-sponsor the package with a
> binary build included.

Is it correct, that https://release.debian.org/proposed-updates/stable.html 
lists "source" as the
only architecture for mdadm?
Or am I just too impatient?

Regards,
-- 
Jens Sauer 

GPG Key: 5C0B0084
Fingerprint: 75F3 6232 1F69 82E8 F5E0 D151 850E 2908 5C0B 0084

signature.asc
Description: This is a digitally signed message part

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Cyril Brulebois]

(dropping debian-boot@, adding 845311@)

Hi Jens,

Jens Sauer  (2016-11-22):
> Thank you for reviewing this package. It was my first time doing this,
> I hope everything is alright.

It looks to me everything was right on the first attempt. :)

> I opened a RFS to find a sponsor for the upload:
> https://bugs.debian.org/845311

According to my inbox it's possible to perform source-only uploads for
jessie-proposed-updates (at least it worked for src:debian-installer),
so I've just sponsored your package this way. Please close the RFS if it
gets queued as expected; otherwise I'll re-sponsor the package with a
binary build included.


KiBi.


signature.asc
Description: Digital signature

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jens Sauer]

Am Sonntag, den 20.11.2016, 19:27 +0100 schrieb Cyril Brulebois:
> Control: tag -1 + confirmed - moreinfo
> 
> Jonathan Wiltshire  (2016-11-20):
> > On Wed, Nov 09, 2016 at 01:52:25PM +0100, Jens Sauer wrote:
> > > I prepared a package for mdadm to fix bug #840743
> > > (https://bugs.debian.org/840743) which prevents a correct reshape
> > > when only one 'spare' device and no backup-file is used. This can
> > > result in a nonfunctional array.
> > 
> > Twitched too soon; mdadm has a udeb, so it needs a d-i ack first. Sorry,
> > please wait.
> 
> I don't think d-i is hitting a “grow” / “-G” codepath, and a quick grep
> seems to confirm that. So it looks to me a patch touching Grow.c should
> have no consequences on d-i (famous last words).
> 
> => Please go ahead.
> 
> 
> KiBi.

Hey,

Thank you for reviewing this package. It was my first time doing this, I hope 
everything is alright.

I opened a RFS to find a sponsor for the upload: https://bugs.debian.org/845311

Regards
-- 
Jens Sauer 

GPG Key: 5C0B0084
Fingerprint: 75F3 6232 1F69 82E8 F5E0 D151 850E 2908 5C0B 0084

signature.asc
Description: This is a digitally signed message part

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Cyril Brulebois]

Control: tag -1 + confirmed - moreinfo

Jonathan Wiltshire  (2016-11-20):
> On Wed, Nov 09, 2016 at 01:52:25PM +0100, Jens Sauer wrote:
> > I prepared a package for mdadm to fix bug #840743
> > (https://bugs.debian.org/840743) which prevents a correct reshape
> > when only one 'spare' device and no backup-file is used. This can
> > result in a nonfunctional array.
> 
> Twitched too soon; mdadm has a udeb, so it needs a d-i ack first. Sorry,
> please wait.

I don't think d-i is hitting a “grow” / “-G” codepath, and a quick grep
seems to confirm that. So it looks to me a patch touching Grow.c should
have no consequences on d-i (famous last words).

=> Please go ahead.


KiBi.


signature.asc
Description: Digital signature

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jonathan Wiltshire]

Control: tag -1 - confirmed + moreinfo

On Wed, Nov 09, 2016 at 01:52:25PM +0100, Jens Sauer wrote:
> I prepared a package for mdadm to fix bug #840743
> (https://bugs.debian.org/840743) which prevents a correct reshape when only 
> one
> 'spare' device and no backup-file is used.
> This can result in a nonfunctional array.

Twitched too soon; mdadm has a udeb, so it needs a d-i ack first. Sorry,
please wait.


-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jonathan Wiltshire]

Control: tag -1 + confirmed

On Wed, Nov 09, 2016 at 01:52:25PM +0100, Jens Sauer wrote:
> I prepared a package for mdadm to fix bug #840743
> (https://bugs.debian.org/840743) which prevents a correct reshape when only 
> one
> 'spare' device and no backup-file is used.
> This can result in a nonfunctional array.

Please go ahead. When the upload reaches proposed-updates, I'd
appreciate if you can repeat your KVM tests as a double-check.

Thanks,

-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Bug#843775: jessie-pu: package mdadm/3.3.2-5+deb8u2

[Jens Sauer]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

I prepared a package for mdadm to fix bug #840743
(https://bugs.debian.org/840743) which prevents a correct reshape when only one
'spare' device and no backup-file is used.
This can result in a nonfunctional array.

The upstream package 3.3.3 includes the commit from Neil Brown in which this
behavior is fixed.
http://git.neil.brown.name/?p=mdadm.git;a=commit;h=8e7ddc5f50af00e569ef115e25c635e2d74e90f0

I cherry-picked this commit for the stable version.

Unfortunately the package maintainer (CC of this mail) did not responded to
this bug report yet. I
(Opened 14 Oct 2016).

The source package can be found at
https://mentors.debian.net/debian/pool/main/m/mdadm/mdadm_3.3.2-5+deb8u2.dsc

diff -Nru mdadm-3.3.2/debian/changelog mdadm-3.3.2/debian/changelog
--- mdadm-3.3.2/debian/changelog2015-12-28 15:55:05.0 +0100
+++ mdadm-3.3.2/debian/changelog2016-11-09 00:43:48.0 +0100
@@ -1,3 +1,12 @@
+mdadm (3.3.2-5+deb8u2) jessie; urgency=medium
+
+  * Non-maintainer upload.
+  * fix-grow-continue.patch: Port upstream fix to let '--grow --continue'
+successfully reshape an array when using backup space on a 'spare' device.
+(Closes: #840743)
+
+ -- Jens Sauer   Wed, 09 Nov 2016 00:43:48 +0100
+
 mdadm (3.3.2-5+deb8u1) jessie; urgency=medium

   * Non-maintainer upload.
diff -Nru mdadm-3.3.2/debian/patches/fix-grow-continue.patch
mdadm-3.3.2/debian/patches/fix-grow-continue.patch
--- mdadm-3.3.2/debian/patches/fix-grow-continue.patch  1970-01-01
01:00:00.0 +0100
+++ mdadm-3.3.2/debian/patches/fix-grow-continue.patch  2016-11-09
00:43:48.0 +0100
@@ -0,0 +1,35 @@
+Subject: Fix '--grow --continue' when using backup space on a 'spare' device
+Origin: upstream,
http://git.neil.brown.name/?p=mdadm.git;a=commit;h=8e7ddc5f50af00e569ef115e25c635e2d74e90f0
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840743
+Author: Neil Brown 
+
+--- mdadm-3.3.2.orig/Grow.c
 mdadm-3.3.2/Grow.c
+@@ -853,7 +853,8 @@ int reshape_prepare_fdlist(char *devname
+   for (sd = sra->devs; sd; sd = sd->next) {
+   if (sd->disk.state & (1<disk.state & (1<disk.state & (1<disk.raid_disk < raid_disks) {
+   char *dn = map_dev(sd->disk.major,
+  sd->disk.minor, 1);
+   fdlist[sd->disk.raid_disk]
+@@ -3216,7 +3217,7 @@ started:
+   d = reshape_prepare_fdlist(devname, sra, odisks,
+  nrdisks, blocks, backup_file,
+  fdlist, offsets);
+-  if (d < 0) {
++  if (d < odisks) {
+   goto release;
+   }
+   if ((st->ss->manage_reshape == NULL) ||
+@@ -3228,7 +3229,7 @@ started:
+  devname);
+   pr_err(" Please provide one with \"--
backup=...\"\n");
+   goto release;
+-  } else if (sra->array.spare_disks == 0) {
++  } else if (d == odisks) {
+   pr_err("%s: Cannot grow - "
+   "need a spare or backup-file to backup
"
+   "critical section\n", devname);
diff -Nru mdadm-3.3.2/debian/patches/series mdadm-3.3.2/debian/patches/series
--- mdadm-3.3.2/debian/patches/series   2015-11-10 11:13:53.0 +0100
+++ mdadm-3.3.2/debian/patches/series   2016-11-09 00:43:48.0 +0100
@@ -8,3 +8,4 @@
 readlink-path.patch
 mdmonitor-service-simplify.diff
 disable-incremental-assembly.patch
+fix-grow-continue.patch