subject:"Bug#843824\: kdenlive\: Screen Grab has hard coded display setting"

Bug#843824: kdenlive: Screen Grab has hard coded display setting

2017-01-27 Thread Jean-Baptiste Mardelle


On Tuesday, January 24, 2017 9:41:23 AM CET, Patrick Matthäi wrote:

Hello JB,

I think this issue is still up to date with 16.12.1, since from
kdenlive-16.12.1/src/monitor/recmonitor.cpp:


Thanks for your message. I just tested and the issue has been fixed, 
probably in 16.12.0 or even 16.08.x.


The code in recmonitor.cpp is not used anymore, it is kept as archive but 
should be removed. The screengrab feature now displays a combobox allowing 
to select the monitor. Relevant code is in src/monitor/recmanager.cpp, line 
65 to 75.


Best regards
Jean-Baptiste Mardelle




 710 if (!KdenliveSettings::grab_hide_frame()) m_captureArgs <<
QStringLiteral("-show_region") << QStringLiteral("1");
 711 captureSize = QStringLiteral(":0.0");
 712 if (KdenliveSettings::grab_capture_type() == 0) {
 713 // Full screen capture

Could you apply the patch please?


Am 09.11.2016 um 23:33 schrieb Daniel Keast:

Package: kdenlive
Version: 0.9.10-2
Severity: normal

Dear Maintainer,

The screen grab feature has the DISPLAY location hard coded. 
When I attempt to ...

Bug#843824: kdenlive: Screen Grab has hard coded display setting

2017-01-24 Thread Patrick Matthäi

Hello JB,

I think this issue is still up to date with 16.12.1, since from
kdenlive-16.12.1/src/monitor/recmonitor.cpp:

 710 if (!KdenliveSettings::grab_hide_frame()) m_captureArgs <<
QStringLiteral("-show_region") << QStringLiteral("1");
 711 captureSize = QStringLiteral(":0.0");
 712 if (KdenliveSettings::grab_capture_type() == 0) {
 713 // Full screen capture

Could you apply the patch please?


Am 09.11.2016 um 23:33 schrieb Daniel Keast:
> Package: kdenlive
> Version: 0.9.10-2
> Severity: normal
>
> Dear Maintainer,
>
> The screen grab feature has the DISPLAY location hard coded. When I attempt to
> record my desktop I get a notification with the message "x11grab Could not 
> open
> X display. :0.0: Input/output error".
>
> This patch fixes the issue for me:
>
> diff --git a/kdenlive-0.9.10/src/monitor/recmonitor.cpp 
> b/kdenlive-0.9.10/src/monitor/recmonitor.cpp
> index f465d82..57b5536 100644
> --- a/kdenlive-0.9.10/src/monitor/recmonitor.cpp
> +++ b/kdenlive-0.9.10/src/monitor/recmonitor.cpp
> @@ -29,6 +29,8 @@
>  #include "videosurface.h"
>  #include 
>  
> +#include 
> +
>  #include 
>  #include 
>  #include 
> @@ -731,7 +733,8 @@ void RecMonitor::slotRecord()
> m_captureArgs << "-f" << "x11grab";
> if (KdenliveSettings::grab_follow_mouse()) m_captureArgs << 
> "-follow_mouse" << "centered";
> if (!KdenliveSettings::grab_hide_frame()) m_captureArgs << 
> "-show_region" << "1";
> -   captureSize = ":0.0";
> +   captureSize = std::genenv("DISPLAY");
> +   if (captureSize == NULL) captureSize = ":0.0";
>  if (KdenliveSettings::grab_capture_type() == 0) {
>  // Full screen capture
> m_captureArgs << "-s" << QString::number(screenSize.width()) 
> + 'x' + QString::number(screenSize.height());
>
>
> -- System Information:
> Debian Release: 8.6
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages kdenlive depends on:
> ii  kde-runtime   4:4.14.2-2
> ii  kdenlive-data 0.9.10-2
> ii  libav-tools   6:11.8-1~deb8u1
> ii  libc6 2.19-18+deb8u6
> ii  libgcc1   1:4.9.2-10
> ii  libgl1-mesa-glx [libgl1]  10.3.2-1+deb8u1
> ii  libglu1-mesa [libglu1]9.0.0-2
> ii  libkdecore5   4:4.14.2-5+deb8u1
> ii  libkdeui5 4:4.14.2-5+deb8u1
> ii  libkio5   4:4.14.2-5+deb8u1
> ii  libknewstuff3-4   4:4.14.2-5+deb8u1
> ii  libknotifyconfig4 4:4.14.2-5+deb8u1
> ii  libkrossui4   4:4.14.2-5+deb8u1
> ii  libmlt++3 0.9.2-2
> ii  libmlt6   0.9.2-2
> ii  libnepomuk4   4:4.14.2-5+deb8u1
> ii  libqjson0 0.8.1-3
> ii  libqt4-dbus   4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqt4-network4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqt4-opengl 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqt4-svg4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqt4-xml4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqtcore44:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
> ii  libsolid4 4:4.14.2-5+deb8u1
> ii  libsoprano4   2.9.4+dfsg-1.1
> ii  libstdc++64.9.2-10
> ii  libv4l-0  1.6.0-2
> ii  libx11-6  2:1.6.2-3
> ii  libxau6   1:1.0.8-1
> ii  libxdmcp6 1:1.1.1-1+b1
> ii  libxext6  2:1.3.3-1
> ii  melt  0.9.2-2
>
> Versions of packages kdenlive recommends:
> ii  dvdauthor0.7.0-1.3
> ii  dvgrab   3.5-2+b2
> ii  frei0r-plugins   1.4-3
> ii  genisoimage  9:1.1.11-3
> ii  recordmydesktop  0.3.8.1+svn602-1+b1
> ii  swh-plugins  0.4.15+1-7
>
> Versions of packages kdenlive suggests:
> pn  khelpcenter4  
>
> -- no debconf information

-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

  Blog: http://www.linux-dev.org/
E-Mail: pmatth...@debian.org
patr...@linux-dev.org
*/

Bug#843824: kdenlive: Screen Grab has hard coded display setting

2016-11-09 Thread Daniel Keast

Package: kdenlive
Version: 0.9.10-2
Severity: normal

Dear Maintainer,

The screen grab feature has the DISPLAY location hard coded. When I attempt to
record my desktop I get a notification with the message "x11grab Could not open
X display. :0.0: Input/output error".

This patch fixes the issue for me:

diff --git a/kdenlive-0.9.10/src/monitor/recmonitor.cpp 
b/kdenlive-0.9.10/src/monitor/recmonitor.cpp
index f465d82..57b5536 100644
--- a/kdenlive-0.9.10/src/monitor/recmonitor.cpp
+++ b/kdenlive-0.9.10/src/monitor/recmonitor.cpp
@@ -29,6 +29,8 @@
 #include "videosurface.h"
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -731,7 +733,8 @@ void RecMonitor::slotRecord()
m_captureArgs << "-f" << "x11grab";
if (KdenliveSettings::grab_follow_mouse()) m_captureArgs << 
"-follow_mouse" << "centered";
if (!KdenliveSettings::grab_hide_frame()) m_captureArgs << 
"-show_region" << "1";
-   captureSize = ":0.0";
+   captureSize = std::genenv("DISPLAY");
+   if (captureSize == NULL) captureSize = ":0.0";
 if (KdenliveSettings::grab_capture_type() == 0) {
 // Full screen capture
m_captureArgs << "-s" << QString::number(screenSize.width()) + 
'x' + QString::number(screenSize.height());


-- System Information:
Debian Release: 8.6
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages kdenlive depends on:
ii  kde-runtime   4:4.14.2-2
ii  kdenlive-data 0.9.10-2
ii  libav-tools   6:11.8-1~deb8u1
ii  libc6 2.19-18+deb8u6
ii  libgcc1   1:4.9.2-10
ii  libgl1-mesa-glx [libgl1]  10.3.2-1+deb8u1
ii  libglu1-mesa [libglu1]9.0.0-2
ii  libkdecore5   4:4.14.2-5+deb8u1
ii  libkdeui5 4:4.14.2-5+deb8u1
ii  libkio5   4:4.14.2-5+deb8u1
ii  libknewstuff3-4   4:4.14.2-5+deb8u1
ii  libknotifyconfig4 4:4.14.2-5+deb8u1
ii  libkrossui4   4:4.14.2-5+deb8u1
ii  libmlt++3 0.9.2-2
ii  libmlt6   0.9.2-2
ii  libnepomuk4   4:4.14.2-5+deb8u1
ii  libqjson0 0.8.1-3
ii  libqt4-dbus   4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqt4-network4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqt4-opengl 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqt4-svg4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqt4-xml4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqtcore44:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-3+deb8u1
ii  libsolid4 4:4.14.2-5+deb8u1
ii  libsoprano4   2.9.4+dfsg-1.1
ii  libstdc++64.9.2-10
ii  libv4l-0  1.6.0-2
ii  libx11-6  2:1.6.2-3
ii  libxau6   1:1.0.8-1
ii  libxdmcp6 1:1.1.1-1+b1
ii  libxext6  2:1.3.3-1
ii  melt  0.9.2-2

Versions of packages kdenlive recommends:
ii  dvdauthor0.7.0-1.3
ii  dvgrab   3.5-2+b2
ii  frei0r-plugins   1.4-3
ii  genisoimage  9:1.1.11-3
ii  recordmydesktop  0.3.8.1+svn602-1+b1
ii  swh-plugins  0.4.15+1-7

Versions of packages kdenlive suggests:
pn  khelpcenter4  

-- no debconf information

Bug#843824: kdenlive: Screen Grab has hard coded display setting

Bug#843824: kdenlive: Screen Grab has hard coded display setting

Bug#843824: kdenlive: Screen Grab has hard coded display setting

3 matches

Site Navigation

Mail list logo

Footer information