Bug#845346: qupzilla: QupZilla is built without kwallet support

[Tityron]

I believe the hard dependency on KDE is a big mistake and even goes 
against the wish of the author.  Even as QupZilla/Falkon is becoming a 
KDE project, it is mentioned explicitly that "there will be no hard 
dependencies on KDE libraries" 
(http://blog.qupzilla.com/2017/08/qupzilla-is-moving-under-kde-and.html). 
 QupZilla is meant to be as lightweight as possible and pulling all 
those KDE dependencies is just awful.


The solution would be to create separate packages for plugins.  KWallet 
support would be activated by installing qupzilla-plugin-kwallet.

Bug#845346: qupzilla: QupZilla is built without kwallet support

[Brendon Higgins]

Hi,

This was bugging me as well, so I made some changes to the Debian package 
source, and the KWallet plugin seems to be working for me now with KDE 5's 
KWallet. Patch attached. Hope it's helpful.

Peace,
Brendon
diff -Naur qupzilla-2.0.2~dfsg1.orig/debian/control qupzilla-2.0.2~dfsg1/debian/control
--- qupzilla-2.0.2~dfsg1.orig/debian/control	2017-01-11 12:43:00.0 -0500
+++ qupzilla-2.0.2~dfsg1/debian/control	2017-04-14 16:50:37.093046718 -0400
@@ -9,7 +9,7 @@
  qtbase5-private-dev, qtscript5-dev,
  libqt5x11extras5-dev,
  libx11-dev,
- libssl1.0-dev, kdelibs5-dev, libgnome-keyring-dev,
+ libssl1.0-dev, libkf5wallet-dev, libgnome-keyring-dev,
  libjs-jquery, libjs-jquery-ui
 Standards-Version: 3.9.8
 Homepage: http://www.qupzilla.com/
diff -Naur qupzilla-2.0.2~dfsg1.orig/debian/patches/kde-integration.patch qupzilla-2.0.2~dfsg1/debian/patches/kde-integration.patch
--- qupzilla-2.0.2~dfsg1.orig/debian/patches/kde-integration.patch	1969-12-31 19:00:00.0 -0500
+++ qupzilla-2.0.2~dfsg1/debian/patches/kde-integration.patch	2017-04-14 16:54:05.972901755 -0400
@@ -0,0 +1,17 @@
+Index: qupzilla-2.0.2~dfsg1/src/plugins/plugins.pro
+===
+--- qupzilla-2.0.2~dfsg1.orig/src/plugins/plugins.pro
 qupzilla-2.0.2~dfsg1/src/plugins/plugins.pro
+@@ -32,9 +32,10 @@ outOfDirPlugins = $$(QUPZILLA_PLUGINS_SR
+ # TestPlugin only in debug build
+ !CONFIG(debug, debug|release): disablePlugin(TestPlugin)
+ 
++## enforced KDE_INTEGRATION
+ # KWalletPasswords only with KDE_INTEGRATION and KWallet framework
+-!contains(DEFINES, KDE_INTEGRATION): disablePlugin(KWalletPasswords)
+-!qtHaveModule(KWallet): disablePlugin(KWalletPasswords)
++# !contains(DEFINES, KDE_INTEGRATION): disablePlugin(KWalletPasswords)
++# !qtHaveModule(KWallet): disablePlugin(KWalletPasswords)
+ 
+ ## enforced GNOME_INTEGRATION
+ # GnomeKeyringPasswords only with GNOME_INTEGRATION and gnome-keyring pkg-config
diff -Naur qupzilla-2.0.2~dfsg1.orig/debian/patches/series qupzilla-2.0.2~dfsg1/debian/patches/series
--- qupzilla-2.0.2~dfsg1.orig/debian/patches/series	2015-04-16 17:20:39.0 -0400
+++ qupzilla-2.0.2~dfsg1/debian/patches/series	2017-04-14 16:52:23.148972777 -0400
@@ -1,2 +1,3 @@
 hardening.patch
 gnome-integration.patch
+kde-integration.patch

Bug#845346: qupzilla: QupZilla is built without kwallet support

[HJ]

Package: qupzilla
Version: 1.8.9~dfsg1-3
Severity: normal

Since QupZilla is the only modern Qt-based webbrowser it should be built with
Kwallet
support(https://github.com/QupZilla/qupzilla/tree/master/src/plugins/KWalletPasswords)



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages qupzilla depends on:
ii  libc6 2.24-6
ii  libgcc1   1:6.2.1-4
ii  libgl1-mesa-glx [libgl1]  12.0.4-2
ii  libqt5core5a  5.7.1~20161021+dfsg-6
ii  libqt5dbus5   5.7.1~20161021+dfsg-6
ii  libqt5gui55.7.1~20161021+dfsg-6
ii  libqt5network55.7.1~20161021+dfsg-6
ii  libqt5printsupport5   5.7.1~20161021+dfsg-6
ii  libqt5script5 5.7.1~20161021+dfsg-2
ii  libqt5sql55.7.1~20161021+dfsg-6
ii  libqt5sql5-sqlite 5.7.1~20161021+dfsg-6
ii  libqt5webkit5 5.7.1~20161021+dfsg-2
ii  libqt5widgets55.7.1~20161021+dfsg-6
ii  libqupzilla1  1.8.9~dfsg1-3
ii  libstdc++66.2.1-4

qupzilla recommends no packages.

qupzilla suggests no packages.

-- no debconf information