Bug#847168: devscripts: debuild fails when lintian fails, regression since 2.16.9
On Tue, 06 Dec 2016, James McCoy wrote: > > When I work on Kali packages, I almost always get a lintian error because > > lintian doesn't know of the suite > > Can't that particular issue be fixed with vendor information provided > for lintian? That's already done for Ubuntu. Probably. But this will not work when I build a Kali source package on my Debian system. It will only help when I build in a Kali chroot, no? > > I want to be informed of the errors but I don't > > want the whole build process to be stopped... I want "gbp buildpackage" to > > create my tag and I want debuild to sign my package. > > While I understand that the change is unexpected, wouldn't it be better > to resolve the errors "globally" rather than just for your dev > environment? Certainly but I also fear it will encourage people to add undue overrides just so that the build does not fail. > > If you consider this a regression, then the default check hook should have > > some "|| true" added at the end or something like that (or you can also > > add a new option to ignore the result and have its default to true instead > > of false). > > I can't do any of the above without pulling the execution of lintian > back into debuild. The actual command-line being run isn't in debuild's > control (to the extent that we could do an equivalent of "|| true") and > all debuild knows is that dpkg-buildpackage failed. It has no idea that > it was due to the check command (lintian). Well, you pass --check-command=lintian and you pass the check-options too. While I now see that you can't pass "|| true" at the end of the command, you can pass a "--no-fail" option to lintian if lintian had such an option (it currently does not have anything like that though). So I guess we would have to open a bug against lintian and block this one by the lintian bug. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#847168: devscripts: debuild fails when lintian fails, regression since 2.16.9
On Tue, Dec 06, 2016 at 09:16:33AM +0100, Raphaël Hertzog wrote: > Since debuild now relies on dpkg-buildpackage's hook to run lintian, > a failing lintian fails the whole build process. This was not the case > before 2.16.9. So this is either a regression or a annoying new feature. It was an unforeseen change, but one that I think is an improvement (as noted in #846192). > When I work on Kali packages, I almost always get a lintian error because > lintian doesn't know of the suite Can't that particular issue be fixed with vendor information provided for lintian? That's already done for Ubuntu. > or because my name does not appear in > the maintainer field. This can also be disabled in general for Kali, if that's the expected behavior. > I want to be informed of the errors but I don't > want the whole build process to be stopped... I want "gbp buildpackage" to > create my tag and I want debuild to sign my package. While I understand that the change is unexpected, wouldn't it be better to resolve the errors "globally" rather than just for your dev environment? > If you consider this a new feature, then I ask you to document how to > configure debuild to not fail on lintian failures (possibly adding a new > option to ignore the result of the check-command). > > If you consider this a regression, then the default check hook should have > some "|| true" added at the end or something like that (or you can also > add a new option to ignore the result and have its default to true instead > of false). I can't do any of the above without pulling the execution of lintian back into debuild. The actual command-line being run isn't in debuild's control (to the extent that we could do an equivalent of "|| true") and all debuild knows is that dpkg-buildpackage failed. It has no idea that it was due to the check command (lintian). Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Bug#847168: devscripts: debuild fails when lintian fails, regression since 2.16.9
Package: devscripts Version: 2.16.11 Severity: important Since debuild now relies on dpkg-buildpackage's hook to run lintian, a failing lintian fails the whole build process. This was not the case before 2.16.9. So this is either a regression or a annoying new feature. When I work on Kali packages, I almost always get a lintian error because lintian doesn't know of the suite or because my name does not appear in the maintainer field. I want to be informed of the errors but I don't want the whole build process to be stopped... I want "gbp buildpackage" to create my tag and I want debuild to sign my package. If you consider this a new feature, then I ask you to document how to configure debuild to not fail on lintian failures (possibly adding a new option to ignore the result of the check-command). If you consider this a regression, then the default check hook should have some "|| true" added at the end or something like that (or you can also add a new option to ignore the result and have its default to true instead of false). Thank you! -- Package-specific info: --- /etc/devscripts.conf --- --- ~/.devscripts --- DEBRELEASE_UPLOADER=dput DEBRELEASE_DEBS_DIR=../build-area DEBCHANGE_RELEASE_HEURISTIC=changelog DEBCHANGE_MULTIMAINT_MERGE=yes DEBCHANGE_PRESERVE=yes DEBUILD_LINTIAN_OPTS="--color always -I" DEBSIGN_KEYID=0xF2AC729A DEBSIGN_PROGRAM=gpg2 DEBCHANGE_AUTO_NMU=no -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages devscripts depends on: ii dpkg-dev 1.18.15 ii libc62.24-8 ii perl 5.24.1~rc4-1 pn python3:any Versions of packages devscripts recommends: ii apt 1.4~beta1 ii at 3.1.20-1 ii curl7.51.0-1 ii dctrl-tools 2.24-2 ii debian-keyring 2016.09.04 ii dput0.11.0 ii equivs 2.0.9+nmu1 ii fakeroot1.21-3 ii file1:5.29-1 ii gnupg 2.1.16-2 ii gnupg2 2.1.16-2 ii libdistro-info-perl 0.14 ii libencode-locale-perl 1.05-1 ii liblwp-protocol-https-perl 6.06-2 ii libsoap-lite-perl 1.20-1 ii liburi-perl 1.71-1 ii libwww-perl 6.15-1 ii licensecheck3.0.28-1 ii lintian 2.5.49 ii man-db 2.7.5-2 ii patch 2.7.5-1 ii patchutils 0.3.4-2 ii python3-debian 0.1.29 ii python3-magic 1:5.29-1 ii sensible-utils 0.0.9 ii strace 4.13-0.1 ii unzip 6.0-20 ii wdiff 1.2.2-1+b1 ii wget1.18-4 ii xz-utils5.2.2-1.2 Versions of packages devscripts suggests: ii adequate 0.15.1 ii autopkgtest 4.2.2 pn bls-standalone pn bsd-mailx | mailx ii build-essential 12.2 pn check-all-the-things pn cvs-buildpackage pn devscripts-el pn diffoscope pn disorderfs pn dose-extra pn duck pn faketime pn gnuplot ii gpgv 2.1.16-2 pn how-can-i-help ii libauthen-sasl-perl 2.1600-1 ii libfile-desktopentry-perl0.22-1 pn libnet-smtps-perl pn libterm-size-perl ii libtimedate-perl 2.3000-2 pn libyaml-syck-perl pn mozilla-devscripts ii mutt 1.7.1-5 ii openssh-client [ssh-client] 1:7.3p1-5 ii piuparts 0.72 pn ratt pn reprotest ii svn-buildpackage 0.8.6 ii w3m 0.5.3-33 -- no debconf information
