Bug#847603: RFS: mod_pagespeed/1.11.33.4 [ITP] -- Apache module for rewriting web pages to reduce latency and bandwidth

[Sean Whitton]

control: tag -1 +moreinfo

Dear Jeff,

On Fri, Dec 09, 2016 at 02:43:32PM -0500, Jeff Kaufman wrote:
> I am looking for a sponsor for my package "mod_pagespeed":

This looks cool.  Here are some initial comments:

- I'm not prepared to fully review a package that is not available in
  git.  We might need multiple rounds of review, and git-diff(1) is
  invaluable for that.  Please consider `gbp import-dsc` or `dgit
  import-dsc` (the former is more popular; I prefer the latter)

- Your Vcs-* headers point to the upstream repository, which does not
  contain a debian/ directory.  Vcs-* headers are meant to point at a
  packaging repository.  Do you have one available somewhere?

- You have a very long list of quilt patches.  Have you considered
  merging some of them?  For example, all the -native patches could be a
  single patch.  Quilt patches can be a pain to manage when there are
  new upstream releases.

- I note that you have '#ifdef USE_SYSTEM_FOO' but your patch just
  strips off the whole conditional.  Wouldn't it be easier to use those
  USE_SYSTEM_* flags, instead of patching?

- generate.sh runs a copy of gyp in the source tree.  But gyp is
  packaged for Debian.  Please add a build-dependency on the packaged
  gyp, and run that instead (you might need another patch...)

- The package doesn't build in a clean sid chroot.  Log attached.

-- 
Sean Whitton
sbuild (Debian sbuild) 0.72.0 (25 Oct 2016) on zephyr.silentflame.com

+==+
| modpagespeed 1.11.33.4-1 (i386)  Fri, 30 Dec 2016 07:41:56 + |
+==+

Package: modpagespeed
Version: 1.11.33.4-1
Source Version: 1.11.33.4-1
Distribution: unstable
Machine Architecture: i386
Host Architecture: i386
Build Architecture: i386

I: NOTICE: Log filtering will replace 
'var/run/schroot/mount/unstable-i386-sbuild-dcccd87b-c0a4-4d7a-9cae-4908ef6a595f'
 with '<>'

+--+
| Update chroot|
+--+

Hit:1 http://mirror.vorboss.net/debian unstable InRelease
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
Calculating upgrade...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

+--+
| Fetch source files   |
+--+


Local sources
-

/home/swhitton/rfs/modpagespeed_1.11.33.4-1.dsc exists in /home/swhitton/rfs; 
copying to chroot
I: NOTICE: Log filtering will replace 
'build/modpagespeed-vvyuTA/modpagespeed-1.11.33.4' with '<>'
I: NOTICE: Log filtering will replace 'build/modpagespeed-vvyuTA' with 
'<>'

+--+
| Install build-essential  |
+--+


Setup apt archive
-

Merged Build-Depends: build-essential, fakeroot
Filtered Build-Depends: build-essential, fakeroot
dpkg-deb: building package 'sbuild-build-depends-core-dummy' in 
'/<>/resolver-d63B9K/apt_archive/sbuild-build-depends-core-dummy.deb'.
dpkg-scanpackages: warning: Packages in archive but missing from override file:
dpkg-scanpackages: warning:   sbuild-build-depends-core-dummy
dpkg-scanpackages: info: Wrote 1 entries to output Packages file.
Ign:1 copy:/<>/resolver-d63B9K/apt_archive ./ InRelease
Get:2 copy:/<>/resolver-d63B9K/apt_archive ./ Release [957 B]
Ign:3 copy:/<>/resolver-d63B9K/apt_archive ./ Release.gpg
Get:4 copy:/<>/resolver-d63B9K/apt_archive ./ Sources [349 B]
Get:5 copy:/<>/resolver-d63B9K/apt_archive ./ Packages [430 B]
Fetched 1736 B in 0s (0 B/s)
Reading package lists...
Reading package lists...

Install core build dependencies (apt-based resolver)


Installing build dependencies
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
  sbuild-build-depends-core-dummy
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 786 B of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 copy:/<>/resolver-d63B9K/apt_archive ./ 
sbuild-build-depends-core-dummy 0.invalid.0 [786 B]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 786 B in 0s (0 B/s)
Selecting previously unselected package sbuild-build-depends-core-dummy.
(Reading database ... 11483 files and directories currently installed.)
Preparing to unpack 

Bug#847603: RFS: mod_pagespeed/1.11.33.4 [ITP] -- Apache module for rewriting web pages to reduce latency and bandwidth

[Jeff Kaufman]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "mod_pagespeed":

 * Package name: mod_pagespeed
   Version : 1.11.33.4
   Upstream Author : Google mod_pagespeed team 
 * URL : https://github.com/pagespeed/mod_pagespeed
 * License : Apache 2.0
   Section : httpd

It builds those binary packages:

  mod_pagespeed - Apache module for rewriting web pages to reduce
latency and bandwidth

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/modpagespeed

Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/m/modpagespeed/modpagespeed_1.11.33.4-1.dsc

More information about mod_pagespeed can be obtained from
https://github.com/pagespeed/mod_pagespeed/

Regards,
Jeff Kaufman