Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Sean Whitton writes:


[... Elided completed tasks ...]

>
> Please accept my apologies for not raising these suggestions in a
> previous e-mail, and thank you for your patience with this sponsorship
> process -- I'm confident I'll be able to upload after your next update.
>
> (don't forget dch -r)

Quite the contrary, I am grateful for your guidance so far.

This time I have not set the git tag just in case some more
modifications are needed.  Now I see that it is better to leave it unset
since the uploader is the one that has the last word about it.  Please
feel free to set it if you think the package is ready for uploading.

Thanks!

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Sean Whitton]

Hello Alberto,

On Thu, Dec 29, 2016 at 05:01:29PM +0100, Alberto Luaces wrote:
> Sean Whitton writes:
> >
> > If not, you should merge the changelog entries for -1 and -2.  It's just
> > confusing to have changlog entries that never made it into the Debian
> > archive.
> >
> 
> Well, it seemed cleaner than modifying an already published history, but
> I understand no solution is immune to drawbacks.  I have now pushed the
> new, fixed branch.  Please note that you will have to re-synchronise, or
> clone the repository again from scratch.

Oh dear, that wasn't what I meant!  I was suggesting you just make a
commit merging the changelog entries together.  Anyway, it's done now.

I'd like to suggest some improvements to your changelog:

>   * Updated d/control according to d.e.a.p.t. guidelines.

Only an existing team member would know what d.e.a.p.t. is!  Perhaps add
the URI ?

You also rewrote d/rules, but this is not mentioned in the changelog.

>   * Update standards to 3.9.8.

Did you have to change anything in the packaging for this update?  If
not, it's conventional to write "(no changes required)".

>   * Disabled parents in clojure mode due to upgrading errors.

This is meaningless to someone not already familiar with yasnippet.  You
wrote a great patch header, so I would suggest just this changelog
entry:

* Add 0001-Avoid-.dpkg-new-upgrading-error.patch

Please accept my apologies for not raising these suggestions in a
previous e-mail, and thank you for your patience with this sponsorship
process -- I'm confident I'll be able to upload after your next update.

(don't forget dch -r)

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Hello Sean,

Sean Whitton writes:

> Hello Alberto,
>
> On Wed, Dec 28, 2016 at 11:43:29PM +0100, Alberto Luaces wrote:
>> I have now pushed a new release.
>
> Did someone else upload 0~git20161123-1?
>

No...

>
> If not, you should merge the changelog entries for -1 and -2.  It's just
> confusing to have changlog entries that never made it into the Debian
> archive.
>

Well, it seemed cleaner than modifying an already published history, but
I understand no solution is immune to drawbacks.  I have now pushed the
new, fixed branch.  Please note that you will have to re-synchronise, or
clone the repository again from scratch.

>
> After merging them, be sure to run `dch -r` to update the timestamp.
>

Done.  The timestamp is refreshed.

>
> Also, I think you need to put a tag '0_git20161123' on the upstream
> branch.  That's how gbp generates a tarball.

Done as well: upstream/0_git20161123, as gbp expects.

Thanks!

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Sean Whitton]

Hello Alberto,

On Wed, Dec 28, 2016 at 11:43:29PM +0100, Alberto Luaces wrote:
> I have now pushed a new release.

Did someone else upload 0~git20161123-1?

If not, you should merge the changelog entries for -1 and -2.  It's just
confusing to have changlog entries that never made it into the Debian
archive.

After merging them, be sure to run `dch -r` to update the timestamp.

Also, I think you need to put a tag '0_git20161123' on the upstream
branch.  That's how gbp generates a tarball.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Sean Whitton writes:

> Hello Alberto,
>
> On Wed, Dec 28, 2016 at 09:31:53PM +0100, Alberto Luaces wrote:
>> Thanks, Sean.  I have addressed the gbp.conf and changelog issues and I
>> think the realease is ready to go.
>
> Thanks again for your work.
>
> gbp.conf says upstream-branch=upstream but your upstream sources are on
> a branch called 'master' ...

Thanks for noticing!  Strangely enough, I missed that because gbp
buildpackage was successful nevertheless.

I have now pushed a new release.

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Sean Whitton]

Hello Alberto,

On Wed, Dec 28, 2016 at 09:31:53PM +0100, Alberto Luaces wrote:
> Thanks, Sean.  I have addressed the gbp.conf and changelog issues and I
> think the realease is ready to go.

Thanks again for your work.

gbp.conf says upstream-branch=upstream but your upstream sources are on
a branch called 'master' ...

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Thanks, Sean.  I have addressed the gbp.conf and changelog issues and I
think the realease is ready to go.

Please tell me if you think that something is still missing.

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Sean Whitton]

control: owner -1 !
control: tag -1 +moreinfo

Hello Alberto,

On Mon, Dec 19, 2016 at 04:48:05PM +0100, Alberto Luaces wrote:
> After cloning the mentioned repository, one can generate both the source
> and the binary packages from it issuing
> 
> gbp buildpackage --git-debian-branch=debian --git-upstream-branch=master

You should provide a debian/gbp.conf that contains these settings.  Take
a look at other pkg-emacsen team repos.

Before I can sponsor this, I need you to update your changelog entry.
The date is 1st December, but you made changes almost two weeks after
that, so you need to re-run `dch -r`, after your final changes.
Further, you made a lot of changes to debian/ but none of them are
listed in your changelog entry.  Please add them.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Thanks, Sean.

After cloning the mentioned repository, one can generate both the source
and the binary packages from it issuing

gbp buildpackage --git-debian-branch=debian --git-upstream-branch=master

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Sean Whitton]

control: tag -1 +moreinfo

Dear Alberto,

You need to provide an orig tarball (or tell a potential sponsor how to
make one from your repo), and it would be good to note that your
packaging is on the debian branch, not the master branch.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#848687: RFS: yasnippet-snippets_0~git20161123-1

[Alberto Luaces]

Package: sponsorship-requests
Severity: normal

Hello,

I have packaged a new version of yasnippet-snippets:

https://anonscm.debian.org/git/pkg-emacsen/pkg/yasnippet-snippets.git/

I am looking for someone in the Debian Emacsen team to sponsor this
upload.

Thanks!