Bug#849339: xcolorsel: FTBFS on hppa - conflicting HP compiler options

2023-03-12 Thread John David Anglin

The original patch is best.

The "-Aa" option is not compatible with gcc.  With gcc, the "-Aa" option is an 
assert. This option
invokes ANSI mode with the HP compiler.

CCOPTIONS only needs setting when not using gcc.  gcc defines _HPUX_SOURCE by 
default on HP-UX.

Regards,
Dave Anglin

--
John David Anglin  dave.ang...@bell.net



Bug#849339: xcolorsel: FTBFS on hppa - conflicting HP compiler options

2016-12-25 Thread John David Anglin
Package: xcolorsel
Version: 1.1a-20
Severity: normal
Tags: patch

Dear Maintainer,

The build fails here:
gcc -g -O2 -fdebug-prefix-map=/<>=. -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Aa 
-D_HPUX_SOURCE-Dlinux -D__hppa__ -D_POSIX_C_SOURCE=199309L  
-D_POSIX_SOURCE -D_XOPEN_SOURCE 
-D_BSD_SOURCE -D_SVID_SOURCE 
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  
 -DFUNCPROTO=15 -DNARROWPROTO
-DHELPFILE=\"/usr/lib/X11/xcolorsel/Xcolorsel.help\" -Wdate-time 
-D_FORTIFY_SOURCE=2  -c -o RgbText.o RgbText.c
:0:1: error: missing '(' after predicate
In file included from /usr/include/stdio.h:27:0,
 from RgbText.c:77:

This error is caused by the HP compiler option '-Aa'.

Full log is here:
https://buildd.debian.org/status/fetch.php?pkg=xcolorsel=hppa=1.1a-20=1482455899

The HP options are added by Imakefile.  Build is successful with the attached
patch.

Regards,
Dave Anglin

-- System Information:
Debian Release: stretch/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)

Kernel: Linux 4.9.0+ (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
--- Imakefile.save  2016-12-25 13:50:49.166869105 -0500
+++ Imakefile   2016-12-22 21:10:25.409482294 -0500
@@ -50,8 +50,10 @@
 /* Please add any preprocessor defines in config.h */
 
 #ifdef HPArchitecture
+#ifndef __GNUC__
 CCOPTIONS = -Aa -D_HPUX_SOURCE
 #endif
+#endif
 
 XPALDIR = $(LIBDIR)/xcolorsel
 HELPFILE = $(XPALDIR)/Xcolorsel.help