Bug#849521: Assistance with packaging ruTorrent
Hello JavaScript Team, I have a package pending with a Request for Sponsorship (my first package), and I am blocked with the following lintian errors: 1. A source-is-missing error: js/jquery.flot.js line length is 3134 characters (>512) This one occurs because the library flot (https://github.com/flot/flot), which does not have a later release from the included release in 2014, has an inlined function of 3134 characters: https://github.com/flot/flot/blob/master/jquery.flot.js Any tips on a good way to correct this? --- 2. Two source-is-missing errors that are false positives because of a long line in the source file. But if I create a debian/rutorrent.lintian-overrides with the contents: rutorrent source: source-is-missing plugins/extsearch/init.js then I get an error: rutorrent: malformed-override Override of source-is-missing for package type source (expecting binary) How can I successfully override these? --- 3. embedded-javascript-library warnings because upstream has packaged their dependencies. The dependency versions are very old, for example: Based on the md5sum of jquery.js, upstream is using jQuery v1.11.2. libjs-jquery is 3.1.1-2, two major versions ahead, thus I doubt I can drop in this replacement and test thoroughly enough to ship it with any confidence that there won't be many run-time bugs. And if I can't drop in a replacement, I would feel quite a hindrance to the developer bothering him with updating his JavaScript dependencies that currently work just fine. I have noticed that, for example, the "wordpress" package has overrides: # Opportunistic replacement is in place but the Debian version does # not match the wordpress version wordpress: embedded-javascript-library usr/share/wordpress/wp-includes/js/jquery/jquery.form.js please use libjs-jquery-form wordpress: embedded-javascript-library usr/share/wordpress/wp-includes/js/jquery/jquery.form.min.js please use libjs-jquery-form ... Is it acceptable for me to do the same, at least for the time being? --- Package can be seen here: https://mentors.debian.net/package/rutorrent and the associated RFS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849521
Bug#849521: Assistance with packaging ruTorrent
On Wed, Dec 28, 2016 at 02:56:17PM -0500, Taylor Kline wrote: > 1. A source-is-missing error: > > js/jquery.flot.js line length is 3134 characters (>512) > > This one occurs because the library flot (https://github.com/flot/flot), > which does not have a later release from the included release in 2014, has > an inlined function of 3134 characters: > https://github.com/flot/flot/blob/master/jquery.flot.js > > Any tips on a good way to correct this? Remove the file from the tarball, you shouldn't use it anyway, use the libjs-jquery-flot package instead. > 2. Two source-is-missing errors that are false positives because of a long > line in the source file. Why do you think they are false positives? Very long lines aren't usually user-editable. > But if I create a > > debian/rutorrent.lintian-overrides > > with the contents: > > rutorrent source: source-is-missing plugins/extsearch/init.js > > then I get an error: > > rutorrent: malformed-override Override of source-is-missing for package > type source (expecting binary) > > How can I successfully override these? debian/rutorrent.lintian-overrides contains overrides for the rutorrent binary package. The manual says "If the override is for a source package, you have to place it at debian/source/lintian-overrides or debian/source.lintian-overrides (the former path is preferred)." -- WBR, wRAR signature.asc Description: PGP signature
Bug#849521: Assistance with packaging ruTorrent
> Remove the file from the tarball, you shouldn't use it anyway, use the > libjs-jquery-flot package instead. Oh, nice! Thank you for pointing that out! Got it :) > > 2. Two source-is-missing errors that are false positives because of a long > > line in the source file. > Why do you think they are false positives? Very long lines aren't usually > user-editable. They are false positives because the long lines are strings with HTML tags, i.e. "" > > But if I create a > > > > debian/rutorrent.lintian-overrides > > > > with the contents: > > > > rutorrent source: source-is-missing plugins/extsearch/init.js > > > > then I get an error: > > > > rutorrent: malformed-override Override of source-is-missing for package > > type source (expecting binary) > > > > How can I successfully override these? > debian/rutorrent.lintian-overrides contains overrides for the rutorrent > binary package. The manual says "If the override is for a source package, > you have to place it at debian/source/lintian-overrides or > debian/source.lintian-overrides (the former path is preferred)." Now I continue to get the lintian error and then have a warning: rutorrent source: unused-override source-is-missing plugins/extsearch/init.js 😕 any idea why lintian will not use the override? - ACTUALLY, GOT IT -- I left the above for future reference for anyone else confused, but I had to copy the entire line: rutorrent source: source-is-missing plugins/extsearch/init.js line length is 288 characters (>256) Looks like lintian is very particular in this way. Now I just have my questions from part 3 remaining 😊 I was actually able to drop-in a excanvas and libphp-snoopy, so it's only libjs-jquery that I cannot drop in version 3 without breaking the entire system. I would really like to push forward with including jquery v1.11.2 in the missing-sources if possible. Thanks so much for your help so far. -Taylor
