Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Roger Shimizu]

Control: tag -1 +moreinfo

On Tue, Jan 10, 2017 at 9:49 AM, JCF Ploemen  wrote:
> your watch file issue is caused by the presence of a colon in the url,
> at the start of every filename:
> https://dl.bintray.com/novik65/generic/:ruTorrent-3.7.zip
>
> Once you account for that things start moving on the uscan front.

Could you kindly fix the d/watch issue?
You can try the following command when trying your new d/watch file:

$ uscan --download-current-version

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1


pgpLJtoEkUfkM.pgp
Description: PGP signature

Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Taylor Kline]

Hi!

Thanks a lot for taking a look over the package.

As this is my first package, forgive me if I need a little
hand-holding here, especially with regards to the filesystem hierarchy
and safe permissions:

> I'm not overly joyed by seeing the symlink farm in /etc pointing
> to /usr/share though. This is simply wrong as the files are
> not configuration files (which is why they don't live in
> /etc to begin with). Whatever needs these files should IMHO
> be fixed up to look for the in the correct location (so
> you can drop the symlinks).
>
> Making /usr/share/ruTorrent world-writable is the main issue though.
> This will never end well. You need to think about security and
> how you manage permissions somehow. This is in my opinion a
> blocker for uploading your package.

So ruTorrent/share/settings, ruTorrent/share/torrents, and
ruTorrent/share/users are all supposed to be "accessible for reading
and writing for both rtorrent and webserver users."

This is why I placed them in /usr/share/ruTorrent/{settings, torrents,
users} and gave world-writable permissions.

But this was mostly just guesswork based on the filesystem hierarchy
standard manpages. Could you give me some advice on the correct
placement and permissions of such files that should be modifiable by
both the web-server and the user who is running the rtorrent CLI?

[Note: rTorrent != ruTorrent]

Reference: 
https://github.com/Novik/ruTorrent/wiki/Config#multiuser-and-singleuser-configuration

> Not sure but if nginx has '*-available' '*-enabled' configuration
> pattern but I think it does and then maybe there's a way to
> provide a snippet for '*-available' that a user can in normal
> cases just enable. This should simplify for the user over having
> to read up and manually configure nginx.

Great idea. So just placing an nginx config file in rutorrent.examples
and suggesting that the user create a symlink from
/etc/nginx/sites-enabled to this file if they wish to use nginx +
default configuration?

Thanks so much for your help,
-Taylor

Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Andreas Henriksson]

Hello Taylor Kline,

On Tue, Dec 27, 2016 at 11:26:30PM -0500, Taylor Kline wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Hello fine mentors,
> 
> I am looking for a sponsor for "rutorrent"
> 
> Package name: rutorrent
> Version : 3.7-1
[...]
> 
>   /etc/ruTorrent  - server files
> 
>   /usr/share/ruTorrent  - user-set configuration files chmod'd to a+rwX
[...]

Thanks for being upfront with this, appreciated.

I've looked over your package which I think mostly looks good.

I'm not overly joyed by seeing the symlink farm in /etc pointing
to /usr/share though. This is simply wrong as the files are
not configuration files (which is why they don't live in
/etc to begin with). Whatever needs these files should IMHO
be fixed up to look for the in the correct location (so
you can drop the symlinks).

Making /usr/share/ruTorrent world-writable is the main issue though.
This will never end well. You need to think about security and
how you manage permissions somehow. This is in my opinion a
blocker for uploading your package.

Please also consider upstreaming your manpages.

Not sure but if nginx has '*-available' '*-enabled' configuration
pattern but I think it does and then maybe there's a way to
provide a snippet for '*-available' that a user can in normal
cases just enable. This should simplify for the user over having
to read up and manually configure nginx.

Regards,
Andreas Henriksson

Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Taylor Kline]

Thank you for your prompt attention! I will email the JS mailing list.

On Wed, Dec 28, 2016 at 4:28 AM, Sean Whitton 
wrote:

> control: tag -1 +moreinfo
>
> Dear Taylor,
>
> Thanks for this package.  Looks interesting.
>
> On Tue, Dec 27, 2016 at 11:26:30PM -0500, Taylor Kline wrote:
> > lintian is throwing the following 'serious' errors that I haven't been
> entirely
> > sure what to do with:
> >
> >   jquery.flot.js source missing - this file has an inlined function of
> 3134
> > characters. Unfortunately this cannot be corrected in a straightforward
> manner
> > because the flot library has not been maintained since 2014.
>
> It would violate DFSG if you didn't include the source.  The upload
> would be rejected by the ftp-masters.  So you need to replace this file
> with something that has source code.  The Debian javascript team might
> be able to help.
>
> > There are also a few warnings about using embedded js libraries. The
> versions
> > included are much older than the libjs versions available in the Debian
> > packaging system. Thus it may take some conversations with upstream to
> > integrate these wishlist items.
>
> You need to have these conversations with upstream before this can go
> into Debian: all Debian packages need to use the packaged versions of
> libraries.
>
> If you're able to resolve these issues, please remove the moreinfo tag
> from this bug.
>
> --
> Sean Whitton
>

Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Sean Whitton]

control: tag -1 +moreinfo

Dear Taylor,

Thanks for this package.  Looks interesting.

On Tue, Dec 27, 2016 at 11:26:30PM -0500, Taylor Kline wrote:
> lintian is throwing the following 'serious' errors that I haven't been 
> entirely
> sure what to do with:
> 
>   jquery.flot.js source missing - this file has an inlined function of 3134
> characters. Unfortunately this cannot be corrected in a straightforward manner
> because the flot library has not been maintained since 2014.

It would violate DFSG if you didn't include the source.  The upload
would be rejected by the ftp-masters.  So you need to replace this file
with something that has source code.  The Debian javascript team might
be able to help.

> There are also a few warnings about using embedded js libraries. The versions
> included are much older than the libjs versions available in the Debian
> packaging system. Thus it may take some conversations with upstream to
> integrate these wishlist items.

You need to have these conversations with upstream before this can go
into Debian: all Debian packages need to use the packaged versions of
libraries.

If you're able to resolve these issues, please remove the moreinfo tag
from this bug.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client

[Taylor Kline]

Package: sponsorship-requests
Severity: wishlist

Hello fine mentors,

I am looking for a sponsor for "rutorrent"

Package name: rutorrent
Version : 3.7-1
Upstream Author : Novik 
URL : https://github.com/Novik/ruTorrent
License : GPL-3
Section : net

---

It installs the files for the front-end in:

  /etc/ruTorrent  - server files

  /usr/share/ruTorrent  - user-set configuration files chmod'd to a+rwX

I also provided a detailed manpage for the configuration, including how to
configure from scratch using nginx.

lintian is throwing the following 'serious' errors that I haven't been
entirely sure what to do with:

  jquery.flot.js source missing - this file has an inlined function of 3134
characters. Unfortunately this cannot be corrected in a straightforward
manner because the flot library has not been maintained since 2014.

The other two errors are because the source files have lines longer than
expected (288 characters and 553 characters), but these are just long lines.

I also was not able to create an override for any of these lintian errors;
overriding any of these generated an error that source-is-missing was
expecting binary files and I gave it source files.

There are also a few warnings about using embedded js libraries. The
versions included are much older than the libjs versions available in the
Debian packaging system. Thus it may take some conversations with upstream
to integrate these wishlist items.

I am also experiencing a small error with 'watch.' uscan -vv outputs:

  uscan debug: Checking href :S2EngEditor.zip
  uscan debug: Checking href :S2SteamPatch.zip
  uscan debug: Checking href :plugins-3.6.tar.gz
  uscan debug: Checking href :plugins/
  uscan debug: Checking href :ruTorrent-3.7.zip
  uscan debug: Checking href :rutorrent-3.6.tar.gz
  uscan warn: In debian/watch no matching files for watch line
https://dl.bintray.com/novik65/generic/
ru[tT]orrent[-_]?(\d[\-+\.:\~\da-zA-Z]*)(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip)

I'm not sure why:
  ru[tT]orrent@ANY_VERSION@@ARCHIVE_EXT@
would not match any of these files.

---

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/rutorrent


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/r/rutorrent/rutorrent_3.7-1.dsc

---

This closes this ITP:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671744

---

This is my first package! I did my best to follow all policy, and I foresee
no problems continuing to maintain it!

Regards,
Taylor Kline