Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
Dominique Dumont writes: > On the other hand, libtommath upstream wants to reproduce this problem on > their development branch to check whether this patch needs to be applied > upstream. See [1] Oh, I think I might have been getting confused. Bit unusual having the same bug in two packages, however it is the same bug so probably not worth splitting it up. My opinion here subject to change pending future developments. Question: Assume the fix for this is non-controversial (strike: upstream libtommath don't appear to be convinced yet), is this something I should be trying to get fixed in stretch? I suspect maybe not, it looks like X32 isn't a Debian supported platform. If you disagree, please give good reasons that would statisfy the Debian release team. -- Brian May
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
On Tuesday, 11 April 2017 07:35:25 CEST Brian May wrote: > You already fixed this bug in libtommath, but this bug is against > Heimdal not libtommath. Well, as Debian packaged, I've applied a patch. On the other hand, libtommath upstream wants to reproduce this problem on their development branch to check whether this patch needs to be applied upstream. See [1] > As the bug is not fixed in Heimdal so we have to > keep this bug report open. Sure. No problem with that. All the best [1] https://github.com/libtom/libtommath/pull/69 -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
Dominique Dumont writes: > libtommath upstream cannot reproduce this problem. > > Could you try to build heimdal with a more recent version of libtommath ? > (like the version that packaged in Debian) See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850723#10. You already fixed this bug in libtommath, but this bug is against Heimdal not libtommath. As the bug is not fixed in Heimdal so we have to keep this bug report open. -- Brian May
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
Hello libtommath upstream cannot reproduce this problem. Could you try to build heimdal with a more recent version of libtommath ? (like the version that packaged in Debian) All the best -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
On Mon, Jan 09, 2017 at 06:03:03PM +0100, Thorsten Glaser wrote: > Source: heimdal > Version: 7.1.0+dfsg-3 > Severity: important > Tags: patch > Justification: fails to build from source (but built successfully in the past) Hello, What is that status of this bug? I see that there was a change commited to the Debian git repository, however never included in any released version. I have tried to reproduce this problem, without the change, and not had any success. Regards -- Brian May
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
Dominique Dumont dixit: >Done in lilbtommath 1.0-4 and pushed to upstream [1] . Thank you! bye, //mirabilos -- I believe no one can invent an algorithm. One just happens to hit upon it when God enlightens him. Or only God invents algorithms, we merely copy them. If you don't believe in God, just consider God as Nature if you won't deny existence. -- Coywolf Qi Hunt
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
On Mon, 09 Jan 2017 18:03:03 +0100 Thorsten Glaser wrote: >. Iâve prepared a > patch and uploaded the package to the debian-ports âunreleasedâ > repository in order to be able to dissolve the heimdalââopenldap > circular BD-Uninstallability, but would extremely appreciate if > you could merge the patch and do a regular maintainer upload soon. Done in lilbtommath 1.0-4 and pushed to upstream [1] . Thanks for the patch All the best [1] https://github.com/libtom/libtommath/pull/69 -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#850723: heimdal: FTBFS on x32 because libtommath thinks it’s amd64
Source: heimdal
Version: 7.1.0+dfsg-3
Severity: important
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Hi,
heimdal FTBFS due to testsuite failures which I traced back,
due to helpful error messages in the build log…
./libtommath/tommath.h:131:41: warning: left shift count >= width of type
[-Wshift-count-overflow]
#define MP_MASK mp_digit)1)<<((mp_digit)DIGIT_BIT))-((mp_digit)1))
^
… to libtommath (whose maintainers I Cc’d). I’ve prepared a
patch and uploaded the package to the debian-ports “unreleased”
repository in order to be able to dissolve the heimdal⇐⇒openldap
circular BD-Uninstallability, but would extremely appreciate if
you could merge the patch and do a regular maintainer upload soon.
As for libtommath… its build logs do not show this warning, but
that may be due to a difference in CFLAGS, and it does not have
such an extensive testsuite as heimdal, so it might also need to
have this patch applied (and forwarded upstream).
A better fix *might* be to fix MP_MASK to read something along
the lines of shifting 1ULL left, but the cast should already do
that, so I’m unsure why this doesn’t help. Do note that x32 is
an ILP32 architecture with 64-bit wide CPU registers (but 32-bit
pointers and longs), so 64-bit mode “should” work (and fast, at
that) but can be a bit tricky, and that the patch I attached is
positively known to fix several issues the heimdal testsuite shows.
Thanks!
-- System Information:
Debian Release: stretch/sid
APT prefers unreleased
APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable')
Architecture: x32 (x86_64)
Foreign Architectures: i386, amd64
Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)
diff -Nru heimdal-7.1.0+dfsg/debian/changelog
heimdal-7.1.0+dfsg/debian/changelog
--- heimdal-7.1.0+dfsg/debian/changelog 2016-12-29 16:37:37.0 +0100
+++ heimdal-7.1.0+dfsg/debian/changelog 2017-01-09 17:14:57.0 +0100
@@ -1,3 +1,10 @@
+heimdal (7.1.0+dfsg-3+x32.1) unreleased; urgency=medium
+
+ * Non-maintainer upload.
+ * fix_tommath_x32: Fix building on x32.
+
+ -- Thorsten Glaser Mon, 09 Jan 2017 17:14:57 +0100
+
heimdal (7.1.0+dfsg-3) unstable; urgency=medium
* Fix building arch-only. Closes: #806045
diff -Nru heimdal-7.1.0+dfsg/debian/patches/fix_tommath_x32
heimdal-7.1.0+dfsg/debian/patches/fix_tommath_x32
--- heimdal-7.1.0+dfsg/debian/patches/fix_tommath_x32 1970-01-01
01:00:00.0 +0100
+++ heimdal-7.1.0+dfsg/debian/patches/fix_tommath_x32 2017-01-09
17:14:43.0 +0100
@@ -0,0 +1,14 @@
+# DP: do not detect x32 as 64-bit platform
+# DP: fixes test failures due to ISO C Undefined Behaviour in MP_MASK macro
+
+--- a/lib/hcrypto/libtommath/tommath.h
b/lib/hcrypto/libtommath/tommath.h
+@@ -46,7 +46,7 @@ extern "C" {
+
+
+ /* detect 64-bit mode if possible */
+-#if defined(__x86_64__)
++#if defined(__x86_64__) && !defined(__ILP32__)
+#if !(defined(MP_64BIT) && defined(MP_16BIT) && defined(MP_8BIT))
+ #define MP_64BIT
+#endif
diff -Nru heimdal-7.1.0+dfsg/debian/patches/series
heimdal-7.1.0+dfsg/debian/patches/series
--- heimdal-7.1.0+dfsg/debian/patches/series2016-12-27 18:10:01.0
+0100
+++ heimdal-7.1.0+dfsg/debian/patches/series2017-01-09 17:12:45.0
+0100
@@ -13,3 +13,4 @@
parallel-build
check_iprop_races
disable_iprop
+fix_tommath_x32
