Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-24 Thread James Clarke 
Control: clone -1 -2
Control: retitle -2 pdebuild: --debbuildopts not passed through to dpkg-source
Control: tags -2 confirmed

On 24 Jan 2017, at 14:07, Vincent Bernat  wrote:
> ❦ 19 janvier 2017 08:35 +0100, Vincent Bernat  :
> 
 Actually, breaking it completely wasn't my intention, I'll reinstate
 support for it, sorry for the disruption.
>>> 
>>> The pbuilder from git works fine for me. Thanks!
>> 
>> Well, using "-nc" from gbp buildpackage doesn't work. Is it related or
>> should I investigate more?
> 
> 0.228.1 fixes "-nc", but other options don't work. For example, in some
> cases, I am using "-i" (directly from gbp buildpackage). It seems the
> option is not provided anymore to dpkg-source.
> 
> Downgrading to 0.227 also fixes that.

Yes, you're right, none of the options for dpkg-source are passed through
by pdebuild. Looking at dpkg-buildpackage's source (or --help) gives the
following options which are passed through to other commands:

> Options passed to dpkg-architecture:
>   -a, --host-arch   set the host Debian architecture.
>   -t, --host-type   set the host GNU system type.
>   --target-arch set the target Debian architecture.
>   --target-type set the target GNU system type.

Irrelevant for pdebuild, since it has its own architecture options, and
doesn't call dpkg-architecture as part of building the source package.

> Options passed to dpkg-genchanges:
>   -si source includes orig, if new upstream (default).
>   -sa source includes orig, always.
>   -sd source is diff and .dsc only.
>   -v changes since version .
>   -m, --release-by=maintainer for this release is .
>   -e, --build-by=  maintainer for this build is .
>   -Cchanges are described in .
>   --changes-option=  pass option  to dpkg-genchanges.

Implemented in 0.228.1

> Options passed to dpkg-source:
>   -sn force Debian native source format.
>   -s[sAkurKUR]see dpkg-source for explanation.
>   -z, --compression-level=
>   compression level to use for source.
>   -Z, --compression=
>   compression to use for source 
> (gz|xz|bzip2|lzma).
>   -i, --diff-ignore[=] ignore diffs of files matching .
>   -I, --tar-ignore[=]
>   filter out files when building tarballs.
>   --source-option=   pass option  to dpkg-source.

These need to be implemented, similar to dpkg-genchanges.
Note to self (and Mattia): these are passed to --before/--after-build,
not just --build.

Regards,
James

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-24 Thread Vincent Bernat 
 ❦ 19 janvier 2017 08:35 +0100, Vincent Bernat  :

>>> Actually, breaking it completely wasn't my intention, I'll reinstate
>>> support for it, sorry for the disruption.
>>
>> The pbuilder from git works fine for me. Thanks!
>
> Well, using "-nc" from gbp buildpackage doesn't work. Is it related or
> should I investigate more?

0.228.1 fixes "-nc", but other options don't work. For example, in some
cases, I am using "-i" (directly from gbp buildpackage). It seems the
option is not provided anymore to dpkg-source.

Downgrading to 0.227 also fixes that.
-- 
Many a writer seems to think he is never profound except when he can't
understand his own meaning.
-- George D. Prentice


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-19 Thread Guido Günther 
On Tue, Jan 17, 2017 at 10:22:01PM +0100, Vincent Bernat wrote:
>  ❦ 17 janvier 2017 11:21 +0100, Mattia Rizzolo  :
> 
> > Actually, breaking it completely wasn't my intention, I'll reinstate
> > support for it, sorry for the disruption.
> 
> The pbuilder from git works fine for me. Thanks!

Both of these still fail for me with current pbuilder git:

pdebuild --pbuilder cowbuilder -- --debbuildopts -nc
pdebuild --pbuilder cowbuilder --debbuildopts -nc

(clean is still being run):

   I: using cowbuilder as pbuilder
   I: Passing --debbuildopts as a pdebuild option is deprecated; pass it after 
'--'.
   dpkg-checkbuilddeps: error: Unmet build dependencies: 
default-libmysqlclient-dev dh-php libboost-date-time-dev 
libboost-filesystem-dev libboost-thread-dev libcurl4-openssl-dev 
libgoogle-perftools-dev libical-dev libssl-dev libvmime-dev php7.0-dev xmlto
   W: Unmet build-dependency in source
   dh clean --builddirectory=debian/build --parallel --with 
systemd,autoreconf,php
   ...

while

   pdebuild --pbuilder cowbuilder --debbuildopts -nc

works with 0.227. Am I missing the correct invocation for 0.228?
Cheers,
 -- Guido

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-18 Thread Vincent Bernat 
 ❦ 17 janvier 2017 22:22 +0100, Vincent Bernat  :

>> Actually, breaking it completely wasn't my intention, I'll reinstate
>> support for it, sorry for the disruption.
>
> The pbuilder from git works fine for me. Thanks!

Well, using "-nc" from gbp buildpackage doesn't work. Is it related or
should I investigate more?
-- 
The very ink with which all history is written is merely fluid prejudice.
-- Mark Twain


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Vincent Bernat 
 ❦ 17 janvier 2017 11:21 +0100, Mattia Rizzolo  :

> Actually, breaking it completely wasn't my intention, I'll reinstate
> support for it, sorry for the disruption.

The pbuilder from git works fine for me. Thanks!
-- 
Don't use conditional branches as a substitute for a logical expression.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Vincent Bernat 
 ❦ 17 janvier 2017 16:12 +0100, Mattia Rizzolo  :

> On Tue, Jan 17, 2017 at 01:41:58PM +0100, Vincent Bernat wrote:
>> Cannot test right now, but at the end of the build, cowbuilder complain
>> about not being able to unmount /dev/shm because it's busy. I assumed
>> this was because the use of a more recent pbuilder turned into a symlink
>> or the reverse.
>
> umh, though that's still not supposed to happen.  From what I could see
> mount and umount follow symlinks without any problem:

Here is what I get at the end:

I: Copying back the cached apt archive contents
I: unmounting /etc/pbuilder/deps filesystem
I: unmounting dev/pts filesystem
I: unmounting run/shm filesystem
W: Could not unmount run/shm: umount: 
/var/lib/systems/pbuilder/build/cow.24417/run/shm: target is busy
(In some cases useful info about processes that
 use the device is found by lsof(8) or fuser(1).)
W: Retrying to unmount run/shm in 5s
umount: /var/lib/systems/pbuilder/build/cow.24417/run/shm: target is busy
(In some cases useful info about processes that
 use the device is found by lsof(8) or fuser(1).)

  Could not unmount run/shm, some programs might
  still be using files in /proc (klogd?).
  Please check and kill these processes manually
  so that I can unmount run/shm.  Last umount error was:
umount: /var/lib/systems/pbuilder/build/cow.24417/run/shm: target is busy
(In some cases useful info about processes that
 use the device is found by lsof(8) or fuser(1).)

In mount, I have:

/proc on /var/lib/systems/pbuilder/build/cow.24417/proc type proc (rw,relatime)
sysfs on /var/lib/systems/pbuilder/build/cow.24417/sys type sysfs 
(rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,relatime)

/var/lib/systems/pbuilder/build/cow.24417/dev/shm is a real directory,
but not a mount point (same device as
/var/lib/systems/pbuilder/build/cow.24417/dev).

  File: /var/lib/systems/pbuilder/build/cow.24417/dev/shm
  Size: 4096Blocks: 8  IO Block: 4096   directory
Device: fd07h/64775dInode: 3802032 Links: 2
Access: (0777/drwxrwxrwx)  Uid: (0/root)   Gid: (0/root)
Access: 2017-01-17 07:14:17.547683772 +0100
Modify: 2017-01-17 07:14:17.547683772 +0100
Change: 2017-01-17 20:26:16.047469684 +0100
 Birth: -

/var/lib/systems/pbuilder/build/cow.24417/run/shm is a symlink to
/dev/shm, so that explains the problem:

  File: /var/lib/systems/pbuilder/build/cow.24417/run/shm -> /dev/shm
  Size: 8   Blocks: 0  IO Block: 4096   symbolic link
Device: fd07h/64775dInode: 2492773 Links: 3
Access: (0777/lrwxrwxrwx)  Uid: (0/root)   Gid: (0/root)
Access: 2017-01-17 07:14:17.551683739 +0100
Modify: 2017-01-17 07:14:17.551683739 +0100
Change: 2017-01-17 20:26:16.043469722 +0100
 Birth: -

After upgrading pbuilder to 0.228, tmpfs is mounted over .../dev/shm, so
the symlink is fine.

The chroot is a jessie-backports chroot BTW.
-- 
Indent to show the logical structure of a program.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Vincent Bernat 
 ❦ 17 janvier 2017 16:12 +0100, Mattia Rizzolo  :

>> Cannot test right now, but at the end of the build, cowbuilder complain
>> about not being able to unmount /dev/shm because it's busy. I assumed
>> this was because the use of a more recent pbuilder turned into a symlink
>> or the reverse.
>
> umh, though that's still not supposed to happen.  From what I could see
> mount and umount follow symlinks without any problem:
[...]

OK, that was pure speculation. I need to go home to look further.

> Do you have any BINDMOUNT configured for shm?  anything strange?

I have a BINDMOUNT, but not for shm.

> Mind you, we already have a similar bug which I could reproduce
> involving updating a sqeeze chroot to wheezy (#709053), is what you see
> something similar?  Alas I could not understand what is the root cause
> of it (I have an idea it's due to the initscripts update, but I'm not
> even sure), so I don't really know how to fix that particular instance,
> but if you could take the time to see what goes wrong in your case, I'd
> be really greatful! :)

Yes, I can. Keep tuned.
-- 
Watch out for off-by-one errors.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Mattia Rizzolo 
On Tue, Jan 17, 2017 at 01:41:58PM +0100, Vincent Bernat wrote:
> Cannot test right now, but at the end of the build, cowbuilder complain
> about not being able to unmount /dev/shm because it's busy. I assumed
> this was because the use of a more recent pbuilder turned into a symlink
> or the reverse.

umh, though that's still not supposed to happen.  From what I could see
mount and umount follow symlinks without any problem:

mattia@warren /tmp % l
total 236
drwxr-xr-x 2 mattia mattia  4096 Jan 17 16:02 a
lrwxrwxrwx 1 mattia mattia 1 Jan 17 16:02 b -> a
...
mattia@warren /tmp % sudo mount -t tmpfs tmpfs b
mattia@warren /tmp % sudo mount -t tmpfs tmpfs b
mattia@warren /tmp % sudo mount -t tmpfs tmpfs b
mattia@warren /tmp % sudo mount -t tmpfs tmpfs a
mattia@warren /tmp % sudo mount -t tmpfs tmpfs a
mattia@warren /tmp % mount|grep $PWD
tmpfs on /tmp/a type tmpfs (rw,relatime)
tmpfs on /tmp/a type tmpfs (rw,relatime)
tmpfs on /tmp/a type tmpfs (rw,relatime)
tmpfs on /tmp/a type tmpfs (rw,relatime)
tmpfs on /tmp/a type tmpfs (rw,relatime)
mattia@warren /tmp % sudo umount b
mattia@warren /tmp % sudo umount a
mattia@warren /tmp % sudo umount a
mattia@warren /tmp % sudo umount b
mattia@warren /tmp % mount|grep $PWD
tmpfs on /tmp/a type tmpfs (rw,relatime)
mattia@warren /tmp % sudo umount a
mattia@warren /tmp % 


Also tests run by James show that upgrading pbuilder, running --update,
then downgrade pbuilder, --login and exit works without problems.

Do you have any BINDMOUNT configured for shm?  anything strange?
Mind you, we already have a similar bug which I could reproduce
involving updating a sqeeze chroot to wheezy (#709053), is what you see
something similar?  Alas I could not understand what is the root cause
of it (I have an idea it's due to the initscripts update, but I'm not
even sure), so I don't really know how to fix that particular instance,
but if you could take the time to see what goes wrong in your case, I'd
be really greatful! :)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Vincent Bernat 
 ❦ 17 janvier 2017 11:18 +0100, Mattia Rizzolo  :

>> > It seems the same as #618959 but it worked just fine for me until the
>> > latest update. Just downgrading to 0.227 fixes the problem for me.
>> 
>> But, then, I am hit but the /dev/shm change.
>
> What do you mean by this?

Cannot test right now, but at the end of the build, cowbuilder complain
about not being able to unmount /dev/shm because it's busy. I assumed
this was because the use of a more recent pbuilder turned into a symlink
or the reverse.
-- 
Reader, suppose you were an idiot.  And suppose you were a member of
Congress.  But I repeat myself.
-- Mark Twain


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Mattia Rizzolo 
On Tue, Jan 17, 2017 at 07:57:51AM +0100, Vincent Bernat wrote:
> Since the latest update of pbuilder, options passed to pdebuild
> through --debbuildopts are not passed to cowbuilder anymore.

Right, I always found it a tad confusing.
You can/should pass it by using a pbuilder option, that is by using
pdebuild --buildresult ../ --pbuilder cowbuilder -- --debbuildopts '-sa'
but then, it's a git-pbuilder problem, I'll open a bug against it.

Actually, breaking it completely wasn't my intention, I'll reinstate
support for it, sorry for the disruption.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-17 Thread Mattia Rizzolo 
On Tue, Jan 17, 2017 at 08:09:23AM +0100, Vincent Bernat wrote:
>  ❦ 17 janvier 2017 07:57 +0100, Vincent Bernat  :
> 
> > It seems the same as #618959 but it worked just fine for me until the
> > latest update. Just downgrading to 0.227 fixes the problem for me.
> 
> But, then, I am hit but the /dev/shm change.

What do you mean by this?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-16 Thread Vincent Bernat 
 ❦ 17 janvier 2017 07:57 +0100, Vincent Bernat  :

> It seems the same as #618959 but it worked just fine for me until the
> latest update. Just downgrading to 0.227 fixes the problem for me.

But, then, I am hit but the /dev/shm change.
-- 
Terminate input by end-of-file or marker, not by count.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#851640: --debbuildopts not propagated anymore to cowbuilder

2017-01-16 Thread Vincent Bernat 
Package: pbuilder
Version: 0.228
Severity: normal

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hey!

Since the latest update of pbuilder, options passed to pdebuild
through --debbuildopts are not passed to cowbuilder anymore.

bernat   11433  0.0  0.0   4284   784 pts/1S+   07:50   0:00 /bin/sh -c 
git-pbuilder -sa
bernat   11434  0.0  0.0  11192  3032 pts/1S+   07:50   0:00 /bin/bash 
/usr/bin/git-pbuilder -sa
bernat   11440  0.0  0.0  11732  3504 pts/1S+   07:50   0:00 /bin/bash 
/usr/bin/pdebuild --buildresult ../ --pbuilder cowbuilder --debbuildopts  '-sa' 
-- --basepath /var/cache/pbuilder/base-jessie-backports.cow
bernat   11466  0.0  0.0  11732  2664 pts/1S+   07:50   0:00 /bin/bash 
/usr/bin/pdebuild --buildresult ../ --pbuilder cowbuilder --debbuildopts  '-sa' 
-- --basepath /var/cache/pbuilder/base-jessie-backports.cow
root 11791  0.0  0.0  68368  3868 pts/1S+   07:50   0:00 sudo -E 
cowbuilder --build --buildresult /home/bernat/code/debian/build-area 
--debbuildopts  --debbuildopts  --basepath 
/var/cache/pbuilder/base-jessie-backports.cow ../haproxy_1.7.2-1~bpo8+1.dsc
root 11792  0.0  0.0  10676  1832 pts/1S+   07:50   0:00 cowbuilder 
--build --buildresult /home/bernat/code/debian/build-area --debbuildopts  
--debbuildopts  --basepath /var/cache/pbuilder/base-jessie-backports.cow 
../haproxy_1.7.2-1~bpo8+1.dsc

It seems the same as #618959 but it worked just fine for me until the
latest update. Just downgrading to 0.227 fixes the problem for me.

- -- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (101, 
'experimental-debug'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages pbuilder depends on:
ii  cdebootstrap   0.7.6
ii  debconf [debconf-2.0]  1.5.59
ii  debootstrap1.0.87
ii  dpkg-dev   1.18.18
ii  wget   1.18-4

Versions of packages pbuilder recommends:
ii  devscripts  2.17.0
ii  eatmydata   105-5
ii  fakeroot1.21-3
ii  iproute24.9.0-1
ii  net-tools   1.60+git20161116.90da8a0-1
ii  sudo1.8.19p1-1

Versions of packages pbuilder suggests:
ii  cowdancer   0.83
ii  gdebi-core  0.9.5.7+nmu1

- -- Configuration Files:
/etc/pbuilderrc changed [not included]

- -- debconf information excluded

-BEGIN PGP SIGNATURE-

iQJGBAEBCAAwFiEErvI0h2bzccaJpzYAlaQv6DU1JfkFAlh9wG8SHGJlcm5hdEBk
ZWJpYW4ub3JnAAoJEJWkL+g1NSX5kzIQAIji6JI14YDQ4RO3GJlkqRY9Kmsr2sbX
6m3WnpI8p+LI8z2MfNUQgW9X0zTkW33ZQn7VQmxrV1K9z9gSujQlNNEUZET0j9aC
ZpZOWbS3MqNp3aheB7AoL/HGNrfY2Zam8aYPlELf3li5KztRC0/SKqgVFiT6gJxl
tuVsIJV2EIG5VYfUy8Ee4ZYp+5VBt5AYmYz0pOO5Z7evE5nSYL5sod8pUqBXf9hy
uEwH12Q166njUllwRsK6udiQr6TgAb1/urr/kI78Yo0tSygmsdzSujyO6DXifiS4
zrFQ0rnPjjpBXO1a4WHdGQTZ4yHAGih9MLBpywyhv7zNuvdXoVDNeCIIgLLJbamA
xi5Oh4ieEXXx2ZMvttToehYr56ucFA4HNM9EqJWASzP1gHB3YJI4ealCyO7o/19Z
v0Hpl+2Ag607fETEiYRRvBIh2j6ymjniAqi+CYQ9xaedxV6AY+4L1MQl1u9smOw5
SIJLtn0egsbeGOXYlsk4JJjTPVuWJ8QMAl3Dpgd5R4Czi6TnhYkL/BXDpk67dmjH
tSMDk5B8xzN8sS1ywOnUHGZEz+GxyGkfJ1VBegJG9lsFHF6b9MnhoO1YJMw4xnDH
DHRbCSQA1fUwMMfCcEiKJ472jLyTIlTMc7S+Rz7MhdTdSv/4MUBMsIeGgEkxmvJ5
R/fCNAX3fCoK
=nNl7
-END PGP SIGNATURE-