Bug#853117: tightvnc FTBFS on mips*: PIE / stipmips.s problem
Thank you! // Ola On 4 February 2017 at 23:45, Adrian Bunk wrote: > Control: tags -1 patch > > On Mon, Jan 30, 2017 at 12:03:26PM +0100, Ola Lundqvist wrote: > > Hi > > > > Thank you for this bug report. Do you have a proposed patch for this? > >... > > Patch is attached. > > cu > Adrian > > -- > >"Is there not promise of rain?" Ling Tan asked suddenly out > of the darkness. There had been need of rain for many days. >"Only a promise," Lao Er said. >Pearl S. Buck - Dragon Seed > > -- --- Inguza Technology AB --- MSc in Information Technology / o...@inguza.comFolkebogatan 26\ | o...@debian.org 654 68 KARLSTAD| | http://inguza.com/Mobile: +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / ---
Bug#853117: tightvnc FTBFS on mips*: PIE / stipmips.s problem
Control: tags -1 patch On Mon, Jan 30, 2017 at 12:03:26PM +0100, Ola Lundqvist wrote: > Hi > > Thank you for this bug report. Do you have a proposed patch for this? >... Patch is attached. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed Description: Don't use assembler code PIE versus stipmips.s results in a FTBFS. . stipmips.s is assembler code from 1990, such assembler optimizations are no longer necessary. Author: Adrian Bunk Bug-Debian: https://bugs.debian.org/853117 --- tightvnc-1.3.9.orig/Xvnc/programs/Xserver/cfb/Imakefile +++ tightvnc-1.3.9/Xvnc/programs/Xserver/cfb/Imakefile @@ -10,28 +10,6 @@ XCOMM $XFree86: xc/programs/Xserver/cfb/ /* cfb8cppl.c MUST come last to avoid confusing makedepend */ PSZSRCS = cfb8bit.c cfbteblt8.c cfbglrop8.c cfbpush8.c cfbrctstp8.c cfb8cppl.c PSZOBJS = cfb8bit.o cfbteblt8.o cfbglrop8.o cfbpush8.o cfbrctstp8.o cfb8cppl.o -#ifdef MipsArchitecture -#ifndef ArcArchitecture -#ifndef Mips64Architecture -STIPPLESRC = stipmips.s stipmipste.s -STIPPLEOBJ = stipmips.o stipmipste.o -STIPPLEDEF = -DHAS_STIPPLE_CODE -#endif -#endif -#endif -#ifdef SparcArchitecture -STIPPLESRC = stipsparc.s stipsparcte.s -STIPPLEOBJ = stipsparc.o stipsparcte.o -STIPPLEDEF = -DHAS_STIPPLE_CODE -#endif -#endif - -#if PixelSize == 32 -#ifdef SparcArchitecture -STIPPLESRC = stipsprc32.s stipsprcte32.s -STIPPLEOBJ = stipsprc32.o stipsprcte32.o -STIPPLEDEF = -DHAS_STIPPLE_CODE -#endif #endif
Bug#853117: tightvnc FTBFS on mips*: PIE / stipmips.s problem
Hi Thank you for this bug report. Do you have a proposed patch for this? If not do you think it would be acceptable if we remove the mips architecture for this package. I planned to remove support for this package (and let people use tigervnc instead) but it turned out that there were corner cases when that did not work out well enough. This is why I added the package back and then this problem turned up. Best regards // Ola On 29 January 2017 at 22:05, Adrian Bunk wrote: > Source: tightvnc > Version: 1:1.3.9-9 > Severity: serious > > https://buildd.debian.org/status/package.php?p=tightvnc > > ... > gcc -o Xvnc -O2 -ansi -pedantic -L../.././/exports/lib dix/libdix.a > os/libos.a ../.././/lib/Xau/libXau.a ../.././/lib/Xdmcp/libXdmcp.a > ../.././/exports/lib/libfont.a hw/vnc/libvnc.a > ../.././/../libvncauth/libvncauth.a cfb/libcfb.a cfb16/libcfb.a > cfb24/libcfb.a cfb32/libcfb.a mfb/libmfb.a dix/libxpstubs.a mi/libmi.a > Xext/libext.a-lz -lm -rdynamic -ldl > -L/usr/local/lib -ljpeg -lz -lcrypt -Wl,-rpath-link,../.././/exports/lib > /usr/bin/ld: cfb/libcfb.a(stipmips.o): relocation R_MIPS_HI16 against `a > local symbol' can not be used when making a shared object; recompile with > -fPIC > cfb/libcfb.a: error adding symbols: Bad value > collect2: error: ld returned 1 exit status > Makefile:718: recipe for target 'Xvnc' failed > make[4]: *** [Xvnc] Error 1 > > > The error message is misleading, the problem is actually > PIE versus stipmips.s > > One option would be to disable PIE when building tightvnc. > > But stipmips.s is assembler code Keith wronte in 1990 (sic). > > I doubt this is still required today and would suggest to > fix this FTBFS by nuking the HAS_STIPPLE_CODE parts from > Xvnc/programs/Xserver/cfb/Imakefile so that the C code is > used like on all other release architectures. -- --- Inguza Technology AB --- MSc in Information Technology / o...@inguza.comFolkebogatan 26\ | o...@debian.org 654 68 KARLSTAD| | http://inguza.com/Mobile: +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / ---
Bug#853117: tightvnc FTBFS on mips*: PIE / stipmips.s problem
Source: tightvnc Version: 1:1.3.9-9 Severity: serious https://buildd.debian.org/status/package.php?p=tightvnc ... gcc -o Xvnc -O2 -ansi -pedantic -L../.././/exports/lib dix/libdix.a os/libos.a ../.././/lib/Xau/libXau.a ../.././/lib/Xdmcp/libXdmcp.a ../.././/exports/lib/libfont.a hw/vnc/libvnc.a ../.././/../libvncauth/libvncauth.a cfb/libcfb.a cfb16/libcfb.a cfb24/libcfb.a cfb32/libcfb.a mfb/libmfb.a dix/libxpstubs.a mi/libmi.a Xext/libext.a -lz -lm -rdynamic -ldl -L/usr/local/lib -ljpeg -lz -lcrypt -Wl,-rpath-link,../.././/exports/lib /usr/bin/ld: cfb/libcfb.a(stipmips.o): relocation R_MIPS_HI16 against `a local symbol' can not be used when making a shared object; recompile with -fPIC cfb/libcfb.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status Makefile:718: recipe for target 'Xvnc' failed make[4]: *** [Xvnc] Error 1 The error message is misleading, the problem is actually PIE versus stipmips.s One option would be to disable PIE when building tightvnc. But stipmips.s is assembler code Keith wronte in 1990 (sic). I doubt this is still required today and would suggest to fix this FTBFS by nuking the HAS_STIPPLE_CODE parts from Xvnc/programs/Xserver/cfb/Imakefile so that the C code is used like on all other release architectures.
