Bug#853727: unblock: limnoria/2017.01.10-1

[Emilio Pozuelo Monfort]

On 31/01/17 12:14, Mattia Rizzolo wrote:
> Package: release.debian.org
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Please unblock package limnoria.
> 
> It is a new upstream, yes, but
> 1) it's a leaf package
> 2) it has a very extensive testsuite
> 3) the changes are so minimal...
> 4) it fixes the only bug this package has ;)
> 
> Attached a debdiff against the current version in stretch.
> 
> unblock limnoria/2017.01.10-1

Done, but now you owe me two RC bug fixes.

Cheers,
Emilio

Bug#853727: unblock: limnoria/2017.01.10-1

[Mattia Rizzolo]

Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package limnoria.

It is a new upstream, yes, but
1) it's a leaf package
2) it has a very extensive testsuite
3) the changes are so minimal...
4) it fixes the only bug this package has ;)

Attached a debdiff against the current version in stretch.

unblock limnoria/2017.01.10-1

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
diffstat for limnoria-2016.12.08 limnoria-2017.01.10

 PKG-INFO  |2 -
 debian/changelog  |9 +
 debian/rules  |1 
 plugins/Channel/plugin.py |9 +
 plugins/Debug/plugin.py   |2 +
 plugins/Google/plugin.py  |2 -
 plugins/Unix/test.py  |6 ++-
 scripts/supybot   |2 -
 scripts/supybot-test  |5 ++
 src/irclib.py |   78 ++
 src/test.py   |1 
 src/version.py|2 -
 12 files changed, 94 insertions(+), 25 deletions(-)

diff -Nru limnoria-2016.12.08/debian/changelog 
limnoria-2017.01.10/debian/changelog
--- limnoria-2016.12.08/debian/changelog2016-12-15 08:40:27.0 
+0100
+++ limnoria-2017.01.10/debian/changelog2017-01-31 11:59:27.0 
+0100
@@ -1,3 +1,12 @@
+limnoria (2017.01.10-1) unstable; urgency=medium
+
+  * New upstream version 2017.01.10.
+  * d/rules: use the new --no-setuid to skip tests that might require a
+setuid binary (like /bin/ping in some hosts without settcap) as they
+wouldn't work under libeatmydata.  Closes: #834950
+
+ -- Mattia Rizzolo   Tue, 31 Jan 2017 11:59:27 +0100
+
 limnoria (2016.12.08-1) unstable; urgency=medium
 
   * New upstream version 2016.12.08.
diff -Nru limnoria-2016.12.08/debian/rules limnoria-2017.01.10/debian/rules
--- limnoria-2016.12.08/debian/rules2016-12-04 14:48:31.0 +0100
+++ limnoria-2017.01.10/debian/rules2017-01-31 11:58:29.0 +0100
@@ -13,6 +13,7 @@
PYBUILD_TEST_ARGS="PYTHONPATH={build_dir} \
build/scripts-{version}/supybot-test \
test \
+   --no-setuid \
--no-network \
--disable-multiprocessing \
--plugins-dir={build_dir}/supybot/plugins/" \
diff -Nru limnoria-2016.12.08/PKG-INFO limnoria-2017.01.10/PKG-INFO
--- limnoria-2016.12.08/PKG-INFO2016-12-08 21:11:36.0 +0100
+++ limnoria-2017.01.10/PKG-INFO2017-01-27 00:14:32.0 +0100
@@ -1,6 +1,6 @@
 Metadata-Version: 1.1
 Name: limnoria
-Version: 2016.12.08
+Version: 2017.01.10
 Summary: A modified version of Supybot (an IRC bot and framework)
 Home-page: https://github.com/ProgVal/Limnoria
 Author: Valentin Lorentz
diff -Nru limnoria-2016.12.08/plugins/Channel/plugin.py 
limnoria-2017.01.10/plugins/Channel/plugin.py
--- limnoria-2016.12.08/plugins/Channel/plugin.py   2016-12-08 
21:11:26.0 +0100
+++ limnoria-2017.01.10/plugins/Channel/plugin.py   2017-01-27 
00:13:31.0 +0100
@@ -909,10 +909,9 @@
 # Make sure we don't elicit information about private channels to
 # people or channels that shouldn't know
 capability = ircdb.makeChannelCapability(channel, 'op')
-hostmask = irc.state.nickToHostmask(msg.nick)
 if 's' in irc.state.channels[channel].modes and \
 msg.args[0] != channel and \
-not ircdb.checkCapability(hostmask, capability) and \
+not ircdb.checkCapability(msg.prefix, capability) and \
 (ircutils.isChannel(msg.args[0]) or \
  msg.nick not in irc.state.channels[channel].users):
 irc.error(_('You don\'t have access to that information.'),
@@ -937,8 +936,7 @@
 if frm is not None:
 s += format(_(' (from %s)'), frm)
 for nick in irc.state.channels[channel].users:
-hostmask = irc.state.nickToHostmask(nick)
-if ircdb.checkCapability(hostmask, capability):
+if ircdb.checkCapability(msg.prefix, capability):
 irc.reply(s, to=nick, private=True)
 irc.replySuccess()
 
@@ -969,8 +967,7 @@
 else:
 irc.error(Raise=True)
 capability = ircdb.makeChannelCapability(channel, 'op')
-hostmask = irc.state.nickToHostmask(msg.nick)
-if not ircdb.checkCapabilities(hostmask, [capability, 'admin']):
+if not ircdb.checkCapabilities(msg.prefix, [capability, 'admin']):
 irc.errorNoCapability(capability, Raise=True)
 try:
 network = conf.supybot.networks.get(irc.network)
diff -Nru limnoria-2016.12.08/plugins/Debug/plugin.py