Bug#856350: qutemol: FTBFS (#error This file requires compiler and library support)

[Olly Betts]

On Tue, Feb 28, 2017 at 06:57:43PM +0200, Adrian Bunk wrote:
> This is caused by the recent binNMU (sic) of wxwidgets3.0,
> that resulted in wx3.0-headers requiring a C++11 compiler
> (first rebuild with gcc 6 that defaults to C++11).
> 
> This breaks building of qutemol (and potentially other rdeps) that are 
> building with -std=gnu++98 to avoid C++11 FTBFS.
> 
> This should really be fixed in rdeps like qutemol, but since we
> are already inside the freeze I'd suggest the following change to 
> wxwidgets3.0 for stretch:

> -$(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed dpkg-buildflags 
> --export=configure)
> +$(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed 
> DEB_CXXFLAGS_MAINT_APPEND=-std=gnu++98 dpkg-buildflags --export=configure)

That seems sensible to me - it should actually be closer to the
pre-binNMU state.

Cheers,
Olly

Bug#856350: qutemol: FTBFS (#error This file requires compiler and library support)

[Adrian Bunk]

Control: clone -1 -2
Control: reassign -2 wx3.0-headers 3.0.2+dfsg-2
Control: retitle -2 wx3.0-headers shouldn't require C+11 in stretch
Control: affects -2 src:qutemol
Control: tags -2 patch
Control: retitle -1 qutemol must be made C++11 compatible
Control: severity -1 important

On Tue, Feb 28, 2017 at 11:23:28AM +, Santiago Vila wrote:
> Package: src:qutemol
> Version: 0.4.1~cvs2008-6
>...
> g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
> -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
> -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
> -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
> src/MyTab.o src/MyTab.cpp
> In file included from /usr/include/c++/6/type_traits:35:0,
>  from /usr/include/wx-3.0/wx/strvararg.h:25,
>  from /usr/include/wx-3.0/wx/string.h:46,
>  from /usr/include/wx-3.0/wx/memory.h:15,
>  from /usr/include/wx-3.0/wx/object.h:19,
>  from /usr/include/wx-3.0/wx/wx.h:15,
>  from src/MyTab.cpp:2:
> /usr/include/c++/6/bits/c++0x_warning.h:32:2: error: #error This file 
> requires compiler and library support for the ISO C++ 2011 standard. This 
> support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
>  #error This file requires compiler and library support \
>   ^
>...

This is caused by the recent binNMU (sic) of wxwidgets3.0,
that resulted in wx3.0-headers requiring a C++11 compiler
(first rebuild with gcc 6 that defaults to C++11).

This breaks building of qutemol (and potentially other rdeps) that are 
building with -std=gnu++98 to avoid C++11 FTBFS.

This should really be fixed in rdeps like qutemol, but since we
are already inside the freeze I'd suggest the following change to 
wxwidgets3.0 for stretch:

--- debian/rules.old2017-02-28 16:23:38.0 +
+++ debian/rules2017-02-28 16:24:09.0 +
@@ -69,7 +69,7 @@
 --with-flavour=$(DEBIAN_WXFLAVOUR) \
 --with-zlib=sys \
 --with-expat=sys \
-$(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed dpkg-buildflags 
--export=configure)
+$(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed 
DEB_CXXFLAGS_MAINT_APPEND=-std=gnu++98 dpkg-buildflags --export=configure)
 
 ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
 COMMON_CONFIGURE_OPTIONS += --disable-optimise


cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#856350: qutemol: FTBFS (#error This file requires compiler and library support)

[Santiago Vila]

Package: src:qutemol
Version: 0.4.1~cvs2008-6
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -B"
but it failed:


[...]
 debian/rules build-arch
test -x debian/rules
mkdir -p "."
/usr/bin/make -C . CFLAGS="-g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security" 
CXXFLAGS="-DPKGDATADIR='\"/usr/share/qutemol\"' -Ivcg -Isrc -I. `wx-config 
--cppflags` -DNDEBUG `dpkg-buildflags --get CXXFLAGS` -std=gnu++98" 
CPPFLAGS="-Wdate-time -D_FORTIFY_SOURCE=2" LDFLAGS="-Wl,-z,relro" 
make[1]: Entering directory '/<>'
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/AO.o src/AO.cpp
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/AOgpu.o src/AOgpu.cpp
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/AtomColor.o src/AtomColor.cpp
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/CgUtil.o src/CgUtil.cpp
src/CgUtil.cpp: In member function 'bool CgUtil::Load(const char*)':
src/CgUtil.cpp:42:345: warning: ignoring return value of 'int fscanf(FILE*, 
const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]

,_light_base,_lighting,_phong,_phong_size,_col_atoms_sat,_col_atoms_bri,_texture,_border_inside,_border_outside,_depth_full,_sem_effect,_halo_size,_halo_col,_halo_str,_halo_aware,_fog,_capping,_shadowstrenght,_bg_color_R,_bg_color_G,_bg_color_B,_normalize,_double_shadows,_border_fixed);




 ^
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/Common.o src/Common.cpp
src/Common.cpp: In function 'Byte* GetSnapshot(int, int, bool)':
src/Common.cpp:155:30: warning: non-constant array new length must be specified 
without parentheses around the type-id [-Wvla]
   Byte* res=new(Byte[sx*sy*4]);
  ^
src/Common.cpp: In function 'bool LoadImagePPM(const char*, 
std::vector&)':
src/Common.cpp:1177:29: warning: ignoring return value of 'size_t fread(void*, 
size_t, size_t, FILE*)', declared with attribute warn_unused_result 
[-Wunused-result]
 fread(&(im[k++]),1,1,fp);
 ^
src/Common.cpp:1178:29: warning: ignoring return value of 'size_t fread(void*, 
size_t, size_t, FILE*)', declared with attribute warn_unused_result 
[-Wunused-result]
 fread(&(im[k++]),1,1,fp);
 ^
src/Common.cpp:1179:29: warning: ignoring return value of 'size_t fread(void*, 
size_t, size_t, FILE*)', declared with attribute warn_unused_result 
[-Wunused-result]
 fread(&(im[k++]),1,1,fp);
 ^
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
src/HardSettings.o src/HardSettings.cpp
g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. 
-I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 
-D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2