Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-11 Thread Ruben Undheim 
Hi,

I have retitled the unblock bug to match the new version.

The full diff is attached (generated with "git diff -M" to get clever
rename detection).

This now fixes 2 RC bugs:
 #856705
 #857088

Best regards
Ruben


updated.gitdiff
Description: Binary data

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-07 Thread Ruben Undheim 
> I've sponsored the upload for you (I pushed the finalised changelog and
> signed tag to VCS). Finalised debdiff (and "gitdiff" since it's smart
> about moved files) attached.

Thank you VERY much, James!
This is highly appreciated.

I wish you all the best!


Best regards,
Ruben

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-07 Thread James Clarke 
On Tue, Mar 07, 2017 at 10:17:57AM +0100, Ruben Undheim wrote:
> Hi,
> 
> I have prepared a new package with the ABI bump.
> See attachment for full debdiff.
> 
> Since I am restricted on time to put into this now, I would appreciate if
> someone could please upload this for me (I am not allowed to upload NEW
> binary packages).
> 
> The package has been uploaded to Mentors, and is also checked
> into Vcs on alioth.

Hi,
I've sponsored the upload for you (I pushed the finalised changelog and
signed tag to VCS). Finalised debdiff (and "gitdiff" since it's smart
about moved files) attached.

Thanks,
James
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/changelog 
graywolf-0.1.4+20170307gite1bf319/debian/changelog
--- graywolf-0.1.4+20170306gitecee764/debian/changelog  2017-03-06 
21:00:54.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/changelog  2017-03-07 
20:40:23.0 +
@@ -1,3 +1,10 @@
+graywolf (0.1.4+20170307gite1bf319-1) unstable; urgency=medium
+
+  * New upstream GIT HEAD with bumped SOVERSION and major version
+  * New binary package libycadgraywolf1
+
+ -- Ruben Undheim   Tue, 07 Mar 2017 20:40:23 +
+
 graywolf (0.1.4+20170306gitecee764-1) unstable; urgency=medium
 
   * New upstream GIT HEAD with fixed license violation issue (Closes: #856705)
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/control 
graywolf-0.1.4+20170307gite1bf319/debian/control
--- graywolf-0.1.4+20170306gitecee764/debian/control2017-03-06 
21:00:54.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/control2017-03-07 
20:40:23.0 +
@@ -13,7 +13,7 @@
 Vcs-Git: https://anonscm.debian.org/git/debian-science/packages/graywolf.git
 Homepage: https://github.com/rubund/graywolf
 
-Package: libycadgraywolf0
+Package: libycadgraywolf1
 Architecture: any
 Section: libs
 Depends: ${shlibs:Depends},
@@ -29,7 +29,7 @@
 Package: libycadgraywolf-dev
 Architecture: any
 Section: libdevel
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${misc:Depends}
 Multi-Arch: same
 Description: Library for graywolf - development files
@@ -38,14 +38,14 @@
  .
  This is the development files for the library.
 
-Package: libycadgraywolf0-dbg
+Package: libycadgraywolf1-dbg
 Architecture: any
 Section: debug
 Priority: extra
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${misc:Depends}
 Multi-Arch: same
-Description: debug symbols for libycadgraywolf0
+Description: debug symbols for libycadgraywolf1
  This library contains functions shared by the graywolf binaries
  found in the /usr/lib/graywolf/bin/ directory.
  .
@@ -53,7 +53,7 @@
 
 Package: graywolf
 Architecture: any
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${shlibs:Depends},
  ${misc:Depends}
 Recommends: qflow
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.install 
graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.install
--- graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.install   
2017-03-06 20:29:50.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.install   
1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols 
graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.symbols
--- graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols   
2017-03-06 21:00:54.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.symbols   
1970-01-01 01:00:00.0 +0100
@@ -1,410 +0,0 @@
-libycadgraywolf.so.0 libycadgraywolf0 #MINVER#
- TW3DdrawCube@Base 0.1.1
- TW3Dnormal_view@Base 0.1.1
- TW3Dperspective@Base 0.1.1
- TW3DperspectiveOff@Base 0.1.1
- TW3DperspectiveOn@Base 0.1.1
- TW3DsetCamera@Base 0.1.1
- TWarb_addpt@Base 0.1.1
- TWarb_fill@Base 0.1.1
- TWarb_init@Base 0.1.1
- TWcheckExposure@Base 0.1.1
- TWcheckMouse@Base 0.1.1
- TWcheckReconfig@Base 0.1.1
- TWcheckServer@Base 0.1.1
- TWcloseGraphics@Base 0.1.1
- TWcloseWGraphics@Base 0.1.1
- TWcolorXOR@Base 0.1.1
- TWdialog@Base 0.1.1
- TWdisableMenu@Base 0.1.1
- TWdrawMenus@Base 0.1.1
- TWdrawString@Base 0.1.1
- TWdrawWLine@Base 0.1.1
- TWdrawWPin@Base 0.1.1
- TWdrawWRect@Base 0.1.1
- TWenableMenu@Base 0.1.1
- TWflushFrame@Base 0.1.1
- TWflushWFrame@Base 0.1.1
- TWforceRedraw@Base 0.1.1
- TWfreeMenuWindows@Base 0.1.1
- TWfullView@Base 0.1.1
- TWgetDrawInfo@Base 0.1.1
- TWgetPt2@Base 0.1.1
- TWgetPt@Base 0.1.1
- TWgetString@Base 0.1.1
- TWgetWindowId@Base 0.1.1
- TWget_arb_fill@Base 0.1.1
- TWget_rect_fill@Base 0.1.1
- TWgetfont@Base 0.1.1
- TWhighLightRect@Base 0.1.1
- TWinforMenus@Base 0.1.1
- TWinitGraphics@Base 0.1.1
- TWinitMenuWindow@Base 0.1.1
- TWinitParasite@Base 0.1.1
- TWinitWGraphics@Base 0.1.1
- TWinterupt@Base 0.1.1
- TWmessage@Base 0.1.1
- TWmessagePersistence@Base

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-07 Thread Ruben Undheim 
Hi,

I have prepared a new package with the ABI bump.
See attachment for full debdiff.

Since I am restricted on time to put into this now, I would appreciate if
someone could please upload this for me (I am not allowed to upload NEW
binary packages).

The package has been uploaded to Mentors, and is also checked
into Vcs on alioth.


Cheers
Ruben

diff -Nru graywolf-0.1.4+20170306gitecee764/debian/changelog 
graywolf-0.1.4+20170307gite1bf319/debian/changelog
--- graywolf-0.1.4+20170306gitecee764/debian/changelog  2017-03-06 
19:48:51.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/changelog  2017-03-07 
08:13:26.0 +
@@ -1,4 +1,11 @@
-graywolf (0.1.4+20170306gitecee764-1) UNRELEASED; urgency=medium
+graywolf (0.1.4+20170307gite1bf319-1) UNRELEASED; urgency=medium
+
+  * New upstream GIT HEAD with bumped SOVERSION and major version
+  * New binary package libycadgraywolf1
+
+ -- Ruben Undheim   Tue, 07 Mar 2017 09:13:26 +0100
+
+graywolf (0.1.4+20170306gitecee764-1) unstable; urgency=medium
 
   * New upstream GIT HEAD with fixed license violation issue (Closes: #856705)
   * debian/control:
@@ -6,7 +13,7 @@
   * Updated debian/libycadgraywolf0.symbols - removed the symbols in license
 violating code.
 
- -- Ruben Undheim   Mon, 06 Mar 2017 19:48:51 +
+ -- Ruben Undheim   Mon, 06 Mar 2017 20:26:57 +
 
 graywolf (0.1.4-1) unstable; urgency=low
 
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/control 
graywolf-0.1.4+20170307gite1bf319/debian/control
--- graywolf-0.1.4+20170306gitecee764/debian/control2017-03-06 
19:48:51.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/control2017-03-07 
08:13:26.0 +
@@ -13,7 +13,7 @@
 Vcs-Git: https://anonscm.debian.org/git/debian-science/packages/graywolf.git
 Homepage: https://github.com/rubund/graywolf
 
-Package: libycadgraywolf0
+Package: libycadgraywolf1
 Architecture: any
 Section: libs
 Depends: ${shlibs:Depends},
@@ -29,7 +29,7 @@
 Package: libycadgraywolf-dev
 Architecture: any
 Section: libdevel
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${misc:Depends}
 Multi-Arch: same
 Description: Library for graywolf - development files
@@ -38,14 +38,14 @@
  .
  This is the development files for the library.
 
-Package: libycadgraywolf0-dbg
+Package: libycadgraywolf1-dbg
 Architecture: any
 Section: debug
 Priority: extra
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${misc:Depends}
 Multi-Arch: same
-Description: debug symbols for libycadgraywolf0
+Description: debug symbols for libycadgraywolf1
  This library contains functions shared by the graywolf binaries
  found in the /usr/lib/graywolf/bin/ directory.
  .
@@ -53,7 +53,7 @@
 
 Package: graywolf
 Architecture: any
-Depends: libycadgraywolf0 (= ${binary:Version}),
+Depends: libycadgraywolf1 (= ${binary:Version}),
  ${shlibs:Depends},
  ${misc:Depends}
 Recommends: qflow
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.install 
graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.install
--- graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.install   
2017-03-06 19:48:51.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.install   
1970-01-01 00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols 
graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.symbols
--- graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols   
2017-03-06 19:48:51.0 +
+++ graywolf-0.1.4+20170307gite1bf319/debian/libycadgraywolf0.symbols   
1970-01-01 00:00:00.0 +
@@ -1,410 +0,0 @@
-libycadgraywolf.so.0 libycadgraywolf0 #MINVER#
- TW3DdrawCube@Base 0.1.1
- TW3Dnormal_view@Base 0.1.1
- TW3Dperspective@Base 0.1.1
- TW3DperspectiveOff@Base 0.1.1
- TW3DperspectiveOn@Base 0.1.1
- TW3DsetCamera@Base 0.1.1
- TWarb_addpt@Base 0.1.1
- TWarb_fill@Base 0.1.1
- TWarb_init@Base 0.1.1
- TWcheckExposure@Base 0.1.1
- TWcheckMouse@Base 0.1.1
- TWcheckReconfig@Base 0.1.1
- TWcheckServer@Base 0.1.1
- TWcloseGraphics@Base 0.1.1
- TWcloseWGraphics@Base 0.1.1
- TWcolorXOR@Base 0.1.1
- TWdialog@Base 0.1.1
- TWdisableMenu@Base 0.1.1
- TWdrawMenus@Base 0.1.1
- TWdrawString@Base 0.1.1
- TWdrawWLine@Base 0.1.1
- TWdrawWPin@Base 0.1.1
- TWdrawWRect@Base 0.1.1
- TWenableMenu@Base 0.1.1
- TWflushFrame@Base 0.1.1
- TWflushWFrame@Base 0.1.1
- TWforceRedraw@Base 0.1.1
- TWfreeMenuWindows@Base 0.1.1
- TWfullView@Base 0.1.1
- TWgetDrawInfo@Base 0.1.1
- TWgetPt2@Base 0.1.1
- TWgetPt@Base 0.1.1
- TWgetString@Base 0.1.1
- TWgetWindowId@Base 0.1.1
- TWget_arb_fill@Base 0.1.1
- TWget_rect_fill@Base 0.1.1
- TWgetfont@Base 0.1.1
- TWhighLightRect@Base 0.1.1
- TWinforMenus@Base 0.1.1
- TWinitGraphics@Base 0.1.1
-

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-07 Thread Ruben Undheim 
> It drops symbols so effectively this includes a transition.

I am aware of this. This reason I did not think an ABI bump would be
necessary in this case, is that these symbols anyway cannot be used
since the code behind violates the license.

> This upload will need an ABI bump - preferably the same as upstream, but
given they haven't released this version yet, it is not certain we can
reuse that bump (in case they want to remove/change more symbols).

I am also upstream, so in general this would not be a problem.

The only complication I see is that I, as a Debian Maintainer, will
need a sponsor to get the NEW binary package libycadgraywolf1
uploaded.
I can bump the ABI upstream, and prepare a new package.

Cheers,
Ruben


2017-03-07 9:00 GMT+01:00 Niels Thykier :
> Niels Thykier:
>> [...]
>>
>> It drops symbols so effectively this includes a transition.  Only one
>> rdep (qflow) with same maintainer.  I cannot tell if it uses the symbols
>> (codesearch.d.n does not respond to the search and I don't have time to
>> check manually).
>>
>> I believe we need an ABI bump for this.  Will check up and get back to you.
>>
>> ~Niels
>>
>>
>
> Hi Ruben,
>
> This upload will need an ABI bump - preferably the same as upstream, but
> given they haven't released this version yet, it is not certain we can
> reuse that bump (in case they want to remove/change more symbols).
>
> If you have questions about how to perform the ABI bump, please feel
> free to ask on debian-mentors@l.d.o (or #debian-mentors, if you are on IRC).
>
> Thanks,
> ~Niels
>
>

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-07 Thread Niels Thykier 
Niels Thykier:
> [...]
> 
> It drops symbols so effectively this includes a transition.  Only one
> rdep (qflow) with same maintainer.  I cannot tell if it uses the symbols
> (codesearch.d.n does not respond to the search and I don't have time to
> check manually).
> 
> I believe we need an ABI bump for this.  Will check up and get back to you.
> 
> ~Niels
> 
> 

Hi Ruben,

This upload will need an ABI bump - preferably the same as upstream, but
given they haven't released this version yet, it is not certain we can
reuse that bump (in case they want to remove/change more symbols).

If you have questions about how to perform the ABI bump, please feel
free to ask on debian-mentors@l.d.o (or #debian-mentors, if you are on IRC).

Thanks,
~Niels

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-06 Thread Niels Thykier 
~Ruben Undheim:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Please unblock package graywolf
> 
> Needed to fix release critical license violation. (#856705)
> Basically two files (with license violation) are removed from upstream source.
> Then the code is adapted to use libgsl instead.
> 
> 
> Complete debdiff attached.
> 
> 
> unblock graywolf/0.1.4+20170306gitecee764-1
> 
> [...]

It drops symbols so effectively this includes a transition.  Only one
rdep (qflow) with same maintainer.  I cannot tell if it uses the symbols
(codesearch.d.n does not respond to the search and I don't have time to
check manually).

I believe we need an ABI bump for this.  Will check up and get back to you.

~Niels

Bug#856986: unblock: graywolf/0.1.4+20170306gitecee764-1

2017-03-06 Thread Ruben Undheim 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package graywolf

Needed to fix release critical license violation. (#856705)
Basically two files (with license violation) are removed from upstream source.
Then the code is adapted to use libgsl instead.


Complete debdiff attached.


unblock graywolf/0.1.4+20170306gitecee764-1

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru graywolf-0.1.4/CMakeLists.txt 
graywolf-0.1.4+20170306gitecee764/CMakeLists.txt
--- graywolf-0.1.4/CMakeLists.txt   2016-10-06 22:10:19.0 +0200
+++ graywolf-0.1.4+20170306gitecee764/CMakeLists.txt2017-03-06 
20:47:22.0 +0100
@@ -1,8 +1,16 @@
 cmake_minimum_required (VERSION 2.6)
 project (graywolf)
 
+find_package(PkgConfig)
 INCLUDE(CheckIncludeFiles)
 
+
+pkg_check_modules(GSL gsl)
+
+if (NOT GSL_FOUND)
+  MESSAGE(FATAL_ERROR "The development files for the GNU Scientific Library 
(libgsl) are required to build graywolf.")
+endif()
+
 # Include RPATH in build so that ldconfig is not necessary after install
 SET(CMAKE_SKIP_BUILD_RPATH FALSE)
 SET(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)
diff -Nru graywolf-0.1.4/debian/changelog 
graywolf-0.1.4+20170306gitecee764/debian/changelog
--- graywolf-0.1.4/debian/changelog 2016-10-06 22:20:06.0 +0200
+++ graywolf-0.1.4+20170306gitecee764/debian/changelog  2017-03-06 
20:48:51.0 +0100
@@ -1,3 +1,13 @@
+graywolf (0.1.4+20170306gitecee764-1) unstable; urgency=medium
+
+  * New upstream GIT HEAD with fixed license violation issue (Closes: #856705)
+  * debian/control:
+- New build-dependencies: libgsl-dev, pkg-config
+  * Updated debian/libycadgraywolf0.symbols - removed the symbols in license
+violating code.
+
+ -- Ruben Undheim   Mon, 06 Mar 2017 19:48:51 +
+
 graywolf (0.1.4-1) unstable; urgency=low
 
   * New upstream release
diff -Nru graywolf-0.1.4/debian/control 
graywolf-0.1.4+20170306gitecee764/debian/control
--- graywolf-0.1.4/debian/control   2016-10-06 22:20:06.0 +0200
+++ graywolf-0.1.4+20170306gitecee764/debian/control2017-03-06 
20:48:51.0 +0100
@@ -5,7 +5,9 @@
 Priority: optional
 Build-Depends: debhelper (>= 9),
cmake,
-   libx11-dev
+   pkg-config,
+   libx11-dev,
+   libgsl-dev
 Standards-Version: 3.9.8
 Vcs-Browser: 
https://anonscm.debian.org/cgit/debian-science/packages/graywolf.git
 Vcs-Git: https://anonscm.debian.org/git/debian-science/packages/graywolf.git
diff -Nru graywolf-0.1.4/debian/libycadgraywolf0.symbols 
graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols
--- graywolf-0.1.4/debian/libycadgraywolf0.symbols  2016-10-06 
22:20:06.0 +0200
+++ graywolf-0.1.4+20170306gitecee764/debian/libycadgraywolf0.symbols   
2017-03-06 20:48:51.0 +0100
@@ -267,17 +267,6 @@
  Ylist_sort@Base 0.1.1
  Ylog_msg@Base 0.1.1
  Ylog_start@Base 0.1.1
- Ymatrix_cofactors@Base 0.1.1
- Ymatrix_copy@Base 0.1.1
- Ymatrix_create@Base 0.1.1
- Ymatrix_disp@Base 0.1.1
- Ymatrix_eye@Base 0.1.1
- Ymatrix_free@Base 0.1.1
- Ymatrix_linv@Base 0.1.1
- Ymatrix_mult@Base 0.1.1
- Ymatrix_sub@Base 0.1.1
- Ymatrix_transpose@Base 0.1.1
- Ymatrix_zero@Base 0.1.1
  Ymessage_close@Base 0.1.1
  Ymessage_error_count@Base 0.1.1
  Ymessage_flush@Base 0.1.1
@@ -389,8 +378,6 @@
  Ystat_var@Base 0.1.1
  Ystrclone@Base 0.1.1
  Ystrparser@Base 0.1.1
- Ysvd_decompose@Base 0.1.1
- Ysvd_solve@Base 0.1.1
  Ysystem@Base 0.1.1
  Ytimer_elapsed@Base 0.1.1
  Ytimer_start@Base 0.1.1
diff -Nru graywolf-0.1.4/debian/patches/01_no_rpath_in_debian_package.patch 
graywolf-0.1.4+20170306gitecee764/debian/patches/01_no_rpath_in_debian_package.patch
--- graywolf-0.1.4/debian/patches/01_no_rpath_in_debian_package.patch   
2016-10-06 22:20:06.0 +0200
+++ 
graywolf-0.1.4+20170306gitecee764/debian/patches/01_no_rpath_in_debian_package.patch
2017-03-06 20:48:51.0 +0100
@@ -8,13 +8,13 @@
  CMakeLists.txt | 10 +-
  1 file changed, 5 insertions(+), 5 deletions(-)
 
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 10e2b22..b8b6444 100644
 a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -3,11 +3,11 @@ project (graywolf)
- 
- INCLUDE(CheckIncludeFiles)
+Index: graywolf/CMakeLists.txt
+===
+--- graywolf.orig/CMakeLists.txt
 graywolf/CMakeLists.txt
+@@ -11,11 +11,11 @@ if (NOT GSL_FOUND)
+   MESSAGE(FATAL_ERROR "The development files for the GNU Scientific Library 
(libgsl) are required to build graywolf.")
+ endif()
  
 -# Include RPATH in build so that ldconfig is not necessary