Bug#857454: qtltools: please make the build reproducible
Hi Chris, On Mon, 12 Oct 2020 16:58:03 - "Chris Lamb" wrote: > > Friendly ping on this? > This package seems now reproducible. Could you confirm? Best, Dylan
Bug#857454: qtltools: please make the build reproducible
Chris Lamb wrote: > [..] Friendly ping on this? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#857454: qtltools: please make the build reproducible
reopen 857454 found 857454 1.2+dfsg-2 thanks Hi, I'm afraid this has regressed again (or I forgot to properly re-open): │ ├── data.tar.xz │ │ ├── data.tar │ │ │ ├── file list │ │ │ │ @@ -1,14 +1,14 @@ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/share/ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/share/doc/ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools/ │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools/examples/ │ │ │ │ --rw-r--r-- 0 root (0) root (0) 13549832 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools/examples/examples.tar.xz │ │ │ │ +-rw-r--r-- 0 root (0) root (0) 13550168 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools/examples/examples.tar.xz │ │ │ │ -rw-r--r-- 0 root (0) root (0) 1675 2019-09-16 09:56:58.00 ./usr/share/doc/qtltools/examples/plotTrans.R │ │ │ │ -rw-r--r-- 0 root (0) root (0) 1317 2019-12-25 14:43:38.00 ./usr/share/doc/qtltools/examples/run-sample-analysis │ │ │ │ -rw-r--r-- 0 root (0) root (0) 1020 2019-09-16 09:56:58.00 ./usr/share/doc/qtltools/examples/runFDR_atrans.R │ │ │ │ -rw-r--r-- 0 root (0) root (0) 2780 2019-09-16 09:56:58.00 ./usr/share/doc/qtltools/examples/runFDR_cis.R │ │ │ │ -rw-r--r-- 0 root (0) root (0) 787 2019-09-16 09:56:58.00 ./usr/share/doc/qtltools/examples/runFDR_ftrans.R │ │ │ │ drwxr-xr-x 0 root (0) root (0)0 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools-example/ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 770 2019-12-25 21:27:16.00 ./usr/share/doc/qtltools-example/changelog.Debian.gz │ │ │ ├── ./usr/share/doc/qtltools/examples/examples.tar.xz │ │ │ │ ├── examples.tar │ │ │ │ │ ├── file list │ │ │ │ │ │ @@ -1,7 +1,8 @@ │ │ │ │ │ │ +-rw-r--r-- 0000 2020-07-11 21:44:22.00 ./examples.tar.xz │ │ │ │ │ │ -rw-r--r-- 000 1230243 2019-12-25 14:43:38.00 ./genes.50percent.chr22.bed.gz ie. the examples.tar.xz can contain "itself" in the second build. https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/qtltools.html Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#857454: qtltools: please make the build reproducible
Hi Andreas, > > This appears to have reoccured: […] > As Michael explained this is not the case in his recent upload > any more. Thanks for fixing. However, I think I'm missing something as I do not see this aforementioned explanation on #857454? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Bug#857454: qtltools: please make the build reproducible
reopen 857454 found 857454 1.2+dfsg-1 thanks Hi, This appears to have reoccured: │ │ │ ├── ./usr/share/doc/qtltools/examples/examples.tar.xz │ │ │ │ ├── examples.tar │ │ │ │ │ ├── file list │ │ │ │ │ │ @@ -1,8 +1,7 @@ │ │ │ │ │ │ --rw-r--r-- 0000 2019-12-28 13:56:00.00 ./examples.tar.xz │ │ │ │ │ │ -rw-r--r-- 000 1230243 2019-09-30 21:26:57.00 ./genes.50percent.chr22.bed.gz │ │ │ │ │ │ -rw-r--r-- 000 4634 2019-09-30 21:26:57.00 ./genes.50percent.chr22.bed.gz.tbi ie. the examples.tar.xz can include itself. My previous patch has still been applied so I wonder what has changed upstream (or in the toolchain) that could have caused this regression. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#857454: qtltools: please make the build reproducible
Source: qtltools Version: 1.1+dfsg-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: randomness X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that qtltools could not be built reproducibly. This is because the examples.tar.xz can contain itself: ├── ./usr/share/doc/qtltools/examples/examples.tar.xz ├── 6-content ├── file list │ │ │ │ │ │ @@ -1,7 +1,8 @@ │ │ │ │ │ │ +-rw-r--r-- 0000 2018-03-21 07:15:07.00 ./examples.tar.xz Patch attached; we should be removing this file in the clean target anyway. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- diff --git a/debian/rules b/debian/rules index cc7f05e..2b25c1a 100755 --- a/debian/rules +++ b/debian/rules @@ -11,6 +11,10 @@ override_dh_auto_build: mkdir -p $(CURDIR)/bin/ dh_auto_build +override_dh_auto_clean: + rm -f debian/upstream.example/examples.tar.xz + dh_auto_clean + override_dh_install: cd debian/upstream.example && find -type f | LC_ALL=C sort | tar -T - --sort=name --mode=go=rX,u+rw,a-s --owner=root --group=root --numeric-owner -Jcvf examples.tar.xz dh_install
