Bug#859594: git-buildpackage: Suggested clean command is incorrect
At 06:27 p.m. 5/04/2017, Guido Günther wrote: >> Also, according to >>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846016 >> this is no longer valid syntax and needs to be changed to >> "debuild -- clean". > >Having a cleaner by default would force people to set up two things >if they want to switch builders (with the exception of >--git-pbuilder which does this for you). Since most people use >either sbuild, pbuilder or --export-dir there's no point in running >"debuild -- clean" or any other builder. Perhaps just update the manpage then? And have a bit more info about the recommended way to run it? (Using pbuilder isn't mentioned until an appendix in the wiki page.)
Bug#859594: git-buildpackage: Suggested clean command is incorrect
Hi Gavin, On Wed, Apr 05, 2017 at 04:56:21AM +, Gavin Lambert wrote: > Package: git-buildpackage > Version: 0.8.12.2 > Severity: minor > > Dear Maintainer, > > "man gbp-buildpackage" seems to imply that "gbp buildpackage" will issue > "debuild clean" by default. It doesn't actually do so; it calls > /bin/true instead. > > Also, according to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846016 > this is no longer valid syntax and needs to be changed to "debuild -- clean". > > When it doesn't clean by default, two successive calls to "gbp buildpackage" > with default configuration results in the second call failing due to dpkg > output files left behind by the first call (resulting in a "git status" > error output), unless the repository already contains .gitignore files that > cover those files. Is it assumed that this is always the case? Having a cleaner by default would force people to set up two things if they want to switch builders (with the exception of --git-pbuilder which does this for you). Since most people use either sbuild, pbuilder or --export-dir there's no point in running "debuild -- clean" or any other builder. We should have a better default for --git-builder (which can happen once git-pbuilder is clever enough to build the chroot if missing). Cheers, -- Guido
Bug#859594: git-buildpackage: Suggested clean command is incorrect
Package: git-buildpackage Version: 0.8.12.2 Severity: minor Dear Maintainer, "man gbp-buildpackage" seems to imply that "gbp buildpackage" will issue "debuild clean" by default. It doesn't actually do so; it calls /bin/true instead. Also, according to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846016 this is no longer valid syntax and needs to be changed to "debuild -- clean". When it doesn't clean by default, two successive calls to "gbp buildpackage" with default configuration results in the second call failing due to dpkg output files left behind by the first call (resulting in a "git status" error output), unless the repository already contains .gitignore files that cover those files. Is it assumed that this is always the case? -- System Information: Debian Release: 9.0 APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.4.0-70-generic (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages git-buildpackage depends on: ii devscripts2.17.2 ii git 1:2.11.0-2 ii man-db2.7.6.1-2 ii python-dateutil 2.5.3-2 ii python-pkg-resources 33.1.1-1 ii python-six1.10.0-3 pn python:any Versions of packages git-buildpackage recommends: ii cowbuilder 0.85 ii pbuilder 0.228.6 ii pristine-tar 1.38 ii python-requests 2.12.4-1 Versions of packages git-buildpackage suggests: pn python-notify ii sudo 1.8.19p1-1 ii unzip 6.0-21 -- no debconf information