Bug#860522: selinux-basics: check-selinux-installation fails without initscripts

[Christian Göttsche]

Control: severity -1 important
Control: tags -1 patch
--- 24_fsckfix.py.bak	2019-10-03 12:17:11.553338016 +0200
+++ 24_fsckfix.py	2019-10-03 12:18:34.184342097 +0200
@@ -20,7 +20,9 @@
 			f.close()
 			if not fsckfix:
 return [TestFSCKFix.ErrorFSCKFix()]
+		elif os.access("/run/systemd/system", os.F_OK):
+			return []
 		else:
-			raise IOError("/etc/default/rcS not found, is this Debian?")
+			raise IOError("/etc/default/rcS nor /run/systemd/system found, is this Debian?")
 		return []
 register_test(TestFSCKFix)

Bug#860522: selinux-basics: check-selinux-installation fails without initscripts

[Tobias Wolter]

Yup, I'll confirm this one as well. Script doesn't work on an OOTB
Strech.

-towo


signature.asc
Description: PGP signature

Bug#860522: selinux-basics: check-selinux-installation fails without initscripts

[Gert]

Package: selinux-basics
Version: 0.5.6
Severity: normal

check-selinux-installation runs /usr/share/selinux-basics/tests/24_fsckfix.py
That looks at /etc/default/rcS, which belongs to initscripts.
But I use systemd and don't have/need initscripts, so it errors out before
doing other (relevant) tests.

root@v:~# check-selinux-installation ; echo $?
Traceback (most recent call last):
  File "/usr/sbin/check-selinux-installation", line 33, in 
results += test.test()
  File "/usr/share/selinux-basics/tests/24_fsckfix.py", line 24, in test
raise IOError("/etc/default/rcS not found, is this Debian?")
OSError: /etc/default/rcS not found, is this Debian?
1
root@v:~# rm /usr/share/selinux-basics/tests/24_fsckfix.py
root@v:~# check-selinux-installation ; echo $?
Postfix init script is syncing the chroots.
Postfix has chrooted service in master.cf
0
root@v:~#



-- System Information:
Debian Release: 9.0
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages selinux-basics depends on:
ii  checkpolicy  2.6-2
pn  perl:any 
ii  policycoreutils  2.6-3
pn  python3:any  
ii  selinux-utils2.6-3+b1

Versions of packages selinux-basics recommends:
pn  policycoreutils-python-utils  
ii  selinux-policy-default2:2.20161023.1-9
pn  setools   

Versions of packages selinux-basics suggests:
pn  logcheck
pn  syslog-summary  

-- no debconf information