Bug#861153: [Reportbug-maint] Bug#861153: reportbug: Architecture field split into two lines

[Sandro Tosi]

On Sun, May 28, 2017 at 6:53 AM, Nis Martensen  wrote:
> Hey Sandro!
>
>> should we revert to the previous behavior of get_command_output before
>> introducing other regressions?
>
> Having re-read the code again, I can't see any risk of introducing other
> regressions.

all good, just checking :)

we may also need to look at the test suite (`make tests`), some of
those are broken after 7.1.6 (and in general let's try to keep that in
sync with new code and assess that these new bugs are fixed in the
testsuite)

i'm gonna merge & upload this patch and several other soon!

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Bug#861153: [Reportbug-maint] Bug#861153: reportbug: Architecture field split into two lines

[Nis Martensen]

Hey Sandro!

> should we revert to the previous behavior of get_command_output before
> introducing other regressions?

Having re-read the code again, I can't see any risk of introducing other
regressions.

Only lsb_release_info() and get_arch() directly return the result of
get_command_output(), all other callers do some parsing and do not care
about newlines at the end of the output.

The alternative you have in mind is changing get_command_output like
this, right? :

-return subprocess.run([...]).stdout.decode([...])
+return subprocess.run([...]).stdout.decode([...]).strip()

This will work as well. I slightly prefer my other patch, but it does
not matter much.

Bug#861153: [Reportbug-maint] Bug#861153: reportbug: Architecture field split into two lines

[Sandro Tosi]

Hey Nis!

On Tue, Apr 25, 2017 at 5:56 PM, Nis Martensen  wrote:
> Let's fix this before we find out exactly what else was broken by my
> patch in reportbug 7.1.6.

should we revert to the previous behavior of get_command_output before
introducing other regressions?

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi