Bug#863045: at: interactively please print parsed time at start

[Daniel Shahaf]

Jose M Calhariz wrote on Wed, 17 Jul 2019 19:09 +00:00:
> as promised is here the patch.  This is a draft so you can look into
> the new message and say if you aprove it.  The code is not optimized,
> so I may change it a bit.
> 
> +++ b/at.c
> @@ -479,6 +479,11 @@ writefile(time_t runtimer, char queue)
>  
>  istty = isatty(fileno(stdin));
>  if (istty) {
> +   runtime = localtime(&runtimer);
> +
> +   strftime(timestr, TIMESIZE, TIMEFORMAT_POSIX, runtime);
> +   fprintf(stderr, "at %s\n", timestr);
> +
> fprintf(stderr, "at> ");
> fflush(stderr);
>  }

Tested.  Looks good to me.  Thank you!

Bug#863045: at: interactively please print parsed time at start

[Jose M Calhariz]

Hi,

as promised is here the patch.  This is a draft so you can look into
the new message and say if you aprove it.  The code is not optimized,
so I may change it a bit.

Kind regards
Jose M Calhariz

diff --git a/ChangeLog b/ChangeLog
index 2300d1a..b013595 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -199,3 +199,7 @@ at 3.1.22 (2018-07-24):
 at 3.1.23 (2018-07-24):
   Jose M Calhariz
Finalised script to release software.
+
+at 3.1.24~WIP
+  Jose M Calhariz
+   Print time of new job before the input of the commands, Closes #863045
diff --git a/at.c b/at.c
index 2136e0b..4d88dcb 100644
--- a/at.c
+++ b/at.c
@@ -479,6 +479,11 @@ writefile(time_t runtimer, char queue)
 
 istty = isatty(fileno(stdin));
 if (istty) {
+   runtime = localtime(&runtimer);
+
+   strftime(timestr, TIMESIZE, TIMEFORMAT_POSIX, runtime);
+   fprintf(stderr, "at %s\n", timestr);
+
fprintf(stderr, "at> ");
fflush(stderr);
 }

-- 
--
Já que a primeira impressão é a que fica, então use uma
impressora Laser.


signature.asc
Description: PGP signature

Bug#863045: at: interactively please print parsed time at start

[Jose M Calhariz]

On July 17, 2019 5:09:01 AM GMT-03:00, Daniel Shahaf  
wrote:
>Jose M Calhariz wrote on Wed, 17 Jul 2019 02:03 +00:00:
>> I am working in a new release of at and I have a draft of this
>> feature.  If you are interested in beta testing it, I can prepare a
>> package for most releases of Debian on i386 ou amd64.
>
>Thanks for looking into this and for offering to prepare a beta
>package!
>There'll be no need for a beta package, however; a patch against the
>current
>stretch or sid package will be sufficient.  I should be able to find
>time to build
>it and give it a test drive.
>
>Thanks again,
>
>Daniel

I will send a patch from my other email. 

Kind regards 
Jose M Calhariz 


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Bug#863045: at: interactively please print parsed time at start

[Daniel Shahaf]

Jose M Calhariz wrote on Wed, 17 Jul 2019 02:03 +00:00:
> I am working in a new release of at and I have a draft of this
> feature.  If you are interested in beta testing it, I can prepare a
> package for most releases of Debian on i386 ou amd64.

Thanks for looking into this and for offering to prepare a beta package!
There'll be no need for a beta package, however; a patch against the current
stretch or sid package will be sufficient.  I should be able to find time to 
build
it and give it a test drive.

Thanks again,

Daniel

Bug#863045: at: interactively please print parsed time at start

[Jose M Calhariz]

Hi,

I am working in a new release of at and I have a draft of this
feature.  If you are interested in beta testing it, I can prepare a
package for most releases of Debian on i386 ou amd64.

Kind regards
Jose M Calhariz

-- 
--
Se quer construir algo do nada, comece amando intensamente
seus pensamentos e sua imaginação. Um grande caminho começa
com o primeiro passo. O resto fica por conta das
circunstancias.


signature.asc
Description: PGP signature

Bug#863045: at: interactively please print parsed time at start

[Daniel Shahaf]

Package: at
Version: 3.1.16-1
Control: found -1 3.1.20-3
Severity: minor

Dear Maintainer,

Currently, at(1) prints the time at the end:

$ at tomorrow 
warning: commands will be executed using /bin/sh
at> : hello world 
at> 
job 10 at Sun May 21 19:06:00 2017
$ 

Please print the time before the first prompt, i.e., next to the warning.
This will help catching mistakes sooner.

Thanks!

Daniel
(I'm on jessie but I eyeballed the sid version (3.1.20-3) before reporting.)