Bug#868488: RFS: sokochez/0.6.2-1 ITP
Control: tag -1 moreinfo On Sun, 3 Sep 2017 16:11:00 +0200 Baptiste Pouget wrote: > Thank you, I the package used to work before making the changes you > suggested that's weird. > It seems I forgot to test it after making the changes… > I also have that issue on the current version. > I don't know where it could come from. > Well I will have a look at it maybe later… Taggin moreinfo until you find time to take a look. Remove the tag when ready for the next round of review.
Bug#868488: RFS: sokochez/0.6.2-1 ITP
Thank you, I the package used to work before making the changes you suggested that's weird. It seems I forgot to test it after making the changes… I also have that issue on the current version. I don't know where it could come from. Well I will have a look at it maybe later… On 2017-09-03 03:50, Adam Borowski wrote: > Please keep 868...@bugs.debian.org in To: or CC: so there's a record of > review done and that others can chime in too. > > On Sat, Sep 02, 2017 at 10:24:43PM +0200, Baptiste Pouget wrote: >> Thank you for your help ! >> I now have fixed the issues you mentionned. >> Is there any issue left or is my package ready ? > > There's no manpage for sokochez-story, nor a hint what's the difference > between it and sokochez. > > And, how do you even run it? No matter what options I give to it, the > result is: > [~]$ sokochez /usr/share/games/sokochez/maps/clear/nivoo.txt > Sokochez Help > Usage : [flags] level[s] > -e : editor mode > -h : print help > > Changing > bool editor; > bool help; > to > bool editor = 0; > bool help = 0; > makes it at least start, but I did not pore over the code to see what other > uninitialized variables you might have. > > As the package doesn't work when built using the packaging you provided -- > have you ever tested it? > > None of provided documentation suggests what the game's objective is nor > what are its rules are. > > The package's description could use some fleshing out -- at least mentioning > the user interface (curses-like) would be good. I'd also change the wording > of "two players game" -- it suggests it's meant to be played by two people > while the puzzle instead has two player-controlled characters. > > > But in general -- while the packaging is not far from being acceptable, the > contents don't strike me as very useful in the present shape. > > > Meow! > -- Baptiste Pouget 🅱🅰🅱🅰 😄👌
Bug#868488: RFS: sokochez/0.6.2-1 ITP
Please keep 868...@bugs.debian.org in To: or CC: so there's a record of review done and that others can chime in too. On Sat, Sep 02, 2017 at 10:24:43PM +0200, Baptiste Pouget wrote: > Thank you for your help ! > I now have fixed the issues you mentionned. > Is there any issue left or is my package ready ? There's no manpage for sokochez-story, nor a hint what's the difference between it and sokochez. And, how do you even run it? No matter what options I give to it, the result is: [~]$ sokochez /usr/share/games/sokochez/maps/clear/nivoo.txt Sokochez Help Usage : [flags] level[s] -e : editor mode -h : print help Changing bool editor; bool help; to bool editor = 0; bool help = 0; makes it at least start, but I did not pore over the code to see what other uninitialized variables you might have. As the package doesn't work when built using the packaging you provided -- have you ever tested it? None of provided documentation suggests what the game's objective is nor what are its rules are. The package's description could use some fleshing out -- at least mentioning the user interface (curses-like) would be good. I'd also change the wording of "two players game" -- it suggests it's meant to be played by two people while the puzzle instead has two player-controlled characters. But in general -- while the packaging is not far from being acceptable, the contents don't strike me as very useful in the present shape. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Vat kind uf sufficiently advanced technology iz dis!? ⢿⡄⠘⠷⠚⠋⠀ -- Genghis Ht'rok'din ⠈⠳⣄
Bug#868488: RFS: sokochez/0.6.2-1 ITP
On Sun, Jul 16, 2017 at 01:18:17AM +0200, Baptiste Pouget wrote: > * Package name: sokochez >Version : 0.6.2-1 >Upstream Author : Baptiste Pouget > * URL : https://github.com/Sokochez/sokochez > * License : GPLv3 >Section : games > > It builds those binary packages: > > sokochez - two players puzzle game The "Depends:" stanza in binary package is missing; the executable needs at the very least glibc. This would be autogenerated but you're missing 「${shlibs:Depends}」 in the control file. Is there a reason you build-depend on an old version of g++? You also don't pass recommended build flags to the compiler. As you use raw make rather than a build system, you'd need to pass the output of dpkg-buildflags yourself. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Vat kind uf sufficiently advanced technology iz dis!? ⢿⡄⠘⠷⠚⠋⠀ -- Genghis Ht'rok'din ⠈⠳⣄
Bug#868488: RFS: sokochez/0.6.2-1 ITP
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "sokochez" * Package name: sokochez Version : 0.6.2-1 Upstream Author : Baptiste Pouget * URL : https://github.com/Sokochez/sokochez * License : GPLv3 Section : games It builds those binary packages: sokochez - two players puzzle game To access further information about this package, please visit the following URL: https://mentors.debian.net/package/sokochez Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/s/sokochez/sokochez_0.6.2-1.dsc This was the template from mentors.debian.net but I hope someone will like Sokochez so it can be made available for everyone running Debian :) ! Thank you ! Regards, Baptiste Pouget -- System Information: Debian Release: 9.0 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)