Bug#869360: slic3r: missing dependency on perlapi-*

2017-11-28 Thread Andreas Beckmann 
Followup-For: Bug #869360

Fixed in stretch with the attached patch.


Andreas
diff -Nru slic3r-1.2.9+dfsg/debian/changelog slic3r-1.2.9+dfsg/debian/changelog
--- slic3r-1.2.9+dfsg/debian/changelog  2016-11-03 03:23:40.0 +0100
+++ slic3r-1.2.9+dfsg/debian/changelog  2017-11-27 04:09:35.0 +0100
@@ -1,3 +1,20 @@
+slic3r (1.2.9+dfsg-6.1~deb9u1) stretch; urgency=medium
+
+  * Non-maintainer upload.
+  * Rebuild for stretch.
+
+ -- Andreas Beckmann   Mon, 27 Nov 2017 04:09:35 +0100
+
+slic3r (1.2.9+dfsg-6.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "missing dependency on perlapi-*":
+add override_dh_perl in debian/rules to make dh_perl search for perl
+modules in the private directory as well.
+(Closes: #869360)
+
+ -- gregor herrmann   Sun, 06 Aug 2017 13:27:56 -0400
+
 slic3r (1.2.9+dfsg-6) unstable; urgency=medium
 
   * [9db9b59] Shift perl modules into private directories.
diff -Nru slic3r-1.2.9+dfsg/debian/rules slic3r-1.2.9+dfsg/debian/rules
--- slic3r-1.2.9+dfsg/debian/rules  2016-11-03 03:23:40.0 +0100
+++ slic3r-1.2.9+dfsg/debian/rules  2017-07-22 19:27:47.0 +0200
@@ -55,3 +55,7 @@
# Install example post-processing scripts
mkdir -p $(CURDIR)/debian/slic3r/usr/share/doc/slic3r/examples
cp -r utils/post-processing 
$(CURDIR)/debian/slic3r/usr/share/doc/slic3r/examples
+
+override_dh_perl:
+   # make dh_perl search for perl modules in the private directory as well
+   dh_perl /usr/lib/slic3r

Bug#869360: slic3r: missing dependency on perlapi-*

2017-07-22 Thread gregor herrmann 
Control: tag -1 + patch

On Sat, 22 Jul 2017 19:33:56 +0300, Niko Tyni wrote:

> The fix is probably something like
> 
>   override_dh_perl:
>   dh_perl /usr/lib/slic3r
> 
> so that dh_perl knows about the private library directory.

This works indeed, patch attached.

Result:

 Depends: libboost-geometry-utils-perl, libencode-locale-perl, 
libio-stringy-perl, libmath-convexhull-monotonechain-perl, 
libmath-geometry-voronoi-perl, libmath-planepath-perl, libmoo-perl, 
libstorable-perl, libtime-hires-perl, perl (>= 5.26.0-4), perlapi-5.26.0, libc6 
(>= 2.14), libgcc1 (>= 1:3.0), libstdc++6 (>= 5.2)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: das hinterhaus
diff -Nru slic3r-1.2.9+dfsg/debian/changelog slic3r-1.2.9+dfsg/debian/changelog
--- slic3r-1.2.9+dfsg/debian/changelog	2016-11-03 03:23:40.0 +0100
+++ slic3r-1.2.9+dfsg/debian/changelog	2017-07-22 18:48:04.0 +0200
@@ -1,3 +1,13 @@
+slic3r (1.2.9+dfsg-6.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "missing dependency on perlapi-*":
+add override_dh_perl in debian/rules to make dh_perl search for perl
+modules in the private directory as well.
+(Closes: #869360)
+
+ -- gregor herrmann   Sat, 22 Jul 2017 18:48:04 +0200
+
 slic3r (1.2.9+dfsg-6) unstable; urgency=medium
 
   * [9db9b59] Shift perl modules into private directories.
diff -Nru slic3r-1.2.9+dfsg/debian/rules slic3r-1.2.9+dfsg/debian/rules
--- slic3r-1.2.9+dfsg/debian/rules	2016-11-03 03:23:40.0 +0100
+++ slic3r-1.2.9+dfsg/debian/rules	2017-07-22 18:48:04.0 +0200
@@ -55,3 +55,7 @@
 	# Install example post-processing scripts
 	mkdir -p $(CURDIR)/debian/slic3r/usr/share/doc/slic3r/examples
 	cp -r utils/post-processing $(CURDIR)/debian/slic3r/usr/share/doc/slic3r/examples
+
+override_dh_perl:
+	# make dh_perl search for perl modules in the private directory as well
+	dh_perl /usr/lib/slic3r


signature.asc
Description: Digital Signature

Bug#869360: slic3r: missing dependency on perlapi-*

2017-07-22 Thread Niko Tyni 
Package: slic3r
Version: 1.2.9+dfsg-6
Severity: serious
Tags: buster sid
User: debian-p...@lists.debian.org
Usertags: perl-5.26-transition
X-Debbugs-Cc: p...@packages.debian.org

This package contains a binary ("XS") Perl module
 /usr/lib/slic3r/auto/Slic3r/XS/XS.so
but does not depend on perlapi-*. This is a violation
of the Debian Perl policy, quoting:

  4.4.2. Binary and Other Architecture Dependent Modules

  Binary modules must specify a dependency on either perl or
  perl-base with a minimum version of the perl package used to build the
  module. Additionally, all binary modules (regardless of their installation
  directory) and any other modules installed into $Config{vendorarch} must
  depend on the expansion of perlapi-$Config{debian_abi} using the Config
  module. If $Config{debian_abi} is empty or not set, $Config{version}
  must be used.

The perlapi-* dependency guarantees that the binary module is compatible
with the version of perl on the system.

I see the release team tools have spotted this package and scheduled
binNMUs for the ongoing Perl 5.26 transition, probably because
older versions with the perlapi-* dependency are still around on some
architectures.  Still, partial upgrades (upgrading perl without upgrading
slic3r or vice versa) will result in breakage.

The fix is probably something like

  override_dh_perl:
  dh_perl /usr/lib/slic3r

so that dh_perl knows about the private library directory.

Once this is fixed, please file a bug against perl so we can add a
Breaks entry for older versions. This makes sure partial upgrades from
stretch work.
-- 
Niko Tyni   nt...@debian.org