Bug#872361: Info received (Bug#872361: mpg123 misparses IPv6 address + port in http_proxy)

[Thomas Orgis]

And? Any confirmation of the fix?


pgprqQo42wvpj.pgp
Description: Firma digital OpenPGP

Bug#872361: mpg123 misparses IPv6 address + port in http_proxy

[Thomas Orgis]

Am Sun, 03 Sep 2017 20:07:43 +
schrieb Ivan Shmakov : 

>  > https://mpg123.org/test/mpg123-1.25.7.tar.bz2  
> 
> […]
> 
>  > Ivan, can you test your two issues with the preliminary release and
>  > give feedback before I make it official?  
> 
>   The IPv6 http_proxy= handling seems to be the other way around
>   now; for instance:

Indeed. Please test the updated preview tarball.


Alrighty then,

Thomas


pgp9o8kqHb5hK.pgp
Description: Firma digital OpenPGP

Bug#872361: mpg123 misparses IPv6 address + port in http_proxy

[Ivan Shmakov]

> Thomas Orgis  writes:

 > I prepared fixes for both bug 872362 and 872361 for an upcoming
 > mpg123 version 1.25.7.  A preliminary release tarball is available
 > via

 > https://mpg123.org/test/mpg123-1.25.7.tar.bz2

[…]

 > Ivan, can you test your two issues with the preliminary release and
 > give feedback before I make it official?

The IPv6 http_proxy= handling seems to be the other way around
now; for instance:

$ http_proxy=http://ip6-localhost:9993/ \
  LD_LIBRARY_PATH=src/libout123/.libs ./src/mpg123 \
  -- http://stream.chipbit.net:8000/autodj.m3u 
High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3
version 1.25.7; written and copyright by Michael Hipp and others
free software (LGPL) without any warranty but with best wishes
HTTP request failed: 404 Not Found
main: [src/mpg123.c:686] error: Access to http resource 
http://stream.chipbit.net:8000/autodj.m3u failed.
$ http_proxy=http://\[::1\]:9993/ \
  LD_LIBRARY_PATH=src/libout123/.libs ./src/mpg123 \
  -- http://stream.chipbit.net:8000/autodj.m3u 
High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3
version 1.25.7; written and copyright by Michael Hipp and others
free software (LGPL) without any warranty but with best wishes

Directory: http://stream.chipbit.net:8000/

Terminal control enabled, press 'h' for listing of keys and functions.

Playing MPEG stream 1 of 1: autodj.m3u ...
ICY-NAME: ChipBit
ICY-URL: http://chipbit.net

MPEG 1.0 L III cbr128 44100 j-s

ICY-META: StreamTitle='General Offensive, Mrsonic699 - Insert Cartridge 
[Prelude]';
...

(Note that there's also an HTTP server on TCP port 80, which is
not configured as a proxy.)

-- 
FSF associate member #7257  58F8 0F47 53F5 2EB2 F6A5  8916 3013 B6A0 230E 334A

Bug#872361: mpg123 misparses IPv6 address + port in http_proxy

[Thomas Orgis]

(mpg123 upstream here)

Oh. Thanks for noticing. It has been some time since IPv6 support has been 
added, and frankly, the situation where I actually use IPv6 is rare. Specifying 
a proxy without DNS is even more rare.

It is for sure easy to fix, but I won't be able to work on this for about two 
weeks. Just so you know ..


Alrighty then,

Thomas
-- 
Sent from somewhere out there.

Bug#872361: mpg123 misparses IPv6 address + port in http_proxy

[Ivan Shmakov]

Package:  mpg123
Version:  1.23.8-1+b1

It appears that mpg123(1) fails to notice the :PORT suffix when
parsing an http_proxy value that contains an IPv6 address.

Consider, e. g.:

$ http_proxy=http://\[::1\]:8080/ \
  strace -o "$(mktemp -- /tmp/strace.)" -- \
  mpg123 --test -- http://stream.chipbit.net:8000/autodj.m3u 
High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3
version 1.23.8; written and copyright by Michael Hipp and others
free software (LGPL) without any warranty but with best wishes
HTTP request failed: 404 Not Found
main: [src/mpg123.c:709] error: Access to http resource 
http://stream.chipbit.net:8000/autodj.m3u failed.
$ 

The strace(1) output reveals that mpg123(1) tries to connect to
the default HTTP port (80), not the one specified (8080):

connect(3, {sa_family=AF_INET6, sin6_port=htons(80), inet_pton(AF_INET6, "::1", 
_addr), sin6_flowinfo=htonl(0), sin6_scope_id=0}, 28) = 0

Also to note is that using an (IPv6-only) name (as shown below)
in place of the IPv6 address does not cause the issue.

$ http_proxy=http://ip6-localhost:8080/ \
  mpg123 --test -- http://stream.chipbit.net:8000/autodj.m3u 

-- 
FSF associate member #7257  58F8 0F47 53F5 2EB2 F6A5  8916 3013 B6A0 230E 334A