Bug#875265: RFS: rednotebook/2.2-1 [ITP] [ITA] -- A cross-platform journal

2017-09-14 Thread Phil Wyett
On Tue, 2017-09-12 at 16:37 +0100, Phil Wyett wrote:
> On Tue, 2017-09-12 at 11:49 +0500, Andrey Rahmatullin wrote:
> > On Tue, Sep 12, 2017 at 04:13:20AM +0100, Phil Wyett wrote:
> > > > Why are you skipping tests?
> > 
> > Hmm?
> > 
> 
> I reserve comment until I have sought and had feedback from elsewhere.
> 
> > > > It seems that the package combines incompatible licenses (GPL-2 and
> > > > GPL-3+)?
> > > 
> > > To address the license issue. The upstream author used the file concerned
> > > prior
> > > to file being changed to GPL-2+. For reference, git commit for change to
> > > GPL-2+.
> > > 
> > > https://github.com/txt2tags/txt2tags/commit/716debb6ae7996e21201a74cfa6a30
> > > cb
> > > 8b25
> > > 32fe
> > 
> > If the code in rednotebook was copied before the license change then it's
> > under GPL-2 only and you cannot change the license header. Or did you mean
> > something else?
> > 
> 
> Sorry, I may have not explained this as fully as I should.
> 
> The rednotebook upstream author added txt2tags.py and then GPL-2 license data
> to
> his project prior to the txt2tags author changing his licensing to GPL-2+.
> This
> is why the data was bad in rednotebook. Updating (as done) to the now correct
> GPL-2+ txt2tags.py brings everything up to date and rectifies the situation.
> 
> > appdata_path_and_description.patch shouldn't be executable.
> 
> True. Happened on sid VM and cannot explain why as of yet. Will be rectified
> in
> next upload.
> 
> > rednotebook/external/txt2tags.py should have a section in d/copyright.
> 
> It does have.
> 
> > rednotebook/external/msgfmt.py doesn't contain a license, and as it's a
> > file from another author it shouldn't be assumed it's under the project
> > license.
> 
> Filed a bug upstream (rednotebook) for discussion and resolution. A new upload
> will follow the resolution of this.
> 
> Regards
> 
> Phil
> 

Hi,

Refreshed/New upload.

Your upload of the package 'rednotebook' to mentors.debian.net was
successful. Others can now see it. The URL of your package is:
https://mentors.debian.net/package/rednotebook

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/main/r/rednotebook/rednotebook_2.2-1.dsc


Changes since last upload:

* appdata_path_and_description.patch no longer executable.

* rednotebook/external/msgfmt.py from python and not locally edited so licensed
under upstream PSF-2 license. rednotebook author decision.

* rednotebook/external/txt2tags.py updated to latest upstream txt2tags version
via patch txt2tags_license_update.patch and in debian/copyright under GPL-2+.
File has been locally modified and appropriate change and copyright data appears
in file/patch and in debian/copyright.

Regards

Phil

-- 
*** If this is a mailing list, I am subscribed, no need to CC me.***

Playing the game for the games sake.

Web: https://kathenas.org

Github: https://github.com/kathenas

Twitter: kathenasorg

Instagram: kathenasorg

signature.asc
Description: This is a digitally signed message part


Bug#875265: RFS: rednotebook/2.2-1 [ITP] [ITA] -- A cross-platform journal

2017-09-14 Thread Phil Wyett
On Tue, 2017-09-12 at 18:45 +0100, Phil Wyett wrote:
> On Tue, 2017-09-12 at 22:12 +0500, Andrey Rahmatullin wrote:
> > On Tue, Sep 12, 2017 at 04:37:10PM +0100, Phil Wyett wrote:
> > > The rednotebook upstream author added txt2tags.py and then GPL-2 license
> > > data to
> > > his project prior to the txt2tags author changing his licensing to GPL-2+.
> > > This
> > > is why the data was bad in rednotebook. Updating (as done) to the now
> > > correct
> > > GPL-2+ txt2tags.py brings everything up to date and rectifies the
> > > situation.
> > 
> > Do you mean the code itself was not changed since then?
> > 
> > > > rednotebook/external/txt2tags.py should have a section in d/copyright.
> > > 
> > > It does have.
> > 
> > Indeed, sorry.
> > 
> 
> Hi,
> 
> Good call. I made an assumption when told the file was copied in, thinking as
> in
> with no modification and we all know what assumption leads to. :-)
> 
> * txt2tags latest release was 2010 - 2.6.
> * txt2tags has had many *many* commits since.
> * txt2tags seriously needs to do a release.
> * rednotebook version of txt2tags.py has been modified, but is it latest
>   upstream or upstream plus local modifications? Need to resolve.
> 
> I will address the above and more with the rednotebook author and get back
> with
> information.
> 
> Regards
> 
> Phil
> 

Hi,

Refreshed upload.

Your upload of the package 'rednotebook' to mentors.debian.net was
successful. Others can now see it. The URL of your package is:
https://mentors.debian.net/package/rednotebook

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/main/r/rednotebook/rednotebook_2.2-1.dsc

Regards

Phil

-- 
*** If this is a mailing list, I am subscribed, no need to CC me.***

Playing the game for the games sake.

Web: https://kathenas.org

Github: https://github.com/kathenas

Twitter: kathenasorg

Instagram: kathenasorg

signature.asc
Description: This is a digitally signed message part


Bug#875265: RFS: rednotebook/2.2-1 [ITP] [ITA] -- A cross-platform journal

2017-09-12 Thread Phil Wyett
On Tue, 2017-09-12 at 22:12 +0500, Andrey Rahmatullin wrote:
> On Tue, Sep 12, 2017 at 04:37:10PM +0100, Phil Wyett wrote:
> > The rednotebook upstream author added txt2tags.py and then GPL-2 license
> > data to
> > his project prior to the txt2tags author changing his licensing to GPL-2+.
> > This
> > is why the data was bad in rednotebook. Updating (as done) to the now
> > correct
> > GPL-2+ txt2tags.py brings everything up to date and rectifies the situation.
> 
> Do you mean the code itself was not changed since then?
> 
> > > rednotebook/external/txt2tags.py should have a section in d/copyright.
> > 
> > It does have.
> 
> Indeed, sorry.
> 

Hi,

Good call. I made an assumption when told the file was copied in, thinking as in
with no modification and we all know what assumption leads to. :-)

* txt2tags latest release was 2010 - 2.6.
* txt2tags has had many *many* commits since.
* txt2tags seriously needs to do a release.
* rednotebook version of txt2tags.py has been modified, but is it latest
  upstream or upstream plus local modifications? Need to resolve.

I will address the above and more with the rednotebook author and get back with
information.

Regards

Phil

-- 
*** If this is a mailing list, I am subscribed, no need to CC me.***

Playing the game for the games sake.

Web: https://kathenas.org

Github: https://github.com/kathenas

Twitter: kathenasorg

Instagram: kathenasorg

signature.asc
Description: This is a digitally signed message part


Bug#875265: RFS: rednotebook/2.2-1 [ITP] [ITA] -- A cross-platform journal

2017-09-12 Thread Andrey Rahmatullin
On Tue, Sep 12, 2017 at 04:37:10PM +0100, Phil Wyett wrote:
> The rednotebook upstream author added txt2tags.py and then GPL-2 license data 
> to
> his project prior to the txt2tags author changing his licensing to GPL-2+. 
> This
> is why the data was bad in rednotebook. Updating (as done) to the now correct
> GPL-2+ txt2tags.py brings everything up to date and rectifies the situation.
Do you mean the code itself was not changed since then?

> > rednotebook/external/txt2tags.py should have a section in d/copyright.
> 
> It does have.
Indeed, sorry.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#875265: RFS: rednotebook/2.2-1 [ITP] [ITA] -- A cross-platform journal

2017-09-12 Thread Phil Wyett
On Tue, 2017-09-12 at 11:49 +0500, Andrey Rahmatullin wrote:
> On Tue, Sep 12, 2017 at 04:13:20AM +0100, Phil Wyett wrote:
> > > Why are you skipping tests?
> 
> Hmm?
> 

I reserve comment until I have sought and had feedback from elsewhere.

> > > It seems that the package combines incompatible licenses (GPL-2 and
> > > GPL-3+)?
> > 
> > To address the license issue. The upstream author used the file concerned
> > prior
> > to file being changed to GPL-2+. For reference, git commit for change to
> > GPL-2+.
> > 
> > https://github.com/txt2tags/txt2tags/commit/716debb6ae7996e21201a74cfa6a30cb
> > 8b25
> > 32fe
> 
> If the code in rednotebook was copied before the license change then it's
> under GPL-2 only and you cannot change the license header. Or did you mean
> something else?
> 

Sorry, I may have not explained this as fully as I should.

The rednotebook upstream author added txt2tags.py and then GPL-2 license data to
his project prior to the txt2tags author changing his licensing to GPL-2+. This
is why the data was bad in rednotebook. Updating (as done) to the now correct
GPL-2+ txt2tags.py brings everything up to date and rectifies the situation.

> appdata_path_and_description.patch shouldn't be executable.

True. Happened on sid VM and cannot explain why as of yet. Will be rectified in
next upload.

> rednotebook/external/txt2tags.py should have a section in d/copyright.

It does have.

> rednotebook/external/msgfmt.py doesn't contain a license, and as it's a
> file from another author it shouldn't be assumed it's under the project
> license.

Filed a bug upstream (rednotebook) for discussion and resolution. A new upload
will follow the resolution of this.

Regards

Phil

-- 
*** If this is a mailing list, I am subscribed, no need to CC me.***

Playing the game for the games sake.

Web: https://kathenas.org

Github: https://github.com/kathenas

Twitter: kathenasorg

Instagram: kathenasorg

signature.asc
Description: This is a digitally signed message part