Bug#875563: Proposed fix
Christian Seiler writes: > Control: clone -1 -2 > Control: severity -2 wishlist > Control: retitle -2 Properly support multi-device btrfs setups in > tiny-initramfs > Control: tags -1 + confirmed pending > Control: tags -2 + confirmed > > On 09/12/2017 10:54 AM, Free Ekanayaka wrote: >> I've pushed a fix-btrfs-device-discover-875563 branch to the Alioth git >> repository of tiny-initramfs, based on debian/master and with this >> single commit: >> >> https://anonscm.debian.org/cgit/collab-maint/tiny-initramfs.git/commit/?h=fix-btrfs-device-discover-875563&id=fb124b6f73902eecddd88422e5c5ed82dd44a423 > > Thanks for the patch! Thank you for tiny-initramfs, I really like it! > I don't have a setup that uses both tiny-initramfs > _and_ btrfs here; I'll assume that your changes work for you. Yes, the work fine on my machine, where "/" is backed by btrfs. > (The code > looks good upon review, and I've tested that it doesn't cause any > regressions in my test setup with ext4.) > > I'll upload the fixed version in the next couple of minutes to sid. Great, awesome quick feedback. >> This solves the situation for the single-device case. I did not test the >> multi-device case, but it would probably require a bit more changes, >> this the current code in add_modules_for() assumes that there is only >> one block device to handle. > > Yes, and mounting might potentially require some changes as well. I > have hence cloned the bug report to separate this specific sub-issue > out. Agreed.
Bug#875563: Proposed fix
Control: clone -1 -2 Control: severity -2 wishlist Control: retitle -2 Properly support multi-device btrfs setups in tiny-initramfs Control: tags -1 + confirmed pending Control: tags -2 + confirmed On 09/12/2017 10:54 AM, Free Ekanayaka wrote: > I've pushed a fix-btrfs-device-discover-875563 branch to the Alioth git > repository of tiny-initramfs, based on debian/master and with this > single commit: > > https://anonscm.debian.org/cgit/collab-maint/tiny-initramfs.git/commit/?h=fix-btrfs-device-discover-875563&id=fb124b6f73902eecddd88422e5c5ed82dd44a423 Thanks for the patch! I don't have a setup that uses both tiny-initramfs _and_ btrfs here; I'll assume that your changes work for you. (The code looks good upon review, and I've tested that it doesn't cause any regressions in my test setup with ext4.) I'll upload the fixed version in the next couple of minutes to sid. > This solves the situation for the single-device case. I did not test the > multi-device case, but it would probably require a bit more changes, > this the current code in add_modules_for() assumes that there is only > one block device to handle. Yes, and mounting might potentially require some changes as well. I have hence cloned the bug report to separate this specific sub-issue out. Regards, Christian signature.asc Description: OpenPGP digital signature
Bug#875563: Proposed fix
Hi, I've pushed a fix-btrfs-device-discover-875563 branch to the Alioth git repository of tiny-initramfs, based on debian/master and with this single commit: https://anonscm.debian.org/cgit/collab-maint/tiny-initramfs.git/commit/?h=fix-btrfs-device-discover-875563&id=fb124b6f73902eecddd88422e5c5ed82dd44a423 This solves the situation for the single-device case. I did not test the multi-device case, but it would probably require a bit more changes, this the current code in add_modules_for() assumes that there is only one block device to handle.
