Bug#876187: a failing dh_autoreconf -Dsomething fails to chdir back

2018-05-11 Thread Julian Andres Klode
Control: tag -1 pending

On Tue, Sep 19, 2017 at 02:08:34PM +0200, Helmut Grohne wrote:
> Package: dh-autoreconf
> Version: 14
> Severity: minor
> User: helm...@debian.org
> Usertags: rebootstrap
> 
> A failing dh_autoreconf -Dsomedir fails to chdir back and thus errors
> out creating debian/autoreconf.after in the wrong directory.
> 
> Suppose the autoreconf call fails (=> severity=minor). Then doit raises
> an exception and the "chdir $pwd;" call in the eval block is skipped.
> The next "complex_doit("$find > debian/autoreconf.after");" operates in
> the wrong directory and bad things happen.
> 
> I suggest pulling the final chdir and the initial getcwd out of the
> eval block.

Fixed in

https://salsa.debian.org/debian/dh-autoreconf/commit/c3e1806aee8b3febe28f8bdae33a785e2a656326

- thanks.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer  i speak de, en



Bug#876187: a failing dh_autoreconf -Dsomething fails to chdir back

2017-09-19 Thread Helmut Grohne
Package: dh-autoreconf
Version: 14
Severity: minor
User: helm...@debian.org
Usertags: rebootstrap

A failing dh_autoreconf -Dsomedir fails to chdir back and thus errors
out creating debian/autoreconf.after in the wrong directory.

Suppose the autoreconf call fails (=> severity=minor). Then doit raises
an exception and the "chdir $pwd;" call in the eval block is skipped.
The next "complex_doit("$find > debian/autoreconf.after");" operates in
the wrong directory and bad things happen.

I suggest pulling the final chdir and the initial getcwd out of the
eval block.

Helmut