Bug#876979: openvpn@.service is missing network-online.target

[Jörg Frings-Fürst]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hello Markus,

this bug is marked as fixed in release 2.4.3-4.
So I close this bug.

CU
Jörg
- -- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key: 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser


git:  https://jff.email/cgit/

Threema:  SYR8SJXB
Wire: @joergfringsfuerst
Skype:joergpenguin
Ring: jff
Telegram: @joergfringsfuerst


My wish list: 
 - Please send me a picture from the nature at your home.
-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEY+AHX8jUOrs1qzDuCfifPIyh0l0FAltexOkACgkQCfifPIyh
0l3Nkw//WNV2dQDH1rWKw6M51JxBl71VvYCuScDXGG14quCfBkWKudbVuBKfpzlT
FWAehhImMrwAbe+XIFKcvODilG/1ajeU0UAVRWRmeukskYZpDqzYVfAn4GBV0Hxo
3qG9gOFGUvJ9JDHBQ1JqrtDIn1CGtIBk+58jK75X/UzFf3MMexxYTHi4SIT6teLy
BebJoXuwyPwAg5dwmfn9aPNKCJlzDB0T/nZh/mkW3Ny7+d/cMbTt6XxiKZqgxdxA
A/uXQVRMl8ketHQWGl/l0k4rrNHDoGT9RzwlG04dCtx39Z+SJVGnBGHiMAkqFGXx
6e47J0Fu/J/Dx5n9gBWnR7fSa905YIqydubW6gYDsrYBUk6mq9Ky4ejOsPZFktl5
gV7hPbfA7h44BZ9ytp7EEcnxsmeQH+/xvH45SFMmdN2EBFMjszN9Y5Hr9/PIe6v3
nsjig63k+Yn9krH4pCe6ELfs8duC2C2IPu1anJPxGeYYNCdgs2V84oUV1kW7KfW9
Dw8C3K7SUxTdunNd4vUiNYOE97ZYlzG2ytcp+hhcGkGOPsy1Cp7hB2/qScQDbZ/5
FgzDyndJOCcvl5R1/E+XjzjAEgHJaQ356HG8jc/ubts5gRtZBrytZzkDlr4kVgjJ
Dp2EAdljGgjOfU3P2dvWVzLxLn/BMxt5nsFCv9Sw3mEZ+RqHIS8=
=P23O
-END PGP SIGNATURE-

Bug#876979: openvpn@.service is missing network-online.target

[Bernhard Schmidt]

Control: found -1 2.4.0-6
Control: fixed -1 2.4.3-4

On 09.10.2017 20:50, Bernhard Schmidt wrote:

Hi,

>> Package: openvpn
>> Version: 2.4.0-6+deb9u1
>> Severity: normal
>>
>> Dear Maintainer,
>>
>> the provided openvpn@.service script is missing 2 lines:
>> After=syslog.target network-online.target
>> Wants=network-online.target
>>
>> Without these lines the openvpn starts too early and doesn't find
>> available network devices it could bind to.
> 
> Do you bind your OpenVPN instance to a specific IP address (i.e. by
> using the "local" configuration option)?
> 
> Otherwise OpenVPN should start just fine even when only "lo" is
> configured at this point.
> 
> I'm not sure we want to fix this globally. As far as I understood
> depending on "network-online.target" should be avoided if possible,
> since the point of "external connectivity is available" is not easily
> determined.
> 
> You can add this locally by executing
> 
> $ sudo systemctl add-wants openvpn@.service network-online.target

I fear I have to change my answer a bit.

1.) The requested change has already been done in Buster, in 2.4.3-4

2.) add-wants does not help a lot here, since we don't only need a
"Wants" but also an "After" relationship to order it. Can you please try
to add a file

/etc/systemd/system/openvpn@.service.d/after-network-online.conf

with the following content?

===
[Unit]
After=network-online.target
Wants=network-online.target
===

Bernhard

Bug#876979: openvpn@.service is missing network-online.target

[Bernhard Schmidt]

On 27.09.2017 12:05, Markus Kolb wrote:

Hi Markus,

> Package: openvpn
> Version: 2.4.0-6+deb9u1
> Severity: normal
> 
> Dear Maintainer,
> 
> the provided openvpn@.service script is missing 2 lines:
> After=syslog.target network-online.target
> Wants=network-online.target
> 
> Without these lines the openvpn starts too early and doesn't find
> available network devices it could bind to.

Do you bind your OpenVPN instance to a specific IP address (i.e. by
using the "local" configuration option)?

Otherwise OpenVPN should start just fine even when only "lo" is
configured at this point.

I'm not sure we want to fix this globally. As far as I understood
depending on "network-online.target" should be avoided if possible,
since the point of "external connectivity is available" is not easily
determined.

You can add this locally by executing

$ sudo systemctl add-wants openvpn@.service network-online.target

Bernhard

Bug#876979: openvpn@.service is missing network-online.target

[Michael Biebl]

On Wed, 27 Sep 2017 12:05:39 +0200 Markus Kolb  wrote:
> Package: openvpn
> Version: 2.4.0-6+deb9u1
> Severity: normal
> 
> Dear Maintainer,
> 
> the provided openvpn@.service script is missing 2 lines:
> After=syslog.target network-online.target
> Wants=network-online.target
> 

Please don't use After=syslog.target.
This target is obsolete and should not be used anymore.
syslog services are supposed to be socket activated so an explicit
ordering is not needed.



signature.asc
Description: OpenPGP digital signature

Bug#876979: openvpn@.service is missing network-online.target

[Markus Kolb]

Package: openvpn
Version: 2.4.0-6+deb9u1
Severity: normal

Dear Maintainer,

the provided openvpn@.service script is missing 2 lines:
After=syslog.target network-online.target
Wants=network-online.target

Without these lines the openvpn starts too early and doesn't find
available network devices it could bind to.

Thanks for fixing.


-- System Information:
Debian Release: 9.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), 
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages openvpn depends on:
ii  debconf [debconf-2.0]  1.5.61
ii  init-system-helpers1.48
ii  iproute2   4.9.0-1
ii  libc6  2.24-11+deb9u1
ii  liblz4-1   0.0~r131-2+b1
ii  liblzo2-2  2.08-1.2+b2
ii  libpam0g   1.1.8-3.6
ii  libpkcs11-helper1  1.21-1
ii  libssl1.0.21.0.2l-2
ii  libsystemd0232-25+deb9u1
ii  lsb-base   9.20161125

Versions of packages openvpn recommends:
pn  easy-rsa  

Versions of packages openvpn suggests:
ii  openssl 1.1.0f-3
pn  resolvconf  

-- debconf information excluded

-- debsums errors found:
debsums: changed file /lib/systemd/system/openvpn@.service (from openvpn 
package)