Bug#877137: dman: broken error reporting
Javier Fernandez-Sanguino: [snip] > >> I can't remember where I read that the maintainer doesn't like >> maintaining scripts longer than a couple hundred lines, and this one >> grew to about 390 so in the end I didn't send it and forgot about the >> bug report. Today I remembered and here it is. > > It might have been in #861611, where Antoine Beaupré said it. I am not > against scripts >100 lines and your replacement has some nice > improvements that could be worth including. I'll wait until the other > co-maintainers review it before committing it, though. > Sounds good. Cheers.
Bug#877137: dman: broken error reporting
Control: tag -1 + pending On 29 September 2017 at 05:00, astian wrote: > I think that commit 27ac5129ce187c6f571cac25ef70553bb9c9d475 broke the > error message dman used to produce when it failed to fetch some page. > It says "not found: " but it no longer says what it didn't find. Indeed, there is an error in the script. I have fixed it in GIT. > I actually run into this several weeks ago and was ready to send a patch > back then, but then I ended up rewriting most when I decided to > implement caching. The script you provided looks quite nice. I am going to submit it as a separate bug report. > I can't remember where I read that the maintainer doesn't like > maintaining scripts longer than a couple hundred lines, and this one > grew to about 390 so in the end I didn't send it and forgot about the > bug report. Today I remembered and here it is. It might have been in #861611, where Antoine Beaupré said it. I am not against scripts >100 lines and your replacement has some nice improvements that could be worth including. I'll wait until the other co-maintainers review it before committing it, though. Regards Javier
Bug#877137: dman: broken error reporting
Package: debian-goodies Version: 0.75 Severity: minor Dear Maintainer, I think that commit 27ac5129ce187c6f571cac25ef70553bb9c9d475 broke the error message dman used to produce when it failed to fetch some page. It says "not found: " but it no longer says what it didn't find. I actually run into this several weeks ago and was ready to send a patch back then, but then I ended up rewriting most when I decided to implement caching. I can't remember where I read that the maintainer doesn't like maintaining scripts longer than a couple hundred lines, and this one grew to about 390 so in the end I didn't send it and forgot about the bug report. Today I remembered and here it is. Cheers. PS1: In case someone wants the modified script: https://paste.debian.net/988250/ PS2: In the beginning I took notes of the changes made (later ones went unrecorded): https://paste.debian.net/988249 -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.12.0-2-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages debian-goodies depends on: ii curl 7.55.1-1 ii dctrl-tools [grep-dctrl] 2.24-2+b1 ii perl 5.26.0-8 ii python3 3.5.3-3 ii whiptail 0.52.20-1+b1 Versions of packages debian-goodies recommends: ii lsof 4.89+dfsg-0.1 Versions of packages debian-goodies suggests: ii lsb-release 9.20170808 ii popularity-contest 1.65 ii xdg-utils 1.1.1-1 ii zenity 3.24.0-1 -- no debconf information
