Bug#877802: lintian: Please include file name and line number in output

2019-12-08 Thread Chris Lamb
Felix,

> Please let me pick your brain. My current solution is to instantiate
> tags as they are issued, but they are a bit cumbersome to use. 

I cannot recall I had a more concise approach beyond a bunch of
dirty "tag_with_filename"-like helpers/wrappers. Just to be clear,
this was very much a proof-of-concept.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-



Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Felix Lechner
Hi Chris,

On Sat, Dec 7, 2019 at 2:57 PM Chris Lamb  wrote:
>
> If it helps, my plan was that we call "tag" with many more arguments
> which all end up in said metadata, but each tag had a "to_string"
> method (or similar) that would render it into the existing flat,
> plaintext string... both for the benefit of retaining command-line
> conciseness but also for the benefit of existing overrides and to
> roll this out over many many releases.

Please let me pick your brain. My current solution is to instantiate
tags as they are issued, but they are a bit cumbersome to use. Did you
have a more concise approach?

Kind regards
Felix Lechner



Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Chris Lamb
Hi Felix,

> Mentioning source files and line numbers, on the other hand, requires
> a retooling in most checks.

Don't worry, I think we are talking about exactly the same thing.

I have a (very old) branch that starts to do this but I'm sure you
will get around to this before me though.

If it helps, my plan was that we call "tag" with many more arguments
which all end up in said metadata, but each tag had a "to_string"
method (or similar) that would render it into the existing flat,
plaintext string... both for the benefit of retaining command-line
conciseness but also for the benefit of existing overrides and to
roll this out over many many releases.

(As you imply, context is important to disambiguate points to filename
and — optionally — line number combinations in a source or binary
package.)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-



Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Felix Lechner
Hi Chris,

On Sat, Dec 7, 2019 at 12:43 PM Chris Lamb  wrote:
>
> (FYI there's a wishlist bug somewhere requesting machine-readable
> output in a format such as JSON/Yaml/etc. where the fields are
> consistent and named reliably)

>From my perspective it is a different, although perhaps more helpful
item. Machine readable output is coming soon. I need it for something
too.

Mentioning source files and line numbers, on the other hand, requires
a retooling in most checks. I may provide the infrastructure, but
getting that information consistently right is challenging, especially
in checks looking at installation (deb) packages.

Kind regards,
Felix Lechner



Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Chris Lamb
Hi Jelmer et al.,

> That said, I think it would be great to have this feature in lintian -
> easily being able to jump to the relevant line in an editor would be
> very useful.

(FYI there's a wishlist bug somewhere requesting machine-readable
output in a format such as JSON/Yaml/etc. where the fields are
consistent and named reliably)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-



Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Jelmer Vernooij
Hi Felix,

On Sat, Dec 07, 2019 at 06:03:15AM -0800, Felix Lechner wrote:
> Would more reporting detail, as outlined in this bug, be useful to
> lintian-brush or to D-Janitor?
Not directly, I think the lintian-info field in the lintian output is
more useful for the janitor.

That said, I think it would be great to have this feature in lintian -
easily being able to jump to the relevant line in an editor would be
very useful.

Jelmer

-- 
Jelmer Vernooij 
PGP Key: https://www.jelmer.uk/D729A457.asc


signature.asc
Description: PGP signature


Bug#877802: lintian: Please include file name and line number in output

2019-12-07 Thread Felix Lechner
Hi Jelmer,

Would more reporting detail, as outlined in this bug, be useful to
lintian-brush or to D-Janitor?

Kind regards
Felix Lechner