Package: libseccomp Version: 2.3.1-2.1 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu artful ubuntu-patch
Dear Maintainer, While doing some work on libseccomp in Ubuntu, I noticed that the exit code of the `make check` target was being ignored despite the tests passing on all architectures we build on. I think we should make test failures be fatal for the build as the old issues that caused Debian bug 721292 seem to have been fixed. In Ubuntu, the attached patch was applied to achieve the following: * debian/rules: Make test failures cause the build to fail (LP: #1657425) To test the attached patch, I injected a fake test failure into tests/13-basic-attrs.py and verified that the subsequent build failed. Thanks for considering the patch. Tyler -- System Information: Debian Release: stretch/sid APT prefers xenial-updates APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (400, 'xenial-proposed') Architecture: amd64 (x86_64) Kernel: Linux 4.4.0-96-generic (SMP w/12 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
diff -Nru libseccomp-2.3.1/debian/rules libseccomp-2.3.1/debian/rules --- libseccomp-2.3.1/debian/rules 2016-11-17 17:23:10.000000000 +0000 +++ libseccomp-2.3.1/debian/rules 2017-10-06 18:08:35.000000000 +0000 @@ -29,9 +29,3 @@ "usr/lib/$(DEB_HOST_MULTIARCH)/libseccomp.so.*" \ lib/$(DEB_HOST_MULTIARCH) dh_install --remaining-packages --list-missing - -override_dh_auto_test: -ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS))) - make check 2>&1 | tee regression.out && \ - grep -q "^ tests failed: 0" regression.out || true -endif
