Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Tom Lee]

>
> I don't expect that you have to do anything special, apart from "git
> pull" and keeping the changes in the next versions.


Yep! That's what I meant: I'll be sure to pull this change into the next
release.

I'll try to have a look to the package BTS for some weeks, to see if
> the package has new bugs as a consequence of this change; but just in
> case that I fail to notice, please tell me if such things happens or
> if you think that I can help in any way!


Appreciate it, will do.  :)

Cheers,
Tom

On Sun, Nov 19, 2017 at 4:50 PM, Manuel A. Fernandez Montecelo <
manuel.montez...@gmail.com> wrote:

> 2017-11-20 0:17 GMT+01:00 Tom Lee :
> > Thank you Manuel, go for it. This slipped off my radar, will try to get
> it
> > sorted out soon. Sorry folks!
>
> OK, rescheduled, thanks.
>
> I don't expect that you have to do anything special, apart from "git
> pull" and keeping the changes in the next versions.
>
> I'll try to have a look to the package BTS for some weeks, to see if
> the package has new bugs as a consequence of this change; but just in
> case that I fail to notice, please tell me if such things happens or
> if you think that I can help in any way!
>
>
> Cheers.
> --
> Manuel A. Fernandez Montecelo 
>



-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

2017-11-20 0:17 GMT+01:00 Tom Lee :
> Thank you Manuel, go for it. This slipped off my radar, will try to get it
> sorted out soon. Sorry folks!

OK, rescheduled, thanks.

I don't expect that you have to do anything special, apart from "git
pull" and keeping the changes in the next versions.

I'll try to have a look to the package BTS for some weeks, to see if
the package has new bugs as a consequence of this change; but just in
case that I fail to notice, please tell me if such things happens or
if you think that I can help in any way!


Cheers.
-- 
Manuel A. Fernandez Montecelo 

Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Tom Lee]

Thank you Manuel, go for it. This slipped off my radar, will try to get it
sorted out soon. Sorry folks!

Cheers,
Tom

On Nov 19, 2017 2:42 PM, "Manuel A. Fernandez Montecelo" <
manuel.montez...@gmail.com> wrote:

> Control: tags -1 + pending
>
>
> Hi,
>
> 2017-10-15 02:09 Manuel A. Fernandez Montecelo:
>
>> Hi,
>>
>> 2017-10-14 00:34 Helmut Grohne:
>>
>>> Source: hiredis
>>> Version: 0.13.3-2
>>> Tags: patch
>>> User: helm...@debian.org
>>> Usertags: rebootstrap
>>>
>>> hiredis fails to cross build from source, because it fails running tests
>>> that it shouldn't be running when DEB_BUILD_OPTIONS contains nocheck.
>>> After making it honour the nocheck option, hiredis cross builds
>>> successfully. Please consider applying the attached patch.
>>>
>>
>> I can offer to sponsor an upload or NMU, if it helps.
>>
>
> I am going to do a NMU with this change, uploaded to delayed/10.
>
> If you want me to cancel it please say so; if it's OK please tell me and
> I can re-schedule it to happen earlier.
>
> Since the package is under collab-maint, instead of attaching the diff I
> just pushed to the repo.
>
>
> Cheers.
> --
> Manuel A. Fernandez Montecelo 
>

Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Control: tags -1 + pending


Hi,

2017-10-15 02:09 Manuel A. Fernandez Montecelo:

Hi,

2017-10-14 00:34 Helmut Grohne:

Source: hiredis
Version: 0.13.3-2
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

hiredis fails to cross build from source, because it fails running tests
that it shouldn't be running when DEB_BUILD_OPTIONS contains nocheck.
After making it honour the nocheck option, hiredis cross builds
successfully. Please consider applying the attached patch.


I can offer to sponsor an upload or NMU, if it helps.


I am going to do a NMU with this change, uploaded to delayed/10.

If you want me to cancel it please say so; if it's OK please tell me and
I can re-schedule it to happen earlier.

Since the package is under collab-maint, instead of attaching the diff I
just pushed to the repo.


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Hi,

2017-10-14 00:34 Helmut Grohne:

Source: hiredis
Version: 0.13.3-2
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

hiredis fails to cross build from source, because it fails running tests
that it shouldn't be running when DEB_BUILD_OPTIONS contains nocheck.
After making it honour the nocheck option, hiredis cross builds
successfully. Please consider applying the attached patch.


I can offer to sponsor an upload or NMU, if it helps.


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#878474: hiredis FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck

[Helmut Grohne]

Source: hiredis
Version: 0.13.3-2
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

hiredis fails to cross build from source, because it fails running tests
that it shouldn't be running when DEB_BUILD_OPTIONS contains nocheck.
After making it honour the nocheck option, hiredis cross builds
successfully. Please consider applying the attached patch.

Helmut
diff --minimal -Nru hiredis-0.13.3/debian/changelog 
hiredis-0.13.3/debian/changelog
--- hiredis-0.13.3/debian/changelog 2015-12-05 03:31:27.0 +0100
+++ hiredis-0.13.3/debian/changelog 2017-10-14 00:28:52.0 +0200
@@ -1,3 +1,10 @@
+hiredis (0.13.3-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Honour DEB_BUILD_OPTIONS=nocheck (closes: #-1)
+
+ -- Helmut Grohne   Sat, 14 Oct 2017 00:28:52 +0200
+
 hiredis (0.13.3-2) unstable; urgency=medium
 
   * Ignore /tags
diff --minimal -Nru hiredis-0.13.3/debian/rules hiredis-0.13.3/debian/rules
--- hiredis-0.13.3/debian/rules 2015-12-05 03:31:27.0 +0100
+++ hiredis-0.13.3/debian/rules 2017-10-14 00:28:50.0 +0200
@@ -23,9 +23,11 @@
dh_installchangelogs CHANGELOG.md
 
 override_dh_auto_test:
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 ifeq ($(REDIS), 1)
make check
 endif
+endif
 
 override_dh_strip:
dh_strip --dbg-package=libhiredis-dbg