Bug#880047: proposed nmu to revert change

2019-05-09 Thread Peter Palfrader
On Thu, 09 May 2019, Peter Palfrader wrote:

> I plan to revert the -5 change from this bug which has also been
> reverted in the stretch upload.

uploaded to delayed 5.
-- 
|  .''`.   ** Debian **
  Peter Palfrader   | : :' :  The  universal
 https://www.palfrader.org/ | `. `'  Operating System
|   `-https://www.debian.org/



Bug#880047: proposed nmu to revert change

2019-05-09 Thread Peter Palfrader
I plan to revert the -5 change from this bug which has also been
reverted in the stretch upload.

It seems to be unnecessary.

diff -Nur postgrey-1.36-5/debian/changelog postgrey-1.36-5.1/debian/changelog
--- postgrey-1.36-5/debian/changelog2017-11-25 11:18:01.0 +0100
+++ postgrey-1.36-5.1/debian/changelog  2019-05-09 13:35:38.0 +0200
@@ -1,3 +1,14 @@
+postgrey (1.36-5.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Revert the 1.36-5 change due to a regression, discussed in #880047#.
+The same patch has also been included in 1.36-3+deb9u1 and reverted
+in 1.36-3+deb9u2.
+There is no point in creating a /var/run/postgrey/ to hold the pidfile
+as using /var/run/postgrey.pid seems to work just fine.
+
+ -- Peter Palfrader   Thu, 09 May 2019 13:35:38 +0200
+
 postgrey (1.36-5) unstable; urgency=medium
 
   * debian/postgrey.init: create /var/run/postgrey if it
diff -Nur postgrey-1.36-5/debian/postgrey.init 
postgrey-1.36-5.1/debian/postgrey.init
--- postgrey-1.36-5/debian/postgrey.init2017-11-25 11:18:01.0 
+0100
+++ postgrey-1.36-5.1/debian/postgrey.init  2019-05-09 13:35:08.0 
+0200
@@ -26,7 +26,7 @@
 DESC="postfix greylisting daemon"
 DAEMON_USER=postgrey
 
-PIDFILE=/var/run/postgrey/$DAEMON_NAME.pid
+PIDFILE=/var/run/$DAEMON_NAME.pid
 SCRIPTNAME=/etc/init.d/$DAEMON_NAME
 
 # Gracefully exit if the package has been removed.
@@ -55,14 +55,6 @@
 #   0 if daemon has been started
 #   1 if daemon was already running
 #   2 if daemon could not be started
-   if [ ! -d /var/run/postgrey/ ]
-   then
-mkdir /var/run/postgrey/
-chown $DAEMON_USER: /var/run/postgrey/
-chmod 0755 /var/run/postgrey/
-# Restore selinux context
-[ -x /sbin/restorecon ] && /sbin/restorecon /var/run/postgrey/
-   fi
 start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON 
--test > /dev/null \
 || return 1
 start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- 
\


Cheers,
-- 
|  .''`.   ** Debian **
  Peter Palfrader   | : :' :  The  universal
 https://www.palfrader.org/ | `. `'  Operating System
|   `-https://www.debian.org/