Bug#881281: ugly scaled icons in the toolar
Gartoon and Gartoon Redux. The offending item there should be the sun. And you should be using the debian default theme which is lacking a few symbols. As wxMaxima and debian use tango icons it is quite hard to tell which icon comes from where, optically. Kind regards, Gunter. Am 10. November 2017 13:19:34 MEZ schrieb Stanislav Maslovski : >Hi, > >I see the problem. Here on my system wxmaxima uses its own icons. They >look >bad when scaled. Also, the height of the toolbar is too large. >Can you point me to the icon theme you are using, so that I could check >this issue further? > >On Fri, Nov 10, 2017 at 5:37 AM, Gunter Königsmann > >wrote: > >> I had added the scaling because normally gtk+ automatically delivers >me >> the icons in the Right size. But >> - on some icon themes a few icons were grossly of the wrong size. >For >> example in my favourite theme I got a 512x512 pixel-sun on a 96dpi >display. >> - and on debian a few themes lack some standard icons so wxMaxima >falls >> back to the icons it comes with - that are big so scaling them down >still >> doesn't produce icons that are too blurry. >> >> If you >> - extend the patch to just scale the icons if they are obviously way >too >> big >> - and if you limit the scaling to 1/n and 1.5/n with n being an >integer >> (this will reduce the blur to a minimum in the cases scaling is >necessary) >> I'll apply it and upstream it so the next official release no more >scales >> icons on wxGTK. >> >> Thanks a lot, >> and kind regards, >> >> Gunter. >> > > > >-- >BR, >Stanislav -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
Bug#881281: ugly scaled icons in the toolar
Hi, I see the problem. Here on my system wxmaxima uses its own icons. They look bad when scaled. Also, the height of the toolbar is too large. Can you point me to the icon theme you are using, so that I could check this issue further? On Fri, Nov 10, 2017 at 5:37 AM, Gunter Königsmann wrote: > I had added the scaling because normally gtk+ automatically delivers me > the icons in the Right size. But > - on some icon themes a few icons were grossly of the wrong size. For > example in my favourite theme I got a 512x512 pixel-sun on a 96dpi display. > - and on debian a few themes lack some standard icons so wxMaxima falls > back to the icons it comes with - that are big so scaling them down still > doesn't produce icons that are too blurry. > > If you > - extend the patch to just scale the icons if they are obviously way too > big > - and if you limit the scaling to 1/n and 1.5/n with n being an integer > (this will reduce the blur to a minimum in the cases scaling is necessary) > I'll apply it and upstream it so the next official release no more scales > icons on wxGTK. > > Thanks a lot, > and kind regards, > > Gunter. > -- BR, Stanislav
Bug#881281: ugly scaled icons in the toolar
I had added the scaling because normally gtk+ automatically delivers me the icons in the Right size. But - on some icon themes a few icons were grossly of the wrong size. For example in my favourite theme I got a 512x512 pixel-sun on a 96dpi display. - and on debian a few themes lack some standard icons so wxMaxima falls back to the icons it comes with - that are big so scaling them down still doesn't produce icons that are too blurry. If you - extend the patch to just scale the icons if they are obviously way too big - and if you limit the scaling to 1/n and 1.5/n with n being an integer (this will reduce the blur to a minimum in the cases scaling is necessary) I'll apply it and upstream it so the next official release no more scales icons on wxGTK. Thanks a lot, and kind regards, Gunter.
Bug#881281: ugly scaled icons in the toolar
Package: wxmaxima
Version: 17.10.1-1
Severity: minor
Tags: patch
Hi,
This version of wxmaxima, as compared to 16.04.2, applies unnecessary scaling
to the toolbar
icons. The result of this scaling is very aestetically unpleasing to the point
of being disturbing.
If you look into the source code of ToolBar.c of ver. WxMaxima 16.04.2 you will
find that the
scaling is only applied when running on Windows or Mac, and disabled elsewhere.
So I did the same change to ver. 17.10.1, which you will find in the attached
patch.
I have checked that with this patch the toolbar icons look much better in all
resolutions
available on my display, which are
1920x1080 60.00*+
1680x1050 59.95
1600x900 60.00
1440x900 59.89
1280x1024 75.0260.02
1280x800 59.81
1280x720 60.00
1152x864 75.00
1024x768 75.0370.0760.00
800x600 75.0072.1960.3256.25
640x480 75.0072.8159.94
-- System Information:
Debian Release: 9.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500,
'stable'), (50, 'testing'), (10, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages wxmaxima depends on:
ii ibus-gtk3 1.5.14-3
ii libc6 2.24-11+deb9u1
ii libgcc1 1:6.3.0-18
ii libstdc++66.3.0-18
ii libwxbase3.0-0v5 3.0.3.1+dfsg2-1
ii libwxgtk3.0-0v5 3.0.3.1+dfsg2-1
ii maxima5.38.1-8+b1
Versions of packages wxmaxima recommends:
ii maxima-doc 5.38.1-8
Versions of packages wxmaxima suggests:
ii fonts-jsmath 0.090709+0-3
ii texlive-latex-extra 2016.20170123-5
-- no debconf information
Description: Removes ugly icon scaling in toolbar
Author: Stanislav Maslovski
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: ,
Bug:
Bug-Debian: https://bugs.debian.org/
Bug-Ubuntu: https://launchpad.net/bugs/
Forwarded:
Reviewed-By:
Last-Update: 2017-11-09
--- wxmaxima-17.10.1.orig/src/ToolBar.cpp
+++ wxmaxima-17.10.1/src/ToolBar.cpp
@@ -43,9 +43,11 @@ wxImage ToolBar::GetImage(wxString name)
Dirstructure dirstructure;
img = wxImage(dirstructure.ConfigToolbarDir() + wxT("/") + name +
wxT(".png"));
}
+/*
double imgWidth = wxGetDisplayPPI().x*24/72;
double scaleFactor = imgWidth / img.GetWidth();
img.Rescale(img.GetWidth()*scaleFactor,img.GetHeight()*scaleFactor,wxIMAGE_QUALITY_HIGH
);
+ */
return img;
}
