Bug#886160: pptpd FTCBFS: fails to propagate CC to plugins/Makefile

2018-01-02 Thread James Cameron 
On Tue, Jan 02, 2018 at 07:49:13PM +0100, Christoph Biedl wrote:
> Helmut Grohne wrote...
> 
> > pptpd fails to cross build from source, because it fails to propagate CC
> > to plugins/Makefile. It is correctly detected by configure and correctly
> > forwarded to Makefile.am, but fails being forwarded to plugins/Makefile.
> > After making that forwarding explicit, pptpd cross builds successfully.
> > Please consider applying the attached patch.
> 
> Thanks for the report, and I trust your patch will do the right thing.
> Allow me a few days to handle it - besides technical issues on my side,
> perhaps upstream (*wave*) will use this as well, and I could cherry-pick
> then.

Accepted upstream, thanks!

4da603da51f41d6a7d58c3138e79f3ff12bc8c74

-- 
James Cameron
http://quozl.netrek.org/

Bug#886160: pptpd FTCBFS: fails to propagate CC to plugins/Makefile

2018-01-02 Thread Christoph Biedl 
Control: tags 886160 pending

Helmut Grohne wrote...

> pptpd fails to cross build from source, because it fails to propagate CC
> to plugins/Makefile. It is correctly detected by configure and correctly
> forwarded to Makefile.am, but fails being forwarded to plugins/Makefile.
> After making that forwarding explicit, pptpd cross builds successfully.
> Please consider applying the attached patch.

Thanks for the report, and I trust your patch will do the right thing.
Allow me a few days to handle it - besides technical issues on my side,
perhaps upstream (*wave*) will use this as well, and I could cherry-pick
then.

Christoph


signature.asc
Description: Digital signature

Bug#886160: pptpd FTCBFS: fails to propagate CC to plugins/Makefile

2018-01-02 Thread Helmut Grohne 
Source: pptpd
Version: 1.4.0-10
Tags: patch upstream
User: helm...@debian.org
Usertags: rebootstrap

pptpd fails to cross build from source, because it fails to propagate CC
to plugins/Makefile. It is correctly detected by configure and correctly
forwarded to Makefile.am, but fails being forwarded to plugins/Makefile.
After making that forwarding explicit, pptpd cross builds successfully.
Please consider applying the attached patch.

Helmut
Index: pptpd-1.4.0/Makefile.am
===
--- pptpd-1.4.0.orig/Makefile.am
+++ pptpd-1.4.0/Makefile.am
@@ -54,7 +54,7 @@
 subdirs = plugins
 
 all-local:
-	for d in $(subdirs); do $(MAKE) $(MFLAGS) -C $$d all; done
+	for d in $(subdirs); do $(MAKE) $(MFLAGS) 'CC=$(CC)' -C $$d all; done
 
 install-exec-local:
 	for d in $(subdirs); do $(MAKE) $(MFLAGS) -C $$d prefix=$(prefix) DESTDIR=$(DESTDIR) install; done