Bug#886179: foo2zjs: Don't recommend tk
Control: tags -1 +pending Le mardi, 2 janvier 2018, 22.21:14 h CET Jeremy Bicha a écrit : > foo2zjs used to recommend tix and tk until they were dropped to > suggests after complaints. See https://bugs.debian.org/601591 > > It was silently re-promoted to recommends at > https://anonscm.debian.org/cgit/printing/foo2zjs.git/commit/?id=859e9b > > I don't know much about the foo2zjs package but I thought the > recommends were only for the /usr/share/applications/hplj1020.desktop > which is hidden by default. > > 1. At least on Ubuntu, we don't want the tk and tix recommends. I am > attaching a patch for this in my next email (so that it includes this > bug number). I don't have much brain-time to spend on that package unfortunately, so I've integrated your patch, which makes total sense. Feel free to beat me for the upload! :-) Cheers, OdyX signature.asc Description: This is a digitally signed message part.
Bug#886179: foo2zjs: Don't recommend tk
Control: tags -1 +pending Le mardi, 2 janvier 2018, 22.21:14 h CET Jeremy Bicha a écrit : > foo2zjs used to recommend tix and tk until they were dropped to > suggests after complaints. See https://bugs.debian.org/601591 > > It was silently re-promoted to recommends at > https://anonscm.debian.org/cgit/printing/foo2zjs.git/commit/?id=859e9b > > I don't know much about the foo2zjs package but I thought the > recommends were only for the /usr/share/applications/hplj1020.desktop > which is hidden by default. > > 1. At least on Ubuntu, we don't want the tk and tix recommends. I am > attaching a patch for this in my next email (so that it includes this > bug number). I don't have much brain-time to spend on that package unfortunately, so I've integrated your patch, which makes total sense. Feel free to beat me for the upload! :-) Cheers, OdyX signature.asc Description: This is a digitally signed message part.
Bug#886179: foo2zjs: Don't recommend tk
From 9a278faf4c76d6cd88ed67a1a3b72a3ba3df9d96 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha
Date: Tue, 2 Jan 2018 16:09:54 -0500
Subject: [PATCH] Don't recommend tk on Ubuntu
Closes: #886179
---
debian/control | 4 ++--
debian/rules | 15 ---
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/debian/control b/debian/control
index 13ef4f5..fe135b7 100644
--- a/debian/control
+++ b/debian/control
@@ -41,8 +41,8 @@ Description: printer driver for ZjStream-based printers
Package: printer-driver-foo2zjs-common
Architecture: all
Depends: ${misc:Depends}
-Recommends: ${debian:tix}, tk, printer-driver-foo2zjs (>= ${source:Version})
-Suggests: ${ubuntu:tix}
+Recommends: ${debian:tix}, ${debian:tk}, printer-driver-foo2zjs (>= ${source:Version})
+Suggests: ${ubuntu:tix}, ${ubuntu:tk}
Enhances: printer-driver-foo2zjs (>= ${source:Version})
Breaks: udev (<< 136-1), cups (<< 1.5.0-3~), foo2zjs (<< 20111023dfsg0-1~), printer-driver-foo2zjs (<< 20131225dfsg0-5~)
Replaces: foo2zjs (<< 20111023dfsg0-1~), printer-driver-foo2zjs (<< 20131225dfsg0-5~)
diff --git a/debian/rules b/debian/rules
index 00368ff..bb4d3bb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -72,16 +72,17 @@ override_dh_gencontrol:
ifeq ($(derives_from_ubuntu),yes)
# Ubuntu considers mscompress to be a Depends of printer-driver-foo2zjs
echo "ubuntu:mscompress=mscompress" >> debian/printer-driver-foo2zjs.substvars
+ # Ubuntu considers tix to be a Suggests of printer-driver-foo2zjs
+ echo "ubuntu:tix=tix" >> debian/printer-driver-foo2zjs-common.substvars
+ # Ubuntu considers tk to be a Suggests of printer-driver-foo2zjs
+ echo "ubuntu:tk=tk" >> debian/printer-driver-foo2zjs-common.substvars
else
# Debian considers mscompress to be a Recommends of printer-driver-foo2zjs
echo "debian:mscompress=mscompress" >> debian/printer-driver-foo2zjs.substvars
-endif
-ifeq ($(derives_from_ubuntu),yes)
- # Ubuntu considers tix to be a Suggest of printer-driver-foo2zjs
- echo "ubuntu:tix=tix" >> debian/printer-driver-foo2zjs.substvars
-else
- # Debian considers tix to be a Depends of printer-driver-foo2zjs
- echo "debian:tix=tix" >> debian/printer-driver-foo2zjs.substvars
+ # Debian considers tix to be a Recommends of printer-driver-foo2zjs
+ echo "debian:tix=tix" >> debian/printer-driver-foo2zjs-common.substvars
+ # Debian considers tix to be a Recommends of printer-driver-foo2zjs
+ echo "debian:tk=tk" >> debian/printer-driver-foo2zjs-common.substvars
endif
dh_gencontrol
--
2.14.1
Bug#886179: foo2zjs: Don't recommend tk
Source: foo2zjs Version: 20170320dfsg0-2 Tags: patch foo2zjs used to recommend tix and tk until they were dropped to suggests after complaints. See https://bugs.debian.org/601591 It was silently re-promoted to recommends at https://anonscm.debian.org/cgit/printing/foo2zjs.git/commit/?id=859e9b I don't know much about the foo2zjs package but I thought the recommends were only for the /usr/share/applications/hplj1020.desktop which is hidden by default. 1. At least on Ubuntu, we don't want the tk and tix recommends. I am attaching a patch for this in my next email (so that it includes this bug number). 2. Or maybe the tix and tk recommends should be downgraded to Suggests on Debian too. I think it's worth mentioning that Debian actually has not recommended tix in 3 years because of a typo in https://anonscm.debian.org/cgit/printing/foo2zjs.git/commit/?id=3a8e1f (should be -common.substvars). This is fixed in my #1 patch. 3. Or maybe the .desktop should be split to a separate binary package. That way it can have the depends it needs and the .desktop could drop the NoDisplay=true line. I think users would find it easier to install the one package instead of needing to manually re-enable the .desktop (more difficult since the alacarte app isn't installed by default these days). Thanks, Jeremy Bicha
