Bug#886872: agrep: does not properly clean after build

2018-10-27 Thread Reiner Herrmann
Control: severity -1 important

Lowering the severity as it doesn't FTBFS on the first build.
Failing to build the second time is not RC.


signature.asc
Description: PGP signature


Bug#886872: agrep: does not properly clean after build

2018-01-10 Thread Andreas Beckmann
Source: agrep
Version: 4.17-9
Severity: serious
Tags: sid buster
Justification: fails to build from source

agrep does not properly clean up after a successful build, preventing
the package to build twice in a row:

 fakeroot debian/rules clean
dh clean
   dh_auto_clean
make -j1 clean
make[1]: Entering directory '/build/agrep-4.17'
rm -f ./libagrep.a follow.o asearch.o asearch1.o agrep.o bitap.o checkfile.o 
compat.o maskgen.o parse.o checksg.o preprocess.o delim.o asplit.o recursive.o 
sgrep.o newmgrep.o utilities.o dummyfilters.o main.o core a.out agrep
make[1]: Leaving directory '/build/agrep-4.17'
   debian/rules override_dh_clean
make[1]: Entering directory '/build/agrep-4.17'
#   The original sources contain *.orig and *.rej files
#   that must not be cleaned.
#   So do *not* run 'dh_clean' commands.
rm -rf debian/agrep debian/.#* debian/*[~#]
rm -f debian/files debian/*.log debian/*.substvars
[ ! -f Makefile ] || /usr/bin/make clean
make[2]: Entering directory '/build/agrep-4.17'
rm -f ./libagrep.a follow.o asearch.o asearch1.o agrep.o bitap.o checkfile.o 
compat.o maskgen.o parse.o checksg.o preprocess.o delim.o asplit.o recursive.o 
sgrep.o newmgrep.o utilities.o dummyfilters.o main.o core a.out agrep
make[2]: Leaving directory '/build/agrep-4.17'
make[1]: Leaving directory '/build/agrep-4.17'
 dpkg-source -b agrep-4.17
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: error: unwanted binary file: 
debian/.debhelper/agrep/dbgsym-root/usr/lib/debug/.build-id/be/89a6191e4c4a9a03b6705832d691ef157f9292.debug
dpkg-source: error: detected 1 unwanted binary file (add it in 
debian/source/include-binaries to allow its inclusion).
dpkg-buildpackage: error: dpkg-source -b agrep-4.17 subprocess returned exit 
status 29


Given that the source package format is already 3.0 (quilt),
deleting the superfluous *.orig and *.rej files is not really a
problem - dpkg-source will just ignore the deletion.
Therefore override_dh_clean could be dropped without bad effects
and would fix this bug.


Andreas


agrep_4.17-9_twice.log.gz
Description: application/gzip