Bug#887181: sosreport should depend on e2fsprogs explicitly

[Eric Desrochers]

Essential:
* util-linux (findmnt, lslocks, ...)

Non-Essential:
* mount
* e2fsprogs (e2freefrag, dumpe2fs, ...) # Demoted from Essential: yes to
XB-Important: yes as per bug #474540)
* lsof (lsof)

sosreport is fault tolerant to cmd not found situation inside plugins. Note
that there is no impact outside the fact that some plugins may not capture
information for a given command such as lsof (e.g. process.py, filesys.py,
...)

There is over 300 plugins as of today in sosreport and each of them may or
may not have distinct command and execution conditions, ... so obviously it
wouldn't be trivial to cover all potential scenarios.

Additionally, I would not want to have to manage a list of recommended
packages, but I do recognize that the command listed in the bug are a must
when it comes to troubleshooting/debugging/collecting data/... and can
definitely help users & 3rd party vendors support by avoiding extra steps
such as installing these packages manually, re-run sosreport or collect the
data individually, ...

I'm +1 to put in place a 'Recommends' instruction to cover this gap (mount,
e2fsprogs, lsof)

On Sun, Jan 10, 2021 at 5:05 PM Faidon Liambotis 
wrote:

> On Sun, Jan 21, 2018 at 08:09:07PM +0100, Louis Bouchard wrote:
> > Sorry for the late reply.
> >
> > sosreport is in fact designed to silently ignore situations where
> commands
> > issued are not available. So I do thing, as you suggest, that a Recommend
> > would be more suitable in that context.
> >
> > I will do my best to fix that as soon as possible.
>
> Eric, I noticed you recently took over the package. Did you have any
> thoughts on the bug? I just looked at the most recent source and can
> confirm Andreas' findings.
>
> It looks like adding e2fsprogs to Recommends (alongside, potentially,
> mount and lsof) should be enough to resolve this bug.
>
> Thanks!
> Faidon
>

Bug#887181: sosreport should depend on e2fsprogs explicitly

[Faidon Liambotis]

On Sun, Jan 21, 2018 at 08:09:07PM +0100, Louis Bouchard wrote:
> Sorry for the late reply.
> 
> sosreport is in fact designed to silently ignore situations where commands
> issued are not available. So I do thing, as you suggest, that a Recommend
> would be more suitable in that context.
> 
> I will do my best to fix that as soon as possible.

Eric, I noticed you recently took over the package. Did you have any
thoughts on the bug? I just looked at the most recent source and can
confirm Andreas' findings.

It looks like adding e2fsprogs to Recommends (alongside, potentially,
mount and lsof) should be enough to resolve this bug.

Thanks!
Faidon

Bug#887181: sosreport should depend on e2fsprogs explicitly

[Helmut Grohne]

Control: severity -1 minor

On Sun, Jan 21, 2018 at 08:09:07PM +0100, Louis Bouchard wrote:
> sosreport is in fact designed to silently ignore situations where commands
> issued are not available. So I do thing, as you suggest, that a Recommend
> would be more suitable in that context.
> 
> I will do my best to fix that as soon as possible.

Given that the outcome won't be adding a dependency, I am lowering the
severity. I intend to bump all normal bugs to important soon.

Helmut

Bug#887181: sosreport should depend on e2fsprogs explicitly

[Louis Bouchard]

Hello Andreas,

Sorry for the late reply.

sosreport is in fact designed to silently ignore situations where commands
issued are not available. So I do thing, as you suggest, that a Recommend
would be more suitable in that context.

I will do my best to fix that as soon as possible.

Kind regards,

...Louis

2018-01-21 9:59 GMT+01:00 Andreas Henriksson :

> On Sun, Jan 14, 2018 at 08:11:31PM +0100, Helmut Grohne wrote:
> > Package: sosreport
> [...]
> > /usr/share/sosreport/sos/plugins/cman.py contains debugfs. According to
> file it is a C++ source, ASCII text
> > /usr/share/sosreport/sos/plugins/dlm.py contains debugfs. According to
> file it is a C++ source, ASCII text
> > /usr/share/sosreport/sos/plugins/filesys.py contains dumpe2fs.
> According to file it is a C++ source, ASCII text
> > /usr/share/sosreport/sos/plugins/gfs2.py contains debugfs. According to
> file it is a C++ source, ASCII text
> > /usr/share/sosreport/sos/plugins/kvm.py contains debugfs. According to
> file it is a C++ source, ASCII text
> [...]
>
> All the debugfs matches seems to be false positives, but filesys.py is
> interesting.
>
> The following commands seems to be used (but I'm not sure exactly what
> the impact of them missing are, if only the information will be missing
> from report or complete failure):
> mount, df, findmnt, lsof, dumpe2fs
>
> It thus looks like the package might need to add the following
> dependencies:
> mount, lsof, e2fsprogs
>
> If command failure is ok, then a recommends might be more suitable.
> Would be great to hear something from the maintainer on this matter.
>
> Regards,
> Andreas Henriksson
>

Bug#887181: sosreport should depend on e2fsprogs explicitly

[Andreas Henriksson]

On Sun, Jan 14, 2018 at 08:11:31PM +0100, Helmut Grohne wrote:
> Package: sosreport
[...]
> /usr/share/sosreport/sos/plugins/cman.py contains debugfs. According to file 
> it is a C++ source, ASCII text
> /usr/share/sosreport/sos/plugins/dlm.py contains debugfs. According to file 
> it is a C++ source, ASCII text
> /usr/share/sosreport/sos/plugins/filesys.py contains dumpe2fs. According to 
> file it is a C++ source, ASCII text
> /usr/share/sosreport/sos/plugins/gfs2.py contains debugfs. According to file 
> it is a C++ source, ASCII text
> /usr/share/sosreport/sos/plugins/kvm.py contains debugfs. According to file 
> it is a C++ source, ASCII text
[...]

All the debugfs matches seems to be false positives, but filesys.py is
interesting.

The following commands seems to be used (but I'm not sure exactly what
the impact of them missing are, if only the information will be missing
from report or complete failure):
mount, df, findmnt, lsof, dumpe2fs

It thus looks like the package might need to add the following dependencies:
mount, lsof, e2fsprogs

If command failure is ok, then a recommends might be more suitable.
Would be great to hear something from the maintainer on this matter.

Regards,
Andreas Henriksson