Bug#887222: Bug#887189: golang-github-docker-docker-dev should depend on e2fsprogs explicitly

[Andreas Henriksson]

Hello Tianon,

On Mon, Feb 12, 2018 at 09:47:03AM -0800, Tianon Gravi wrote:
> I agree that this bug as filed doesn't make much sense, but it does
> point to one that does make sense IMO, which would be adding the two
> packages mentioned (e2fsprogs and xfsprogs) to Suggests over in
> docker.io instead (since there are configurations of Docker where it'd
> be appropriate and necessary to have those packages installed).

Thanks for your feedback. Since we seem to be in agreement I'll close
this bug report (via bcc) and for the record copy #887222 which is the bug
report where docker.io dependencies are discussed. Lets continue the
discussion in that bug report if needed.

Regards,
Andreas Henriksson

Bug#887189: golang-github-docker-docker-dev should depend on e2fsprogs explicitly

[Tianon Gravi]

On 12 February 2018 at 08:56, Andreas Henriksson  wrote:
> Apart from my first comment I'm not sure how useful it is to declare
> a dependency in the package shipping go *source* that utilizes a
> certain command. AIUI building go basically means you end up with
> something statically linked and the consumer of the go source needs
> to declare the dependency themselves (or atleast I'm not aware of any
> way for go packages to propagate dependencies via a substvar or
> similar).
>
> Thus my conclusion is that it's probably best to just close this bug
> report.

I agree that this bug as filed doesn't make much sense, but it does
point to one that does make sense IMO, which would be adding the two
packages mentioned (e2fsprogs and xfsprogs) to Suggests over in
docker.io instead (since there are configurations of Docker where it'd
be appropriate and necessary to have those packages installed).

♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

Bug#887189: golang-github-docker-docker-dev should depend on e2fsprogs explicitly

[Andreas Henriksson]

On Sun, Jan 14, 2018 at 08:05:18PM +0100, Helmut Grohne wrote:
> Package: golang-github-docker-docker-dev
[...]
> /usr/share/gocode/src/github.com/docker/docker/pkg/fsutils/fsutils_linux_test.go
>  contains mkfs.ext4. According to file it is a ASCII text

This file also contains mkfs.xfs but declares no relationship against
xfsprogs.

> /usr/share/gocode/src/github.com/docker/docker/pkg/mount/mountinfo_linux_test.go
>  contains debugfs. According to file it is a ASCII text

This seems to be a false positive from some kind of mountinfo
(/proc/mounts ?) and can likely be ignored.


Apart from my first comment I'm not sure how useful it is to declare
a dependency in the package shipping go *source* that utilizes a
certain command. AIUI building go basically means you end up with
something statically linked and the consumer of the go source needs
to declare the dependency themselves (or atleast I'm not aware of any
way for go packages to propagate dependencies via a substvar or
similar).

Thus my conclusion is that it's probably best to just close this bug
report.

Would be great to hear maintainers view on this!

Regards,
Andreas Henriksson