Bug#887214: nomad should depend on e2fsprogs explicitly
On Monday, 11 January 2021 8:42:44 AM AEDT Faidon Liambotis wrote: > It doesn't look like this code uses any binary from e2fsprogs, and > therefore I don't think a dependency is needed, i.e. I think this is a > false positive. > > Leaving this open for now in case the maintainer disagrees. Happy to > look into things further if that's the case. I also think it is a false positive. When I looked at it, I could not find explicit use of (anything from) e2fsprogs. Thanks for confirming. -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- A testimony is sufficient when it rests on: 1st. A great number of very sensible witnesses who agree in having seen well. 2nd. Who are sane, bodily and mentally. 3rd. Who are impartial and disinterested. 4th. Who unanimously agree. 5th. Who solemnly certify to the fact. -- Voltaire --- And how long a lockdown is enough? If we open now, will lockdown recur in autumn? Next year? Whenever authoritarianism so wishes? No dictatorship could imagine a better precedent for absolute control. -- https://www.bmj.com/content/369/bmj.m1924.long :: BMJ 2020;369:m1924 "Should governments continue lockdown to slow the spread of covid-19?" signature.asc Description: This is a digitally signed message part.
Bug#887214: nomad should depend on e2fsprogs explicitly
On Wed, Jan 24, 2018 at 12:23:13AM +0100, Andreas Henriksson wrote: > On Sun, Jan 14, 2018 at 08:08:14PM +0100, Helmut Grohne wrote: > > Package: nomad > [...] > > /usr/bin/nomad contains debugfs. According to file it is a ELF > > 64-bit LSB executable, x86-64, version 1 (SYSV) > [...] > > There doesn't seem to be any match for debugfs in the nomad source, so > I assume this comes from some golang library that's statically linked > into the binary (possibly golang-github-docker-docker-dev). I looked into this a bit further. The upstream repository --which has everything vendored-- was helpful for grepping here. I believe the text match comes from golang-github-shirou-gopsutil. Looking at the source for that package, in disk/disk_linux.go one can find a list of filesystems, including debugfs but also others. Some of the more easily greppable ones (cramfs, ecryptfs, gpfs) can be also found in /usr/bin/nomad, so it looks like this is the right match. It doesn't look like this code uses any binary from e2fsprogs, and therefore I don't think a dependency is needed, i.e. I think this is a false positive. Leaving this open for now in case the maintainer disagrees. Happy to look into things further if that's the case. Regards, Faidon
Bug#887214: nomad should depend on e2fsprogs explicitly
On Sun, Jan 14, 2018 at 08:08:14PM +0100, Helmut Grohne wrote: > Package: nomad [...] > /usr/bin/nomad contains debugfs. According to file it is a ELF 64-bit LSB > executable, x86-64, version 1 (SYSV) [...] There doesn't seem to be any match for debugfs in the nomad source, so I assume this comes from some golang library that's statically linked into the binary (possibly golang-github-docker-docker-dev). I'm not sure how or if such dependencies are supposed to automatically propagate. Should the golang dev package inject dependencies into misc:Depends or are this supposed to be manualy handled by the consuming application (which I would think leads to massive amount of bugs/mistakes as most manual things which doesn't give an obvious failure when you get it wrong). Would be great to get some feedback from the maintainer on this! Regards, Andreas Henriksson
