Bug#887216: rear should depend on e2fsprogs explicitly

[Frédéric Bonnard]

Hi Andreas and Helmut,
I crafted a new packaging for 2.3 upstream release one month ago and
came up to the same conclusion as Andreas, and if I remember correctly
I also confirmed this by testing without that dependency which led to
some issue.
Sorry for not detailing this here in the meantime, that would have save
you Andreas a bit of time, but I got hooked on other things and forgot.
I hope to release the new packaging soon.
Thanks,

F.

On Tue, 13 Feb 2018 18:29:59 +0100, Andreas Henriksson  wrote:
> On Sun, Jan 14, 2018 at 08:10:35PM +0100, Helmut Grohne wrote:
> > Package: rear
> [...]
> > /usr/share/rear/conf/GNU/Linux.conf contains e2fsck, fsck.ext2, fsck.ext3, 
> > fsck.ext4, mke2fs, mkfs.ext2, mkfs.ext3, mkfs.ext4 and tune2fs. According 
> > to file it is a ASCII text, with very long lines
> 
> The commands are listed in the PROGS variable, which also lists commands
> like ifconfig, etc. and their respective package is not listed in any
> relationship specified in the package. I'm thus assuming there's
> no need to explicitly list e2fsprogs either for this occurance.
> 
> 
> > /usr/share/rear/conf/examples/SLE12-SP1-btrfs-example.conf contains chattr 
> > and lsattr. According to file it is a ASCII text
> > /usr/share/rear/conf/examples/SLE12-SP2-btrfs-example.conf contains chattr 
> > and lsattr. According to file it is a ASCII text, with very long lines
> 
> Example files (for Suse?) are likely not important to consider.
> 
> > /usr/share/rear/format/USB/default/300_format_usb_disk.sh contains tune2fs. 
> > According to file it is a ASCII text
> > /usr/share/rear/format/USB/default/350_label_usb_disk.sh contains e2label. 
> > According to file it is a ASCII text
> 
> The above two executes the command and calls the Error function if
> failing.
> 
> > /usr/share/rear/layout/prepare/GNU/Linux/130_include_filesystem_code.sh 
> > contains tune2fs. According to file it is a ASCII text
> 
> The command is both used directly and written to a generate script.
> 
> > /usr/share/rear/layout/prepare/GNU/Linux/130_include_mount_subvolumes_code.sh
> >  contains chattr. According to file it is a ASCII text
> 
> The command is written to a generated script.
> 
> > /usr/share/rear/layout/save/GNU/Linux/230_filesystem_layout.sh contains 
> > chattr, e2label, lsattr and tune2fs. According to file it is a ASCII text
> 
> Commands are executed directly and there doesn't seem to be any real
> fault handling. The commands seems to be expected to be in place
> and work.
> 
> > /usr/share/rear/skel/default/etc/fstab contains debugfs. According to file 
> > it is a ASCII text
> [...]
> 
> This mostly seem to be an example of mounting debugfs filesystem. Not
> using the debugfs command.
> 
> My conclusion is based on the above that e2fsprogs should indeed
> be a dependency.
> 
> Would be great to hear maintainers view on this!
> 
> Regards,
> Andreas Henriksson
> 


pgpPSIhqZIezK.pgp
Description: PGP signature

Bug#887216: rear should depend on e2fsprogs explicitly

[Andreas Henriksson]

On Sun, Jan 14, 2018 at 08:10:35PM +0100, Helmut Grohne wrote:
> Package: rear
[...]
> /usr/share/rear/conf/GNU/Linux.conf contains e2fsck, fsck.ext2, fsck.ext3, 
> fsck.ext4, mke2fs, mkfs.ext2, mkfs.ext3, mkfs.ext4 and tune2fs. According to 
> file it is a ASCII text, with very long lines

The commands are listed in the PROGS variable, which also lists commands
like ifconfig, etc. and their respective package is not listed in any
relationship specified in the package. I'm thus assuming there's
no need to explicitly list e2fsprogs either for this occurance.


> /usr/share/rear/conf/examples/SLE12-SP1-btrfs-example.conf contains chattr 
> and lsattr. According to file it is a ASCII text
> /usr/share/rear/conf/examples/SLE12-SP2-btrfs-example.conf contains chattr 
> and lsattr. According to file it is a ASCII text, with very long lines

Example files (for Suse?) are likely not important to consider.

> /usr/share/rear/format/USB/default/300_format_usb_disk.sh contains tune2fs. 
> According to file it is a ASCII text
> /usr/share/rear/format/USB/default/350_label_usb_disk.sh contains e2label. 
> According to file it is a ASCII text

The above two executes the command and calls the Error function if
failing.

> /usr/share/rear/layout/prepare/GNU/Linux/130_include_filesystem_code.sh 
> contains tune2fs. According to file it is a ASCII text

The command is both used directly and written to a generate script.

> /usr/share/rear/layout/prepare/GNU/Linux/130_include_mount_subvolumes_code.sh 
> contains chattr. According to file it is a ASCII text

The command is written to a generated script.

> /usr/share/rear/layout/save/GNU/Linux/230_filesystem_layout.sh contains 
> chattr, e2label, lsattr and tune2fs. According to file it is a ASCII text

Commands are executed directly and there doesn't seem to be any real
fault handling. The commands seems to be expected to be in place
and work.

> /usr/share/rear/skel/default/etc/fstab contains debugfs. According to file it 
> is a ASCII text
[...]

This mostly seem to be an example of mounting debugfs filesystem. Not
using the debugfs command.

My conclusion is based on the above that e2fsprogs should indeed
be a dependency.

Would be great to hear maintainers view on this!

Regards,
Andreas Henriksson