Bug#887249: fsarchiver should depend on e2fsprogs explicitly

2018-02-20 Thread Michael Biebl 
On Wed, 24 Jan 2018 00:14:26 +0100 Andreas Henriksson 
wrote:
> On Sun, Jan 14, 2018 at 08:04:43PM +0100, Helmut Grohne wrote:
> > Package: fsarchiver
> [...]
> > /usr/sbin/fsarchiver contains e2fsck, mke2fs and tune2fs. According to file 
> > it is a ELF 64-bit LSB shared object, x86-64, version 1 (SYSV)
> [...]
> 
> The commands are all used in the extfs_mkfs function:
> https://sources.debian.org/src/fsarchiver/0.8.3-3/src/fs_ext2.c/#L145
> 
> Which in turn are called from the ext[234]_mkfs wrapper functions:
> https://sources.debian.org/src/fsarchiver/0.8.3-3/src/fs_ext2.c/#L92
> 
> Those functions are hooked up at:
> https://sources.debian.org/src/fsarchiver/0.8.3-3/src/filesys.c/#L49
> 
> Given that all non-ext* filesystems in that table are listed under
> Suggests I would guess e2fsprogs should be added to Suggests.
> (Or possibly promoted as ext being the favourite child to Recommends.)
> 
> Would be great to hear the maintainers view on this...

Recommends sounds about right, I'd say. It has the additional benefit,
that it would be installed on upgrades by default.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#887249: fsarchiver should depend on e2fsprogs explicitly

2018-01-23 Thread Andreas Henriksson 
On Sun, Jan 14, 2018 at 08:04:43PM +0100, Helmut Grohne wrote:
> Package: fsarchiver
[...]
> /usr/sbin/fsarchiver contains e2fsck, mke2fs and tune2fs. According to file 
> it is a ELF 64-bit LSB shared object, x86-64, version 1 (SYSV)
[...]

The commands are all used in the extfs_mkfs function:
https://sources.debian.org/src/fsarchiver/0.8.3-3/src/fs_ext2.c/#L145

Which in turn are called from the ext[234]_mkfs wrapper functions:
https://sources.debian.org/src/fsarchiver/0.8.3-3/src/fs_ext2.c/#L92

Those functions are hooked up at:
https://sources.debian.org/src/fsarchiver/0.8.3-3/src/filesys.c/#L49

Given that all non-ext* filesystems in that table are listed under
Suggests I would guess e2fsprogs should be added to Suggests.
(Or possibly promoted as ext being the favourite child to Recommends.)

Would be great to hear the maintainers view on this...

Regards,
Andreas Henriksson