Bug#887255: lvm2 should depend on e2fsprogs explicitly
On Sun, Jan 21, 2018 at 10:09:14AM +0100, Andreas Henriksson wrote: > The fsadm(.sh) script does indeed invoke both tune2fs and resize2fs > under certain circumstances, so from a laymans view there should > definitely be a dependency added. That's backwards. *If* you are using ext (for example) with lvm, then fsadm will help you to use it through those tools. You don't choose to install tools for a filesystem you aren't using just because you put lvm on the system! Alasdair
Bug#887255: lvm2 should depend on e2fsprogs explicitly
On Sun, Jan 21, 2018 at 10:09:14AM +0100, Andreas Henriksson wrote: > The fsadm(.sh) script does indeed invoke both tune2fs and resize2fs > under certain circumstances, so from a laymans view there should > definitely be a dependency added. It also needs resize_reiserfs and xfs_growfs, but there is no dependencies for them, so I don't consider that a worthy candidate for this minor funtionality. Bastian -- Youth doesn't excuse everything. -- Dr. Janice Lester (in Kirk's body), "Turnabout Intruder", stardate 5928.5.
Bug#887255: lvm2 should depend on e2fsprogs explicitly
On Sun, Jan 14, 2018 at 08:07:47PM +0100, Helmut Grohne wrote: > Package: lvm2 [...] > /sbin/fsadm contains resize2fs and tune2fs. According to file it is a > Bourne-Again shell script, ASCII text executable [...] The fsadm(.sh) script does indeed invoke both tune2fs and resize2fs under certain circumstances, so from a laymans view there should definitely be a dependency added. On the other hand maybe the fsadm script isn't that important to the rest of lvm and only offered as a convenience to the user. In that case it may possibly be argued that recommends would be ok to use instead of depends. Would be great to get some feedback from the maintainer(s)! Regards, Andreas Henriksson
