Bug#887276: fusioninventory-agent should depend on e2fsprogs explicitly

[Helmut Grohne]

Control: severity -1 minor

On Mon, Jan 22, 2018 at 08:00:14PM +0100, Andreas Henriksson wrote:
> I'm going to assume all the AIX files only applies to AIX systems, and
> is thus not relevant in a Debian context.

On AIX the lsattr command does not come from e2fsprogs and does
something completely different. You can safely ignore AIX stuff.

> This leaves Linux/Drives.pm and indeed it uses dumpe2fs, but (as it
> seems) only if it's available:
> https://sources.debian.org/src/fusioninventory-agent/1:2.3.16-1/lib/FusionInventory/Agent/Task/Inventory/Linux/Drives.pm/#L53
> 
> This makes me think e2fsprogs should not be a Depends, but possibly a
> Recommends or Suggests.

Downgrading severity accordingly.

Helmut

Bug#887276: fusioninventory-agent should depend on e2fsprogs explicitly

[Andreas Henriksson]

On Sun, Jan 14, 2018 at 08:04:47PM +0100, Helmut Grohne wrote:
> Package: fusioninventory-agent
[...]
> /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Inventory/AIX/CPU.pm
>  contains lsattr. According to file it is a Perl5 module source, ASCII text
> /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Inventory/AIX/Memory.pm
>  contains lsattr. According to file it is a Perl5 module source, ASCII text
> /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Inventory/AIX/Networks.pm
>  contains lsattr. According to file it is a Perl5 module source, ASCII text
> /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Inventory/AIX/Storages.pm
>  contains lsattr. According to file it is a Perl5 module source, ASCII text
> /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Inventory/Linux/Drives.pm
>  contains dumpe2fs. According to file it is a Perl5 module source, ASCII text
[...]

I'm going to assume all the AIX files only applies to AIX systems, and
is thus not relevant in a Debian context.

This leaves Linux/Drives.pm and indeed it uses dumpe2fs, but (as it
seems) only if it's available:
https://sources.debian.org/src/fusioninventory-agent/1:2.3.16-1/lib/FusionInventory/Agent/Task/Inventory/Linux/Drives.pm/#L53

This makes me think e2fsprogs should not be a Depends, but possibly a
Recommends or Suggests.

As can be seen near the same location in the code, there's also
support for xfs and dos/vfat filesystems. There's no relationship
specified against xfsprogs or dosfstools, so I'm guessing either
there's no need for e2fsprogs relationship or all three are missing
from Recommends or Suggests.

Would be great to hear from maintainers on this

Regards,
Andreas Henriksson